From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79123C00A8F for ; Tue, 24 Oct 2023 09:34:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 136886B01FA; Tue, 24 Oct 2023 05:34:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E72F6B01FB; Tue, 24 Oct 2023 05:34:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F17396B01FC; Tue, 24 Oct 2023 05:34:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E12E06B01FA for ; Tue, 24 Oct 2023 05:34:00 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B937B1CAF46 for ; Tue, 24 Oct 2023 09:34:00 +0000 (UTC) X-FDA: 81379843440.01.10F7740 Received: from out-203.mta0.migadu.com (out-203.mta0.migadu.com [91.218.175.203]) by imf14.hostedemail.com (Postfix) with ESMTP id 0CAF4100030 for ; Tue, 24 Oct 2023 09:33:58 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=WkSYYMuX; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.203 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698140039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mVsHpTi8/ybc90IBC2PUgLSTYbIjUF6GvQZHOJT0cXI=; b=RcqRT38ExOkCg+1oIZQCMHKNWLH9XUEmJmcHLBoRLOiKn3At9J4j35GJuCaBevnOlwkIjV iZ7ihl6S9H3hOCnmUaSiPCmNeqxD9/+p1znMcbmiTU1maA6WXnWuwX1PxBYJrD/+YZURqv UcBKh8unOyyZjntZ9JcPc/B0dNU+dLU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=WkSYYMuX; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.203 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698140039; a=rsa-sha256; cv=none; b=uR5vqXhhkHJhALWl/Om0wlVWVCYx86N1zZTwctmyhMF2LBqynQNsXs9UAuc2aOZRwM2HIx cT8XwUigJv6l6vfvq73xqlBm3lTLtY012MCJbv/nultPm9NXwhrWMDK9VT0lVe6NsDzyBl cT5Kv49THp2su9XdYgSyea3RBUfrRGk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698140037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mVsHpTi8/ybc90IBC2PUgLSTYbIjUF6GvQZHOJT0cXI=; b=WkSYYMuXGHeVTVvJKeEDkqylfQ5ISuw3VBdmhEEMq+LWy2qJeirb8he9LzRmfOp5qZ6+kT ZswKHPlHfUqDgf+oW4CzD+qBmu/0yksI5xZDpGRNHQHcev4VmDR1H8HChl9GYIrTSRecZo StPLjAgG42c97ebsxtS4Z+pyEQMwhsc= From: chengming.zhou@linux.dev To: cl@linux.com, penberg@kernel.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, chengming.zhou@linux.dev, Chengming Zhou Subject: [RFC PATCH v3 1/7] slub: Keep track of whether slub is on the per-node partial list Date: Tue, 24 Oct 2023 09:33:39 +0000 Message-Id: <20231024093345.3676493-2-chengming.zhou@linux.dev> In-Reply-To: <20231024093345.3676493-1-chengming.zhou@linux.dev> References: <20231024093345.3676493-1-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0CAF4100030 X-Stat-Signature: 9hpyqtzjowynopeph93puyupdksc8csw X-HE-Tag: 1698140038-798154 X-HE-Meta: U2FsdGVkX1/ZVY8SYS5p7pFOrL9ke1Erd9gYqweC2AbanJjrtFEHEahMci6KkXdSbM7K2/H72FLdPm2/OXfcC7V/hpvTYRqX2uhfEBlFTeiE2v+JR1xU9ADSyar4HMuwb0AGTiQ9SHsP3UEUE5y+ZIwn9B9yEY79LRFQo0CJfgi612vTGa3SOTZuoKPMTafR4AiyVSB/7Z361gx9BGZilfHd57hnr/FtIe30Yrx3QubkHKLiK4QB5fwnPq8FP27q1Xyq45m98D4zGRKiebeD7tIXIY6xLo+SwwnvGSXYj54ZCIZOF2jeuuT5r0Nm97AueaZPf2SNLTNL+nr3/c8A7ei7RJpaax3Tg0lux3ekaMfWafZ7hzZg7ynaonMPiH7UsOlhulgD98S8/9VWezm8S2nJWBNOMwTcWb/QjQ+HfvvgoARLvrn25EtXWW43hllQJo+CHQtOiXvsa7uNZJkREsuUsuLCLqkkgVQBADE7c19MT9SPwW0w3NHer5l+UW8ErnTlW8CqipQs85J/xMSK+9OnJHaeQk2h5hProN8hXxwLz2x+e+KRsCqIb8AwYushTVwDUZk2QOZAVeXFiNZxobNE72l+ekiCXXkTsTNmCnKGM1U4011CzNU6I9zSbR1RrftxL1guGO8abw8ohIowYp56l1PfOixhjOvoBacpyDrE9BGMvCRpABtorKAC/ZwWQUaLrxJCCBlBVEMe9AZNLoB51U0fdL+zetXJVjw7Ho4f7yLuaNQnVww6CREIMT7u4RsSQPoVgCDj0X57q6xBm148CTQgmmTC3dTO8NrZLvLHppK7aoHWI30nOWcmX+98KDc+Nf/d39lZb3klz3rT0jWAq0mbJFM41ntTbFbSa4saGK0PQqBHeRZFC4/S0h77E2flXsV4TYM3t/odh+uHMmdeFJ60LI4eA5uARXQ7bnrifidugRSDo31e9jLZE0DvhY52rTaDpGjDQFBb1+r KmThPJbt kdZaWiS1vCGmFUld2rHfREf0AYf/1mzAT7vJrXWhVC4Z/19PTWVyPioPucKhhBKlmOGtVOXf2VsXiAhdk3MLRn+eNajE0xeMr/Yl6cJd8jrBymZ/mTM1hfpLnvuTSJ97r7vpKtpEDCoPGfb3Yt0Ik+SQorOG/6KQPCUto0sLpgw6IMi6fALNwpaSOKdi37dE9p6cXoPTKHPl4M5A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Chengming Zhou Now we rely on the "frozen" bit to see if we should manipulate the slab->slab_list, which will be changed in the following patch. Instead we introduce another way to keep track of whether slub is on the per-node partial list, here we reuse the PG_workingset bit. We use __set_bit and __clear_bit directly instead of the atomic version for better performance and it's safe since it's protected by the slub node list_lock. Signed-off-by: Chengming Zhou --- mm/slab.h | 19 +++++++++++++++++++ mm/slub.c | 3 +++ 2 files changed, 22 insertions(+) diff --git a/mm/slab.h b/mm/slab.h index 8cd3294fedf5..50522b688cfb 100644 --- a/mm/slab.h +++ b/mm/slab.h @@ -193,6 +193,25 @@ static inline void __slab_clear_pfmemalloc(struct slab *slab) __folio_clear_active(slab_folio(slab)); } +/* + * Slub reuse PG_workingset bit to keep track of whether it's on + * the per-node partial list. + */ +static inline bool slab_test_node_partial(const struct slab *slab) +{ + return folio_test_workingset((struct folio *)slab_folio(slab)); +} + +static inline void slab_set_node_partial(struct slab *slab) +{ + __set_bit(PG_workingset, folio_flags(slab_folio(slab), 0)); +} + +static inline void slab_clear_node_partial(struct slab *slab) +{ + __clear_bit(PG_workingset, folio_flags(slab_folio(slab), 0)); +} + static inline void *slab_address(const struct slab *slab) { return folio_address(slab_folio(slab)); diff --git a/mm/slub.c b/mm/slub.c index 63d281dfacdb..3fad4edca34b 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2127,6 +2127,7 @@ __add_partial(struct kmem_cache_node *n, struct slab *slab, int tail) list_add_tail(&slab->slab_list, &n->partial); else list_add(&slab->slab_list, &n->partial); + slab_set_node_partial(slab); } static inline void add_partial(struct kmem_cache_node *n, @@ -2141,6 +2142,7 @@ static inline void remove_partial(struct kmem_cache_node *n, { lockdep_assert_held(&n->list_lock); list_del(&slab->slab_list); + slab_clear_node_partial(slab); n->nr_partial--; } @@ -4831,6 +4833,7 @@ static int __kmem_cache_do_shrink(struct kmem_cache *s) if (free == slab->objects) { list_move(&slab->slab_list, &discard); + slab_clear_node_partial(slab); n->nr_partial--; dec_slabs_node(s, node, slab->objects); } else if (free <= SHRINK_PROMOTE_MAX) -- 2.40.1