From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBAF4C07545 for ; Tue, 24 Oct 2023 09:34:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 619EF6B01FC; Tue, 24 Oct 2023 05:34:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A1B16B01FE; Tue, 24 Oct 2023 05:34:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 491486B01FF; Tue, 24 Oct 2023 05:34:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 339026B01FC for ; Tue, 24 Oct 2023 05:34:03 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0314A1A0511 for ; Tue, 24 Oct 2023 09:34:02 +0000 (UTC) X-FDA: 81379843566.16.DCC66FA Received: from out-194.mta0.migadu.com (out-194.mta0.migadu.com [91.218.175.194]) by imf09.hostedemail.com (Postfix) with ESMTP id 3C612140005 for ; Tue, 24 Oct 2023 09:34:00 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XdLQFwKj; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf09.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.194 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698140041; a=rsa-sha256; cv=none; b=VjG2yt4S8KOUdIttqwKqj7IM2Q0a+/ipj4Ad3xM8G3iAg49pORFqweMvbw3idBYB3LSvJ6 HO4O5WJ74zG3EqZqBwizJKcO6n+1Sj+sbsLXukzSqTBYrM9iZtzspksKbjNSaxZ88ak6pQ w6XF/bXonc5Zfdw5M11zp+LLLtNmSok= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XdLQFwKj; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf09.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.194 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698140041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h11SacZ+d1SZT9G0QAPU/rLkN5EaAt8R9Llcg4aahcg=; b=Da9tZGNFoTSN5qcQrezgtWfL08Vwn0Xu+mpFBATyuWlzsjFXlpRBZ9O29Gcf7oZBmgq48v /aEjZ3DgQsWdfRRMoh6PresgnqSU4nh5sa9TkymkwY5aVPK8yo6/oNpl5fiWr8nPmLRYs3 b6z+5fpRzV9vZI6W7zy6QleLv19/Scw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698140039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h11SacZ+d1SZT9G0QAPU/rLkN5EaAt8R9Llcg4aahcg=; b=XdLQFwKjBt2izoxJqBOj93psrMaXNRty4xClGHCDT9p4T6juuhYWB/eoSnFrU+EPl/QvmP 6gAcQ3g4yVWbXa8UyMXIbOBPExVeP2TXXqyMEawXzbGshHntMsONmYh2xHZQ0ydgsgepOq WH5zAaZdRSTxxEDvvW3W5dkYKS7D57s= From: chengming.zhou@linux.dev To: cl@linux.com, penberg@kernel.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, chengming.zhou@linux.dev, Chengming Zhou Subject: [RFC PATCH v3 2/7] slub: Prepare __slab_free() for unfrozen partial slab out of node partial list Date: Tue, 24 Oct 2023 09:33:40 +0000 Message-Id: <20231024093345.3676493-3-chengming.zhou@linux.dev> In-Reply-To: <20231024093345.3676493-1-chengming.zhou@linux.dev> References: <20231024093345.3676493-1-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3C612140005 X-Stat-Signature: jgwbk94ekywyctj5qz77kgreaye6ih4h X-HE-Tag: 1698140040-6004 X-HE-Meta: U2FsdGVkX1/J+txJv9YkC0r61xbezqYLlBfAHCRr3iD7DdI/vuR0S3pi/YMXBPi2lUHv3nW+WFp8vaCrWQPkTpQ08ue+C9Rm8Pv4cq9I1ssVROzvhwLXx51G5Ue3SLZgWOVFyJo9ZITq39vUNE67rPTAgHlD1L7ERxjR02BHLPzkv27erCLdKgk3Veqpgsc2mVEqK3RHY25Hk46i1YkHN2oBtJ4v4/Rse72VoPCQEEeLtDpsAS+p02OeS2l4PhJTHkf7ycp5B2x09VSoFbS/fIwzXkaaqPcEBa+e5RrZ3DlfBA8R5hnK/jawegRvFmx4J50I0qVylm7ID7b+GSjF2GVH28vf729kvyGTCcj0Yv/efFuCOBhVGbKSrGUxZzfuGZGPjkPQRARN72UIuFoRWZhYLqYB0NQdq2pkSiYlsg6qtr4ViuBYsl9PJ/zsm6t+OCXJlEA7JKcQ3Ae4qKismBwLr3L1+lETO1Jseoa28+ae4l0kxbPbDNd+R4j3GA4V3RBtbUfZCDLKOMzP8IUWULTfGLZdUVUavkVl8KPntHVlaCb0WuwTv0BibxtjRiWcVwbrHG9xBlLzsRSdAKAomlkn/Zl9RsiF+FWTwSoDEcigQbk8JBTdPAOM9TcB3LKi2YSu7OIrD/CdLpnyw8wBW6aG0nyCc5p7onJtJZEVc06APVjL9amcwJ40PhvHpa3omVve34HEcyHhYQ19Uz5/Na2+1k3yvijFCdFYldvYKR/7dBd8lIPUjQyazsnNhzwtMGwjIsFECp4PPpUy1DAb9H8bWlUVSk7GMslXIRYy3V2x/r2mO4OyRakMM83hr+OdA7+Ko8VTisjPUnMgA1K8Fbe85Wy2MoCg89bRU7qwDy0aJBca7fu0D4xxTo8eGaHg9u5lVuzjNCODIs6sEhBl0UJ37zkqm7XkyNR1z22hyXQRry+YsWOK6L/Kmvgcx6msSIZApnBGlf3jHaToU5r LLlE+rz/ 8VnLI/M75JhaX2F/tJUVC8mqAc6zYKUIAYDfaEqUJCzqDfs2UkAVDZiZjSNIVOe13sQP0e/RqYTBSFVLAfn7koIWXqV0ZfgZle8lgAVVaDppb6btKcTUlW2yZIJ1csgWvj/f60cvJu4qY0aLgwonqb2E2ggVTXiPfSZ41YAyaIOTDM+9u+nIB+IxOIQrhdqLL+zH159DF5ARdTmDeLdJOh5CRvklKx9xk7jE6B3Hpgri71SbxZcGruawFw46knjynBObo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Chengming Zhou Now the partial slub will be frozen when taken out of node partial list, so the __slab_free() will know from "was_frozen" that the partial slab is not on node partial list and is used by one kmem_cache_cpu. But we will change this, make partial slabs leave the node partial list with unfrozen state, so we need to change __slab_free() to use the new slab_test_node_partial() we just introduced. Signed-off-by: Chengming Zhou --- mm/slub.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/mm/slub.c b/mm/slub.c index 3fad4edca34b..f568a32d7332 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -3610,6 +3610,7 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, unsigned long counters; struct kmem_cache_node *n = NULL; unsigned long flags; + bool on_node_partial; stat(s, FREE_SLOWPATH); @@ -3657,6 +3658,7 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, */ spin_lock_irqsave(&n->list_lock, flags); + on_node_partial = slab_test_node_partial(slab); } } @@ -3685,6 +3687,15 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, return; } + /* + * This slab was partial but not on the per-node partial list, + * in which case we shouldn't manipulate its list, just return. + */ + if (prior && !on_node_partial) { + spin_unlock_irqrestore(&n->list_lock, flags); + return; + } + if (unlikely(!new.inuse && n->nr_partial >= s->min_partial)) goto slab_empty; -- 2.40.1