From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60CC1C25B48 for ; Thu, 26 Oct 2023 16:51:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C975E6B0365; Thu, 26 Oct 2023 12:51:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C47436B0367; Thu, 26 Oct 2023 12:51:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B101A6B0368; Thu, 26 Oct 2023 12:51:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A2B256B0365 for ; Thu, 26 Oct 2023 12:51:37 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7159C40524 for ; Thu, 26 Oct 2023 16:51:37 +0000 (UTC) X-FDA: 81388203834.19.C093DF8 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by imf30.hostedemail.com (Postfix) with ESMTP id 33AB48000F for ; Thu, 26 Oct 2023 16:51:33 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lBAU14g3; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698339094; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=VIpvhowBO7WsX9szrh2/6Q4e0Q2xay1O/j40o3l+i+U=; b=Xl9sMo/7sdK/N3vQhJLoSjd4fD7Qk/6bQz+HbIw42B7WBBrVznMAd9/pqIBGSFXKhPDAFa 9wA3pqaSUAwjmobdfXs5m95WF+yVH6/WAkwLd1VZafWIza5pQzcv+ECcqG21WlwcVzCOAJ y6aHi1t4rVenHGoFSATJdw9WaSI/EfQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lBAU14g3; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698339094; a=rsa-sha256; cv=none; b=w7t0v8IrFADNPzKBpS54Iuzq7nnzsCUg4Z1FcU3cvBDETUqyy75EYC46ieui8bpNo+RmQM zURqIXF6E89xi4vMpxyk0+8EuAx9Vs3BIncKlCTZc85TVgA18v4iu2Yffg043q0YBjF2RR P7E7IN6bLrGp8k/MGPyObaaQmXxHgUA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698339094; x=1729875094; h=date:from:to:cc:subject:message-id:mime-version; bh=nlBSiFuZgVAjpzI9thL7DgKBdPYnumDJoGIOv4i+UeA=; b=lBAU14g3+EXy7pu/rEuZ4RfwsexQNaaEKFYX6jiWmxMEcFKOq5ycnk3A qSo6CrLxV6Rewu+FPaXPa9cmS/iY3A8KHFahM8B/I+9YK2oEawCq9mD7G kYYIboj5BBk+B7t3WZxxCNGDxqQ40+WmgtlUmGqzsjSj5qZu2JpoWJKGc qe0cQIOEvYlHQ3CwRGphfy6fQhPU4DH2eFYoyC49UqcFjYJLN3TNCoh0t 3Cf30dKd6BKy5QeS12TeJ8mHZFrJF9BV6VB1yL2EzdGrG30M6/NYgOcgb uG7y5G5pY1BGwRgVDq7LZM5COw0ezj6j0hscBkNps0vDujnOC7Lo/duM6 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="386481970" X-IronPort-AV: E=Sophos;i="6.03,254,1694761200"; d="scan'208";a="386481970" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 09:51:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="882895259" X-IronPort-AV: E=Sophos;i="6.03,254,1694761200"; d="scan'208";a="882895259" Received: from lkp-server01.sh.intel.com (HELO 8917679a5d3e) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 26 Oct 2023 09:51:30 -0700 Received: from kbuild by 8917679a5d3e with local (Exim 4.96) (envelope-from ) id 1qw3Zw-0009xe-1x; Thu, 26 Oct 2023 16:51:28 +0000 Date: Fri, 27 Oct 2023 00:51:23 +0800 From: kernel test robot To: D Scott Phillips Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Bjorn Helgaas Subject: [linux-next:master 14769/15220] drivers/pci/hotplug/acpiphp_ampere_altra.c:63:75: warning: suggest parentheses around arithmetic in operand of '|' Message-ID: <202310270037.19V5rqDL-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 33AB48000F X-Stat-Signature: xcaay46exhx3o78cr1nmbeh1g8u9afhj X-HE-Tag: 1698339093-986278 X-HE-Meta: U2FsdGVkX1/rx2CH5ALqKP9K4k4WPj+7GBR0xGYG+oz8huPDCWLgXXA14bCYwLvGUlBp15ffc5kY3NByux5lJcS0xpG0sPuAJD9vGeQF9GgkGX0tCyuPFvPv7jXrkCXpzAbiQbXV53pntRqrxT4M34d7N9Q3HRa2hAiguSLcFA9okhVeafcfQWuQFCzcy2u1AVEc+88sV2Zzhbjv+6gdYm7EKiZ9tb+djkQ8x+TWNBr6MNsBp3p5aHRrZM/Q8cequqNwkb65S9BKwqmbWLsIz2nAzhMmZ8OjkQSLb1dI13+l86P/zCDVN+/EvWwsTZk1TFeMWt//PDNFw4QhlsLQ08VRm8ThewedgPSOhPVuqdB8rsq7T2McP32nmrtAkDrqtFH4iSqK7qPlS0rTHdbZAb2+zHg3MPNuSYvZ15Sx79c6KbM9ii26pgV6/mQ3hKxPCdYUDEpkN0t8nTKk4DWyLzSwrWfQjvkZ3XkW4Mzq9S0yWiJ8DigW2b2gsdbOeCD3JARv7Mj+peTB2CheNQ7GzvfPtCt3K+9/QCZTB6OhywWQ/RjZLfkmXdBrVFCBGoKF/ySirOwCAc2U82Urm+fthsp6Nszd9udCW4sUW+pRqw7uI/ChT5iF156L1EsONeR2zog0gj1JoMAP6fW/7Kdbryiy3nFS8wmVjCwUhFwWYLgf60cb2Y2gmE0AptUP7gvxHl0BYyoeJX7LigVhyePK99afICJ8VxXoO4zhjyyx6f/52/hOnnL/nu/XmLR2TnJea5xLQodxA3IrP4WMt9jJYVvTvUavu/g2WCrn6yv1OgumzBn6KygR/9R4K+IkEdYNaLlrUVnvJEQbXpfBMKuvwggFcdGfOniahLxME4R2TjpSAstR1fjDbxp+Dq27vv7cMEUVFrslkDwWvk65CfyINttsVnugDi8dcbEP2rL9a31ySH8qP//qE3fkzgnFDhhuS1WJr32TIO7gYy0p9e+ R8MlfSop zJmkQXKknkRvGuF+dLSrOWBD9ghw2obOydtWUPC3L9u/ve7esPhlJrR5xehrgPma7f+Fm2oTkNDcM4wuu+7KXiiVRIY7RcsJGtfZpaVb86ND01G0NPcWOr/17P1FUGY3b44GD72qj2o2l8bOkd/AOvdHwigDk2ummsoESJWkd+vPNxg68NYfjJCN29wL0eKbRo7AVb3i0J8gv/b+p85zwUlTUD4Lt/mg20UYXJpu1tFVrXbTKGQHIuEP7blFMtWcZ59SwQK3SmrxnOg4J7qd7tI+zokvlbkuBqgiPmGO5N1gR6Ts+JmncWQzRy1M3K6etUEaICEXS6hI9aGfDM3pYfFeAE4KTEaJeqQpT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 2ef7141596eed0b4b45ef18b3626f428a6b0a822 commit: 13ba8a09c4f6fd87b4919ed2dc5e0dbf27c3de7e [14769/15220] PCI: hotplug: Add Ampere Altra Attention Indicator extension driver config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20231027/202310270037.19V5rqDL-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231027/202310270037.19V5rqDL-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310270037.19V5rqDL-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from include/linux/psci.h:10, from arch/arm64/include/asm/acpi.h:14, from include/acpi/acpi_io.h:7, from include/linux/acpi.h:37, from include/linux/pci_hotplug.h:92, from drivers/pci/hotplug/acpiphp_ampere_altra.c:14: drivers/pci/hotplug/acpiphp_ampere_altra.c: In function 'set_attention_status': >> drivers/pci/hotplug/acpiphp_ampere_altra.c:63:75: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 63 | PCI_SLOT(root_port->devfn) << 4 | pci_domain_nr(bus) & 0xf, | ~~~~~~~~~~~~~~~~~~~^~~~~ include/linux/arm-smccc.h:380:44: note: in definition of macro 'arm_smccc_smc' 380 | #define arm_smccc_smc(...) __arm_smccc_smc(__VA_ARGS__, NULL) | ^~~~~~~~~~~ vim +63 drivers/pci/hotplug/acpiphp_ampere_altra.c 38 39 static int set_attention_status(struct hotplug_slot *slot, u8 status) 40 { 41 struct arm_smccc_res res; 42 struct pci_bus *bus; 43 struct pci_dev *root_port; 44 unsigned long flags; 45 u32 handle; 46 int ret = 0; 47 48 bus = slot->pci_slot->bus; 49 root_port = pcie_find_root_port(bus->self); 50 if (!root_port) 51 return -ENODEV; 52 53 local_irq_save(flags); 54 arm_smccc_smc(HANDLE_OPEN, led_service_id[0], led_service_id[1], 55 led_service_id[2], led_service_id[3], 0, 0, 0, &res); 56 if (res.a0) { 57 ret = -ENODEV; 58 goto out; 59 } 60 handle = res.a1 & 0xffff0000; 61 62 arm_smccc_smc(REQUEST, LED_CMD, led_status(status), LED_ATTENTION, > 63 PCI_SLOT(root_port->devfn) << 4 | pci_domain_nr(bus) & 0xf, 64 0, 0, handle, &res); 65 if (res.a0) 66 ret = -ENODEV; 67 68 arm_smccc_smc(HANDLE_CLOSE, handle, 0, 0, 0, 0, 0, 0, &res); 69 70 out: 71 local_irq_restore(flags); 72 return ret; 73 } 74 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki