From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6634AC4332F for ; Mon, 30 Oct 2023 07:01:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A11726B017C; Mon, 30 Oct 2023 03:01:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C0426B0183; Mon, 30 Oct 2023 03:01:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 888BE6B0184; Mon, 30 Oct 2023 03:01:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 77CE46B017C for ; Mon, 30 Oct 2023 03:01:22 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 508AA1604A1 for ; Mon, 30 Oct 2023 07:01:22 +0000 (UTC) X-FDA: 81401231604.07.6DC75BC Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id F37484001C for ; Mon, 30 Oct 2023 07:01:19 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fyer+0uy; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698649280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e3bej7js+WiYJ2IL037kP9HpP1iK20/8aPzEtMXCGeI=; b=Gf+Gdl8lcMIk20kvZ/kWTL0pHN5zgCqmcj4mwf95esVagEN2I89p4aPE1vya5avvI+p1rU rWTeFhr+rgAGazK/4AO7021W9YrpivotqwaX1h0G01tpIsaNLHhmf41N7HwaRvotoXWSCE saxJoMW2CDzbK9VnKGJWNMg5TY7sxWo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698649280; a=rsa-sha256; cv=none; b=ys4416Ln8XK3rOV9A2yifS2lN0RY5aXhdRH6MkaqcLKQGtjCzmVbLQG5il34xmz/nPKc7P Zkg0ttt0GuE0FN7Eak8/VHWWm5XUg2A0nNmAOkfxHNfIOTRyGr+3S4RF1xHxa/FFS3FZJz 7oAwDJXzAreVl0+gofx4KZmhCXNyMqg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fyer+0uy; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E4CE8CE12E4; Mon, 30 Oct 2023 07:01:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30B1CC433C7; Mon, 30 Oct 2023 07:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698649274; bh=EmJn7V2xcCxlebppxaDAhU12OFutDZWRBy0vMaSrWuA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fyer+0uyv1jhu2jxdwK+n1O2/sIgGI7ezOwxQC871hHJ3Cd/JKl9lBlO3pXltUpO2 tybWUbFkw8nG3yYnKj5NWsk/KsMeh5cYt2Zf06cFoE4cK0SwwSOQ0meQsCZJmwrLES ZjfIwnoeXu/25/54cCJrG0ThSOL/VsSYVOr1W/9QTaMgDvrgblTvcHPZrDSbxEy8fw AT95UrDI+b348FRlIe6JpCkizTZtGaE3kNe+nAOZWv5ZyGWJevSARlVxf0OsNjI/Uk BM7kNTKVl9T3dS3d/hE9ctd5XEbBUeRh4TuIA6DuyqF/4ni+SgBncpCAAQy/vXTAcB 87xr+yc2RIXWg== Date: Mon, 30 Oct 2023 09:00:53 +0200 From: Mike Rapoport To: Will Deacon Cc: linux-kernel@vger.kernel.org, Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 04/13] mm/execmem, arch: convert remaining overrides of module_alloc to execmem Message-ID: <20231030070053.GL2824@kernel.org> References: <20230918072955.2507221-1-rppt@kernel.org> <20230918072955.2507221-5-rppt@kernel.org> <20231023171420.GA4041@willie-the-truck> <20231026085800.GK2824@kernel.org> <20231026102438.GA6924@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231026102438.GA6924@willie-the-truck> X-Rspamd-Queue-Id: F37484001C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: g7po8rnspdgd83ct3o9nbp85cg57qhwq X-HE-Tag: 1698649279-230765 X-HE-Meta: U2FsdGVkX1+3fxNPUHGRIoBVqMLm+cAQ0QmaT4MlJpI/PsExgTiIIfZWDGALQQ7I17H9oL9N+Ks5vyhzgcHvrhOfY1Z3xNOwkvta9mSyC7nx4NEdqCGNJ5XgzJhVdGfhVUPLZ5DGjlmfUbtlA1euljYqVq/n7fgNgOFyPfA5m0FziIl1M2fR6HMtLLmEdtygOBrDZu2IgEakoRhd9ofHayW1NKik6Min6Br3LANY/L4z9i0ClOy+dJK5YS88NFnG1VqRXdpNrbACi6hwKGS/Am4zk6eSyFd7C2bOiMbIiV+0a8TZpPSvs7JYdDvGq0rmYaX8pyEMYHSqhWmCS7kfy3spQOMkiXPN1GzOvD9fjCiJE04bX9mF1kdC/lOoiIyQXhsuTqBlR371QYSV6p65f4CzYjXBIflOSJU6uGZMSGsDrHY+rW7yhAGd/YfVKtwR2ZS0+BKEkKclgFsQg7CuMZ6Jv+pQblcQ1tJg6ROodHDnLdhZCNWerCkkrAOA0q0gVZjpNgyLIVSySvEw+VqEQSI4JOjcpQZ5XSOk0bpbpF6HBlhVHzDtUFzu0/cOLpiEKb+JeJswQY69ZzQpOxQODwp7egNUv+A8puQSoc3M0SpzpNbWAw59/v7O2T6F/mIen+f4leVJL5phGyEuJsF4y9WSvFfCEgwKY+HMlnoEBPdHXCRSjck2kWDjMPf4Qm4+YmhkKPWXOxFKXMkT8Myeg8pnnBP15AXpNk7dBw1mbCQfAtQ8oe8eaonMn/iysX2JQdBejGbwxYqlmMYV0bQjlQMs2IQinLj8bGUHRSDIJ7YqWIQMdpORbVrN2GjrbAlM4xqje4qt2hgWt6ZwNOdNqIaKj6si9nUVL2/kGqD41x6UdNXkQHx7WIKMpPtoCBOI8wf77QH/gLtpom98uepnVja2Y4vkL6wcVTy8USyL0J0d724oYLjbUBNJp5FIuE18HCeAydJPUCeTyNSt5g8 Y6tfl39K 4Qywcw9UbL7Lba/jann0JZ+HT4ceskNCAeBuI762eJGyOUoELpqa/ibhRTFp9zfRjaXe3zpS5PdEvxAOkwD6KT0zxrAQV6tOdZpFtL3BIWscMgH/JAuIZDZQj45XtxszMqf/pzbbGvQ25euY9522K/AjWH4qPhYtE1+Gkd/18jVhzkugC4p8rp4xRsfBt7MD3qpBKQnY/wu3aJMtm3INiydfAiK7r4CwZFVMF4eAw9YxBguHnmfUDLDt5QZedDe6n7meWgDNjjjy4nj0bG6t73LmwWtDKPe3UQWMYLmfkGhlgRHYCgic7rpycdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 26, 2023 at 11:24:39AM +0100, Will Deacon wrote: > On Thu, Oct 26, 2023 at 11:58:00AM +0300, Mike Rapoport wrote: > > On Mon, Oct 23, 2023 at 06:14:20PM +0100, Will Deacon wrote: > > > On Mon, Sep 18, 2023 at 10:29:46AM +0300, Mike Rapoport wrote: > > > > diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c > > > > index dd851297596e..cd6320de1c54 100644 > > > > --- a/arch/arm64/kernel/module.c > > > > +++ b/arch/arm64/kernel/module.c ... > > > > - if (module_direct_base) { > > > > - p = __vmalloc_node_range(size, MODULE_ALIGN, > > > > - module_direct_base, > > > > - module_direct_base + SZ_128M, > > > > - GFP_KERNEL | __GFP_NOWARN, > > > > - PAGE_KERNEL, 0, NUMA_NO_NODE, > > > > - __builtin_return_address(0)); > > > > - } > > > > + module_init_limits(); > > > > > > Hmm, this used to be run from subsys_initcall(), but now you're running > > > it _really_ early, before random_init(), so randomization of the module > > > space is no longer going to be very random if we don't have early entropy > > > from the firmware or the CPU, which is likely to be the case on most SoCs. > > > > Well, it will be as random as KASLR. Won't that be enough? > > I don't think that's true -- we have the 'kaslr-seed' property for KASLR, > but I'm not seeing anything like that for the module randomisation and I > also don't see why we need to set these limits so early. x86 needs execmem initialized before ftrace_init() so I thought it would be best to setup execmem along with most of MM in mm_core_init(). I'll move execmem initialization for !x86 to a later point, say core_initcall. > Will -- Sincerely yours, Mike.