From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E36A7C4332F for ; Thu, 2 Nov 2023 03:24:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 772188E0019; Wed, 1 Nov 2023 23:24:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F98D8E0009; Wed, 1 Nov 2023 23:24:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 573D08E0019; Wed, 1 Nov 2023 23:24:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 41A468E0009 for ; Wed, 1 Nov 2023 23:24:56 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1F73840DEA for ; Thu, 2 Nov 2023 03:24:56 +0000 (UTC) X-FDA: 81411572592.10.ED14053 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) by imf10.hostedemail.com (Postfix) with ESMTP id 625F3C0005 for ; Thu, 2 Nov 2023 03:24:54 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BPwts8cC; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698895494; a=rsa-sha256; cv=none; b=Ab9Y4A0mrRhJxzNx4JmEhDB1qn2+/gAgpxHk+z9X6XXWcVJbx7ETkjdhyXvAvIizcwJ/SF PhUXTo4vw17z7JEyvoFGa7xN2v4bkxSM9aKBn/DYRxwaFo2CvxfztyyksI7IlRgDPKVaXQ 1/s0C158C/zOpLOA67ri43Qd3cbzsyE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BPwts8cC; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698895494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f6Me2hDPNAg0QwflvoQbBjNc8QPP2obW8dtDV2OvsdM=; b=e120VBwrKy/QiFhe7Lzvp0J5wHnB14Yni7fR3fX/NebjQoZzpVVxYsNA+8lQ0zr6MpNgDE HrmoNG0mtX+L80PZjvA1ItsEZmcl0TO8IwiWusV9/rqw6hxY6MeVZVqZCDm1AXtDTd2YV4 JsZFnXuToOIIfAa/epnNuwPVcAaigKc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698895493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f6Me2hDPNAg0QwflvoQbBjNc8QPP2obW8dtDV2OvsdM=; b=BPwts8cCYtipUTdyFWricBp8OGyxnWzOEVZlgGagJ9J46S70yP6mdX0Zikc3F0F2DBJvXT /yMeu2ntPNaXcbiqN3TobVLGvOh9MDaYMJyNpEP8dSexDMJlp27RoUaeceT+iumgN10Z/7 Sn3Ry4EaMJKSfkAaTC3ksH7jqeLcYEc= From: chengming.zhou@linux.dev To: vbabka@suse.cz, cl@linux.com, penberg@kernel.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, chengming.zhou@linux.dev, Chengming Zhou Subject: [PATCH v5 4/9] slub: Prepare __slab_free() for unfrozen partial slab out of node partial list Date: Thu, 2 Nov 2023 03:23:25 +0000 Message-Id: <20231102032330.1036151-5-chengming.zhou@linux.dev> In-Reply-To: <20231102032330.1036151-1-chengming.zhou@linux.dev> References: <20231102032330.1036151-1-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 625F3C0005 X-Stat-Signature: 9f5idmmih4q6cawyzexujopmnxjtabsz X-HE-Tag: 1698895494-616696 X-HE-Meta: U2FsdGVkX183eXK0HCLJpJ+9iiWG20eqGchN88U/Du40688IAmX3Z7yKeQirKxJPqR6qRxQVliEfIWtEZQCqYwC/VQT6shfO9Qg7fMQmlPsBtrZ3p/NMZnd60JViCqr4Jyi6pReoqMPbhFXFsFXGm+p6Zbqvm+/+kp4XHrahc0aNf7A87aSX206O6SFIR+SYvij0bNkE2Q5msvOX9HhRDuWrwosx8vrzkLqN0R6U1eQudUz2QoBvZxpfRrsiiFCvKEPPjVUon7zN9E/MvzlzEF+fwDnKBflDfv6UvKn2ZpXjSDHq6QEzXgTq34Bzn8x1Hs9S82JoY94sS3zSthAJ0ey8EJ3v91X39qLsBibp2GruLNZ7F0V5knOj5iU4T3VEFQczr5D8+ucxoRkbYVrJoB7CAxYon3KufMGS6fSd14TxhoiCOprS+q/mkHC+bgOF9qs4sSPzIVSB5Cex2AQPtvpy4MHdOpnP0nMHI8axBKhMcMmfBadQruqx5edPT34DkcXP3GrHkS+N4tPQe7EWbNwEhy7Aqc2KG6SsmUXqZUfCrA6LADm4cleifZEldu8GcqWAVdYVVrYyc0AY5E6aNwlpCetHicG9j/lZa67M0R/0fZdyYGolRMrsdJSwpEFBFRNPkjXWErWugup2bNav0tsagsBDe7dwWp+8S5BTfWzICnVEzmn6jrdeVe/S+GIlCsoxAWDcDgZTa8sUr8KSCh3HRm3HNUPLx97w8gTiieLwz6vvWjsHVbSIIqS+rTAIX77KS2/XYrdJ/xetdz0RGpg3gKY1PlGWBy7c9Q97hrSzLH/eNoxspVfMBOL69bdb2CDFmcmdtfpJ5hWCnNJ3ucEBGQXaS/r60sfhbI/JqiMxmfmGCb2pfCjDYsBqmaoYZKiXWVMiC6CM4P2sueF1KKYkfiRpRlwY9WmgoTQy6AsQuEhiZWlmyWA+gjqnraIfRWbgNj45peKNq2cEgBR n3IgkzuM ztEWQtejJZpg7OAx5HmwdSiYlc5CiMrS3EZUvHd6e4vUcewZpESPkI8so2GQOOwFXHBpSUGpRo33ThcqVGmpcG8XFJ4WAsMIxxP/t3Y06qCsFaz7RpnK0RQqMwVp1d+4K+iQ0mn2O/r30dQNYUwz3dgNtqTKsYxNZ0w+qKqS/kG4BQv94E1OVp6PmTfWIc42MxOPxFWtCSKkvWFIMGhS5szVFOFpQEw2YYlwEZfyua0EN+3DLNwzLbFL6e8biJZki6fKHVk50bLUZhQldUCuIV826CA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Chengming Zhou Now the partially empty slub will be frozen when taken out of node partial list, so the __slab_free() will know from "was_frozen" that the partially empty slab is not on node partial list and is a cpu or cpu partial slab of some cpu. But we will change this, make partial slabs leave the node partial list with unfrozen state, so we need to change __slab_free() to use the new slab_test_node_partial() we just introduced. Signed-off-by: Chengming Zhou Reviewed-by: Vlastimil Babka Tested-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- mm/slub.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/mm/slub.c b/mm/slub.c index eed8ae0dbaf9..1880b483350e 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -3631,6 +3631,7 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, unsigned long counters; struct kmem_cache_node *n = NULL; unsigned long flags; + bool on_node_partial; stat(s, FREE_SLOWPATH); @@ -3678,6 +3679,7 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, */ spin_lock_irqsave(&n->list_lock, flags); + on_node_partial = slab_test_node_partial(slab); } } @@ -3706,6 +3708,15 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, return; } + /* + * This slab was partially empty but not on the per-node partial list, + * in which case we shouldn't manipulate its list, just return. + */ + if (prior && !on_node_partial) { + spin_unlock_irqrestore(&n->list_lock, flags); + return; + } + if (unlikely(!new.inuse && n->nr_partial >= s->min_partial)) goto slab_empty; -- 2.20.1