From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5770DC4332F for ; Thu, 2 Nov 2023 04:03:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC1FB8D0074; Thu, 2 Nov 2023 00:03:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4ADD8D0026; Thu, 2 Nov 2023 00:03:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C7398D0074; Thu, 2 Nov 2023 00:03:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 749868D0026 for ; Thu, 2 Nov 2023 00:03:26 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4AD091A0E4C for ; Thu, 2 Nov 2023 04:03:26 +0000 (UTC) X-FDA: 81411669612.21.507A48E Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by imf30.hostedemail.com (Postfix) with ESMTP id 6FB0280002 for ; Thu, 2 Nov 2023 04:03:23 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="f/zylQUb"; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698897804; a=rsa-sha256; cv=none; b=0k5xylzd8ZxyaydC3pf3j1UjbcwVfPa3/I6uRUTaTt2TFgHJZnU/2bWoefn1i4e9shpWwv PIKlzL2Q0k6BWDzbeYa1Je0a6WH1An8xEeTlEcRjNAdxpwq9CkeyQMVDCZ0g/LQM9Ad8FF 3sObhb8dsfwa0yV8bMKJqBdFyVrBxZk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="f/zylQUb"; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698897804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+f1gZoTa3Iz2Aa/NZNXx9gSkWu07ZzoRSIp5UXEoexk=; b=UoUyft9p8hRqHMVG8Fm6jofIF/VMLBa8DYmmEYNJE/E+CprSDiGiis5B1RNt8vxGkFCdQR 3ZvumkUYt8eCJvZElDzdfXB9N1ggD4Gc0HHKi8axy2bK40G4pckMrSa7pvLMj4GFkfeXG8 hu2nG0QrFE4ww882dy5EYvhYD04+6Ew= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698897803; x=1730433803; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZAhTTJPnwNh7IED7EgXf3uaooCsbRednT45HuNxBBu4=; b=f/zylQUb/RpMwyplDCHiKz1QeESCH2Y2BNl150UOspdBYxGJUh4dTkQ1 KaiLPBj9ihwrK3YpAMv7UGcS1ReHPwvb68Q+NxpGZdV9NREM5050kCmiV q2v4ZGdLsAhnSrSFsL2hCNf5sJ8tA36Xxreanv4cJZChniA39WyZft0P4 OXQzicLImwR6b+g6DdwjdFNWUAY/urT9eaE6LYXq0xFNNt+aK40EuCqQH 4dcNxP9wpjaxSbbUcBJFb4FMm1sjE4EhXmOpQHLGcb4oLfUnXndmh1gxD TkulK5zsiUKVj7VcPlO2QaHn8viXwIwFT+/pNua14SkBuS2cm51haMf+8 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="388448256" X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="388448256" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 21:03:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="851785059" X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="851785059" Received: from lkp-server01.sh.intel.com (HELO 17d9e85e5079) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 01 Nov 2023 21:03:17 -0700 Received: from kbuild by 17d9e85e5079 with local (Exim 4.96) (envelope-from ) id 1qyOvK-000166-2h; Thu, 02 Nov 2023 04:03:14 +0000 Date: Thu, 2 Nov 2023 12:03:06 +0800 From: kernel test robot To: Dmitry Rokosov , rostedt@goodmis.org, mhiramat@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, akpm@linux-foundation.org Cc: oe-kbuild-all@lists.linux.dev, kernel@sberdevices.ru, rockosov@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Dmitry Rokosov Subject: Re: [PATCH v1 2/2] mm: memcg: introduce new event to trace shrink_memcg Message-ID: <202311021126.DNKIAcbq-lkp@intel.com> References: <20231101102837.25205-3-ddrokosov@salutedevices.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231101102837.25205-3-ddrokosov@salutedevices.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6FB0280002 X-Stat-Signature: ttnreqfzb8j8qw1oc5dotbfnxiodrezx X-Rspam-User: X-HE-Tag: 1698897803-387635 X-HE-Meta: U2FsdGVkX18Wbapu/X7o1ynGk604WYtuaWgHQNp+EX703Et3kRID6gNdhLjEysKfqnrENUB3orfb5Rw51SoopEO8hUKIAC5SLVpSHnpzhLTdFYcjzk1HTg4m0swTs/8WZD4xgdTpn5AwZ81tFZQVCgPDH+P0xdUV41vl6g5NZFNvQe4LwPnfMmCF8egLpfdAsT0MTCK7e0u8boR+WV4pqHjx8LQe4IEDU0MINlszi6jhQE7hBL+5Gwqx25hGSsEkOZMHUCtk82FMncG4k/dPM+m+Q6cpy+RenZXJLHVCT8gz8V9EPJ4lgLYTyLww3Chq+l7hgsqhpurQfFoc3y4SyygRAu1QKCOA9vaINXBiGx0o0CSbvbPARarYCqe4HtnpTjojN3yMMcArrKmP/Lto0+NkMYV+OXuVXJdlQgWJy/K9tEKl/n0UGEjgmZ7f75ZiUcDKPB60H44AcdhJyAgZIXm4Epe3rUV4GB/gsa60/0bYIXogOJVS8V50GGEY4GpDwq3kvCx1FUsywlJMKnQACoD6CxLCHITUlpsJUbZiWUeUu5Cbq68HLSzABFnX+h7wQHDmt6A/DXcna0tp+WDH/j5iLJE7hxIxHoTRXdCXy94rVzK/DAlYLVlzWpv2iyWe/WnbbgAniBTcpwgC9RIl9JG8kJwf8GtYsBSLpOdDNiNtSs4Z5SfLu8aafliMCDg8IS1gcx4ndi6pnh6e1W9M2dEJkpHXCB6uTy682O6kufyeJnzo8wbZ2NwbDkanUv1tXleubS8ehilvqR2PV3KZPN3Zbrby3bY93LKSb/t1c+sktxKAYsvQgQ/WPVQqw3Cj2a5dKlVXa4/w8dK8rw6IruLGWCQXKwpXiIVSKnN7FE/eZSnRqjyuh94HqlFCz0LKtGIrRudn3Wski3Inf8OCGQHiSnsc/fVKcPJaFDQgwX61f4mUf+fX7uCGFvaDY8obhPYOfSI9ccmH/c+AU/M jm2X8j1S o746tB/ZzhlQBz2sL5+mdJ6wUfwvBB01ZNHKu1HHXEys2PMhHgcCpcGi7iXGiLKMiZHLi5jsc/5PgxOqKmA2fNAnDBabVF6tsFqzfAXsG1NYmR9krH7CCR5EKg7PyLGZjRH12ubRIppi7hD099JioNwNtSKIcvtnbVqvk18bFIKvy8lhLn21VmUKYxmnm25mvT1XbJfYNBcMHZNL9ZZeKXXosyUYMdqm3w7qJaKiBRHtD46gEM387ezJyFvJdJpsZWu9uWDlk47gF7DJn76OkBscTfdDp9NbEYplUI/Mo/3227mnRUS07qkt13SkF6zvK1hrDDTvzkQYU3bQWoJaz2jH6h0ZlONnl3OIANEjRnItxAVE1j9mJ/nTr18+PHhe4fd4Qx4ZuYhRlYFoG6y16KzBCZYcN63LIGzFA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Dmitry, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Rokosov/mm-memcg-print-out-cgroup-name-in-the-memcg-tracepoints/20231101-183040 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20231101102837.25205-3-ddrokosov%40salutedevices.com patch subject: [PATCH v1 2/2] mm: memcg: introduce new event to trace shrink_memcg config: sh-allnoconfig (https://download.01.org/0day-ci/archive/20231102/202311021126.DNKIAcbq-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231102/202311021126.DNKIAcbq-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311021126.DNKIAcbq-lkp@intel.com/ All errors (new ones prefixed by >>): mm/vmscan.c: In function 'shrink_node_memcgs': >> mm/vmscan.c:5811:17: error: implicit declaration of function 'trace_mm_vmscan_memcg_shrink_begin'; did you mean 'trace_mm_vmscan_lru_shrink_active'? [-Werror=implicit-function-declaration] 5811 | trace_mm_vmscan_memcg_shrink_begin(memcg, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | trace_mm_vmscan_lru_shrink_active mm/vmscan.c:5845:17: error: implicit declaration of function 'trace_mm_vmscan_memcg_shrink_end'; did you mean 'trace_mm_vmscan_lru_shrink_active'? [-Werror=implicit-function-declaration] 5845 | trace_mm_vmscan_memcg_shrink_end(memcg, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | trace_mm_vmscan_lru_shrink_active cc1: some warnings being treated as errors vim +5811 mm/vmscan.c 5791 5792 static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc) 5793 { 5794 struct mem_cgroup *target_memcg = sc->target_mem_cgroup; 5795 struct mem_cgroup *memcg; 5796 5797 memcg = mem_cgroup_iter(target_memcg, NULL, NULL); 5798 do { 5799 struct lruvec *lruvec = mem_cgroup_lruvec(memcg, pgdat); 5800 unsigned long reclaimed; 5801 unsigned long scanned; 5802 5803 /* 5804 * This loop can become CPU-bound when target memcgs 5805 * aren't eligible for reclaim - either because they 5806 * don't have any reclaimable pages, or because their 5807 * memory is explicitly protected. Avoid soft lockups. 5808 */ 5809 cond_resched(); 5810 > 5811 trace_mm_vmscan_memcg_shrink_begin(memcg, 5812 sc->order, 5813 sc->gfp_mask); 5814 5815 mem_cgroup_calculate_protection(target_memcg, memcg); 5816 5817 if (mem_cgroup_below_min(target_memcg, memcg)) { 5818 /* 5819 * Hard protection. 5820 * If there is no reclaimable memory, OOM. 5821 */ 5822 continue; 5823 } else if (mem_cgroup_below_low(target_memcg, memcg)) { 5824 /* 5825 * Soft protection. 5826 * Respect the protection only as long as 5827 * there is an unprotected supply 5828 * of reclaimable memory from other cgroups. 5829 */ 5830 if (!sc->memcg_low_reclaim) { 5831 sc->memcg_low_skipped = 1; 5832 continue; 5833 } 5834 memcg_memory_event(memcg, MEMCG_LOW); 5835 } 5836 5837 reclaimed = sc->nr_reclaimed; 5838 scanned = sc->nr_scanned; 5839 5840 shrink_lruvec(lruvec, sc); 5841 5842 shrink_slab(sc->gfp_mask, pgdat->node_id, memcg, 5843 sc->priority); 5844 5845 trace_mm_vmscan_memcg_shrink_end(memcg, 5846 sc->nr_reclaimed - reclaimed); 5847 5848 /* Record the group's reclaim efficiency */ 5849 if (!sc->proactive) 5850 vmpressure(sc->gfp_mask, memcg, false, 5851 sc->nr_scanned - scanned, 5852 sc->nr_reclaimed - reclaimed); 5853 5854 } while ((memcg = mem_cgroup_iter(target_memcg, memcg, NULL))); 5855 } 5856 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki