From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F220FC4332F for ; Fri, 3 Nov 2023 07:35:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 510CD280010; Fri, 3 Nov 2023 03:35:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C01D28000F; Fri, 3 Nov 2023 03:35:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AE64280010; Fri, 3 Nov 2023 03:35:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2C34628000F for ; Fri, 3 Nov 2023 03:35:15 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 07D12B5EA9 for ; Fri, 3 Nov 2023 07:35:15 +0000 (UTC) X-FDA: 81415832190.28.C94145C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 5605580002 for ; Fri, 3 Nov 2023 07:35:13 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MpQvfuD6; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698996913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c+HlHAujwXryt3cM+WgmhddL2hT01A0F+Sb2FRDQ5TQ=; b=ciSvkECturL54Pe3c1p3TZ7dJYqr0kWd3JChjAS/kqLiY9548AP1TZsR3kJ8fF8pvwuS/W L8pszPCZk4ADOCqkXuqoXKrJDWkl8RPtkuUh89FweQfTFkzuCK7BGVVSETlXuVyFjQ6cQ6 Pkzcl7U5Cey1DzEJoc1j6CtsQ2Mpy1E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698996913; a=rsa-sha256; cv=none; b=TTBMpOPfk4sBbxkFGRS3IcqRuhKXRmFCMId8Jt/WkTMgOPWUWEyHii1NA/qGk2zkeSuexu qkfW1YHyWClQkPCx9oL2a4ifNpTSvnQPt8oiZmQtnA1D1YcSDzVmiWIiY/3xZy8rfusRVW 7GObxjrOrv33iqGF5SC7IBpRS4pYTWE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MpQvfuD6; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 65EE961190; Fri, 3 Nov 2023 07:35:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0629CC433C8; Fri, 3 Nov 2023 07:35:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698996911; bh=OwYraiWkRGh713mFuBYUkMG66+APMALaM2UA9/OPM4Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MpQvfuD64rLyAZYkNj6bZGqNDUHXaBufxMYO7HTTllrrdXkiY5fSmEKrzDlJtpMJ+ TG1it3u/4YTXqyVqHba3o/03rXvIiokvctVSUrIGRSf96MBWBvF+msAvFoznrhdkGF E4mIRx3hAru3EaujSHaWm+Fk3A+OuzouKtd3TBn2vKqQ/9h0fZlBrYPNA4Kj97kpyT 0tLQlqje7tlZCTHJPaGtgN4CC0KJo6W8FncdU0Hwea2w1zGXrZdMOgpmx75YvKeUDD +EF+jkYlw+t0BI+zLRgcsjk+O3CmBcbwkWnShoG108n0UQ8VY+bgX71sYj61uTS737 lh1CSEprMLS2A== Date: Fri, 3 Nov 2023 09:34:59 +0200 From: Mike Rapoport To: =?utf-8?B?6buE5Lqu5Lqu?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Liangliang Huang Subject: Re: [PATCH] mm/memblock.c: using judgment statement can reduce loop and enhance readability. Message-ID: <20231103073459.GN2824@kernel.org> References: <20231102023710.13023-1-huanglllzu@gmail.com> <20231102085418.GM2824@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: ykq4s3qj5n69n1kb65xe6yj39w74oyic X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5605580002 X-Rspam-User: X-HE-Tag: 1698996913-170477 X-HE-Meta: U2FsdGVkX1+mIwxerP3aUq2JXYRR7msjVyJAMjj2IcYKq8btqcgI7cYv7ScnlqaD7L06X1guFRVsVhBvlHtC2HGNGhpbNHnqDFZc1OxjEVYme9sdPPgaN305+RhYLcxeDduuekfWh8VsqM3Sr0hTnD9Z4MHWKSvowlfM1CJ8NJa8bJvpGeIEwR/me9JU8Z66NWV5apWz4CKES1DJhUdCJ0eNeEfrgyIt4L7XMMO9LU0tv9Be/dAOBW/Qpr/VUGUtBcf87OPe40DCHW63THUVXoNv0JHE0fkoZnYMeFQhJF5xIGA9Orb0m9U50IIJUdKLD3r/Laua6rrfQAmvZXoyGoH7jL9mwh8jQnZ6C276QlgK9J2Uyvfd2hK7qzz7dipiW9l4pdt2mIViP3um0IZlIeJn6Xw4VXUwS8xY3nHQtYbDq4roefIAumbJnx2EsmQjcQowXCv/2i+G6bS8ZDZ1ueMb9dcgfpLr1f1C85gLFPuaD6rDcmWcWapFMSKHWpEa4MSxMRL+7P3PcTzDFbfG0Y+mgoTX/nTdlqb6yvNwWj+Cej6ipSJ7nEi0VmYiD+VZx3/1IdC/Bw1QjS1oPPQOMNAcFghA5dR2LeQPirlwnSNEUoBHzPYe1MwmPChWD1XpI3Z0yq7t0UTa3DxEG08IW/k9LBLehsEhqdmh6kEJq/Z08IfQLlf+om/M/U6nCVoEN/rqtuSLoyF5YzWVLYnfI7RJQn0LQEH+y8yEj+EJ9HCfBOzi/k80pc1eiRRU1WIac5gHHSAT5GGNGFLE+y6hYuh52zmAhw92IwZ321ni6MW1vx/mVJzubW1XhZ/fPzsekPxve6Nqo4gRTxzvUPGLdNcLN+zFm50hGwS0XEZafYWZKhNUUl7KZu9kcQfqWOEbHx5p/tR66wtdW55wYKCVCWaGj6vYYnYuE4ur7PKEz07ZQM4r0YM1GoSJTs8mFPx/OPkAv38RL1W+worgqaC MR2UE+ma /I273ruJnLCy1CIGSUdRe+LRTZrIqqDuYbhthWVPjm+gfrTlxvaP658DJPwf3c+yEU7pTDevZqpzuieSwWss9AvqgUe0QPJ0eUUvnkz8sD1BzkTprLz9RvQXbO4NueKSlRR5mRKL7qvbqKbhQFAS42OTvwFAiPkh5WMP63+i0/yTDBEkEG+v2t9J74BW/aSD2V4SYWf1qHjmLr19Wf2WBOG+A/LxhyN/NJBQ6fDskYac8AIfAYwdmjWDKH4OgwuHtRDrBQKqMM2iIfLkpyv6Su/mjIjPju2xZiayEXbWetVhF8cD5jwYTZ1VKTr0urOWrWg+N9Knp1jVPCqg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 03, 2023 at 01:30:21PM +0800, 黄亮亮 wrote: > Hi,this patch can less loop once in this situation: > base more than rbase and end less than rend. >                 base           end >     rbase-----|--------------|-------rend >       |            |                 |           | > --------------------------------------------------------> The loop won't be executed anyway because there's similar condition in the beginning of the loop. Next time when you reply to the kernel mailing lists, please don't top post and make sure your reply is text-only. And there is no need to send 4 badly formatted replies. > Mike Rapoport 于2023年11月2日周四 16:54写道： > > Hi, > > > Subject: [PATCH] mm/memblock.c: using judgment statement can reduce loop > and enhance readability. > > I disagree. > > On Thu, Nov 02, 2023 at 10:37:10AM +0800, huanglllzu@gmail.com wrote: > > From: Liangliang Huang > > > > Signed-off-by: Liangliang Huang > > --- > >  mm/memblock.c | 6 +++++- > >  1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/mm/memblock.c b/mm/memblock.c > > index 913b2520a9a0..e48dea7144bb 100644 > > --- a/mm/memblock.c > > +++ b/mm/memblock.c > > @@ -655,7 +655,11 @@ static int __init_memblock memblock_add_range(struct > memblock_type *type, > >                       } > >               } > >               /* area below @rend is dealt with, forget about it */ > > -             base = min(rend, end); > > +             if (end < rend) { > > +                     base = end; > > +                     break; > > +             } else > > +                     base = rend; > > min() is perfectly clear and there no change in number of iterations of the > loop. > > >       } > >  > >       /* insert the remaining portion */ > > -- > > 2.25.1 > > > > -- > Sincerely yours, > Mike. > -- Sincerely yours, Mike.