From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA4D3C4167D for ; Mon, 6 Nov 2023 16:52:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA9548D0027; Mon, 6 Nov 2023 11:52:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E59408D0002; Mon, 6 Nov 2023 11:52:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D476E8D0027; Mon, 6 Nov 2023 11:52:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C60718D0002 for ; Mon, 6 Nov 2023 11:52:11 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A40C51CAF9E for ; Mon, 6 Nov 2023 16:52:11 +0000 (UTC) X-FDA: 81428122062.14.15EEA70 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id EB230A000F for ; Mon, 6 Nov 2023 16:52:08 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=U7I1gDjK; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699289529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ly0YX4+u1t18nZSTxe7f06q8TGHO3tgUiLdgieVFAzI=; b=1AqFrQiikNeuJqq382CTNaG8dT0uRPMijXedXwO34ctLFON56ejxQL/JJG59fEVPzcAlsw zDz5fKxS+LNi2I0eZ4sQFHg+xszwpRwfWwVbDL5IH6p+1tjiULCdP8uMnBLey5vGj5RrIE CUiGPEb4Xr/T8gQLrFzzMuA7Bj8+0hQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=U7I1gDjK; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699289529; a=rsa-sha256; cv=none; b=Lggfb1BVcdpXEeJXxwWfJSDEreK23+v26vUM37ORQcCubNn42+F8BszmCSA2oNT+d/8uLT deiAMAiD9tNbdlgPILMAGysz2G5SIvywzVdw8ILOdz7RqFBZ6GdT8D1KUdEnFYJfpwlnUK gxODOar0HzdrcNn+3JU1JwRYE89J03k= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EDDF860DD7; Mon, 6 Nov 2023 16:52:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25238C433C8; Mon, 6 Nov 2023 16:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699289527; bh=GH4rizvfiL8Skfe2XSF+3TdIIrRGXQVKbVpTQfYNGF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U7I1gDjKT1fOKFyyxbggkwZSIm/KlVmyfYlhNV5MzLzR7TZd00U4Ex+OduMTGLFfm blvUK+tjCzaGVoQsJnsMmUGM6WzNFIkD6BEnHlweFjMAu2cki1m16cvp+t6iioHOVY KzSrZDADnV+wrI3H1+KK5G591fEH8Iy4gYrJ/KpHCtATkaJ9U01HxjVD6h1z0EfArX JaTeT9Sl2jYYFOgMdGl+umJfSWbiI/OnAjYVOWus8WSa+dqMNUhw+o5FM+VFC6CXEf SO885Y0XkOGB42S2RX97IGwqiVZC9fepj4f+DbHGlM0mWKWk9wdlcbq3XZfQnUgsHX hyXhXLjYKp2bw== From: SeongJae Park To: Dan Carpenter Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: eliminate potential uninitialized variable warning Date: Mon, 6 Nov 2023 16:52:05 +0000 Message-Id: <20231106165205.48264-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <18d2f41d-e442-4f73-89f1-50bf20cd85f2@kadam.mountain> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EB230A000F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: hcut9a9f8ddwgiexz88ngwcefwfn9tip X-HE-Tag: 1699289528-1992 X-HE-Meta: U2FsdGVkX1+SFzFg5fnxPfUQB8fG83y+Ml0hnKPde4OZvOH0RqHOEqIVqfcu4QEHfyPpjCIy6J3P+Xl3SvVJsOx85iynDlkngx0HqcGFXP+CIbyLDg0meY8NhjiGNg6tJ5AfEZRRbQDKiwhY5T9o8N6cotRiTZp7UJqAEUJCK82Gtwl1jFLBJPkLLoYVh5rDoPOqkT+P9eYpFy30dcl2g/fNzy0YaLL2TpDwI2AZ4UxNj4MUF0PuKxUPNVILkcWHcDogvQRPs43n3S/nqYIeBYEhu+SGWmc/ZCtW9IAf1Mjyk2Gfxs99FylfbUdEVslsK/7L4UjCumfU0l1myG+LDctI2XGLYDyN35jdFBYEgH34pmSRqXjrk8kFDChkCqI5OQHvok9TSHO9vBrnZ5eE7UPFEMsu8cZQ7RIXrotcDJrRHZL0GTz3Dy3WNrZ35A9XsVcf0P6YW9UqDjWXGnByYTnfbLGWLRE2Lfj8rvIR2SQ6r/1mLTYfxhDEOnZmBS912aaqlQS9dg4lZgpOI71QmjGDxU0HVKrkW/qRl2r4O3hLTF/RrMiYwIly4lWgL28vt+9Gga3g6G+rF61VaLbPtNEfArcXbeLh+NzVvp50W2LbpHqTE9JpRk7nST2w8Bbq5xl4FMrjsd7pfQdKUIjIuWZLMWrnRvdw3dkJgabkY/BIca7O5lGZTJqFd3Ap55v596SqfJoVhC9L/NsHoqpZGOTs0glTSrqVMA49h0UAPcPYLkq5FgeYUbmuaklVn0qmaWbdoBPKQzf2Z9QIRVjlYm7QdXm/3duAp2NvToe58yfbr916deZ88DuuNaDQbYEMToglnV0wSEY3RFUgO7t0mn5tpxHAvrp2JJj1reUlivtEIfVzpxzE3a/bZ+VRhe+T8yUsIJulSkq+ErSJ28pWgMA0DfZ8pnNQaXOCmCxpa5echa/ABTRMehMn3fMabX2F15jAlt80Fov4hdJlJrO VYKuUGFT FRWgzAGTqWjar7A2InMs0IYzeZnnS2GZBtOSi/B35qvmebKhZYvv7fub0kJIwtua2FTt2kpG1vq7pzIA1SHP2DELITCEQReYTiQqPnQTm5HQcOWNIKpaXUu0MW2pIrxVWNdWVA+zk3zNqIkBtJWHwv6OApoDZyDw+G55T31dGXVB1Wq7+NepPTkxN1WFztnADBnVo3LhH7mD0GlCbN48bx38hKPrLpW4YQI52uO+jmS95wfM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 6 Nov 2023 19:23:47 +0300 Dan Carpenter wrote: > On Mon, Nov 06, 2023 at 06:41:37AM -0800, SeongJae Park wrote: > > Hi Dan, > > > > On Mon, 6 Nov 2023 17:07:40 +0300 Dan Carpenter wrote: > > > > > The "err" variable is not initialized if damon_target_has_pid(ctx) is > > > false and sys_target->regions->nr is zero. > > > > Thank you for fixing this. I actually noticed this issue from Coverity Weekly > > Scan of -next tree (CID 1570878), and was about to send very same fix, but you > > were faster :) > > > > > > > > Fixes: 0bcd216c4741 ("mm/damon/sysfs: update monitoring target regions for online input commit") > > > > Cc stable? > > > > The fixes tag is from last week so I assumed it wasn't in stable yet. You're right. But the broken commit is a fix for stable trees, so I was thinking this fix should also be merged into the stable kernel together. I think stable maintainers would do that on their own, but I wanted to make sure by explicitly Cc-ing them. > > Also to be honest, I wasn't totally positive this bug could occur in > real life. Again, you're right. The uninitialized value can be returned to the caller, but the caller of the function is not checking the returned value, so no real problem can occur here. But I think the unhandling of the return value is a bug itself, that not making system crash like things but might make user confused, so I was preparing a followup fix for that, too. So, though the problem the fixes will fix are not significant, I'd prefer merging this and the followup fix to stable trees if ok, since those are anyway bug fix, and should be simple to apply. If something conflicts, I will provide backports. Thanks, SJ > > regards, > dan carpenter