From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDECEC4167B for ; Wed, 8 Nov 2023 16:54:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DA2380022; Wed, 8 Nov 2023 11:54:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 589DA8D0073; Wed, 8 Nov 2023 11:54:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4527A80022; Wed, 8 Nov 2023 11:54:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 348328D0073 for ; Wed, 8 Nov 2023 11:54:44 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0F0B2B5113 for ; Wed, 8 Nov 2023 16:54:44 +0000 (UTC) X-FDA: 81435386088.23.F0810F2 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf08.hostedemail.com (Postfix) with ESMTP id 48704160011 for ; Wed, 8 Nov 2023 16:54:42 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IvN6xY67; spf=pass (imf08.hostedemail.com: domain of ov.wagle@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=ov.wagle@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699462482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o+oGgPDVqvwYoEeg0MhNKCXwVyeYHtfYEuAh5Z3SzJM=; b=XJOdSVmrBJVykLfYDDpBkQ31a/qdzunpIGM1zNDchD/wgSuKeJZp4gIKzGyjTpTltxzRa5 oCkuhdVTx1t/gllZQ4RKepIFzC5CBmQxo8eWYQ/8ccRNDJKpfX7jAukVx0pLKUb2fdRAP2 VmGPUy3gAQcBtUewU7iDVFCQSYCMhWQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699462482; a=rsa-sha256; cv=none; b=RwgGieqmtPwIKrO8kkOD0O6960pgxClECfufQEfjBlmia3bf7kS7wZat6hlaq9MFGuSsdV MdeGbe8BctFVvA0+1przB9gy/Z0MnUh4KH8yMxmjaRLsBDKveSIVb05W/NWiOjaZ9TK3g/ KgEDG4LUIV19VP1H4MgVIVG4d8jOEOE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IvN6xY67; spf=pass (imf08.hostedemail.com: domain of ov.wagle@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=ov.wagle@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1cc131e52f1so7871215ad.0 for ; Wed, 08 Nov 2023 08:54:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699462481; x=1700067281; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o+oGgPDVqvwYoEeg0MhNKCXwVyeYHtfYEuAh5Z3SzJM=; b=IvN6xY67rWJlVJj5k95UhOohQJQ79ZQPEOjwV6W+lQemUCXD1QgHo9Xw+NoEt5aRDl xmmEXNABSXo1ZwRzVaT6QQuxEFgN9+cKjebG8vQrIcs725Ka856Cwi9Ib/PDeMufPbgg n90ZKDEkMngg2iE6jPYobH0sUfvEqyeLiv4jmAAiFZrZwF0yoNfKDmbAR9pJX2PBCfq3 x1OQfkKVFy4vJaxKcdn49QL1CqCuRfNDhJrw0OMZ+0I0F5mpWD/12Hc4vFPupnmjaN5W Xfyj60K+Gq+WMySHGU2NqRn7ROZIRvkNEQ/gJia+bGTjArTgDczcjKTI8cR5AL/Dn7Ur 7mFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699462481; x=1700067281; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o+oGgPDVqvwYoEeg0MhNKCXwVyeYHtfYEuAh5Z3SzJM=; b=NowJyX89lVXGj5ZMXxeCq7m9NTJdBL99SvW7sc/LSfNQ8zJ9bSgSn2PsstebIhm2TE 84h+tt3Wx/lKrR1wvuBwWDwXeAvIenwOk0IYTlLx5FbSXF0FWjGrwmZBHo1+/QvyR8hI 7IO6JaqOxWjTzDrMN/qNKPNgFJxffnh0uqT5NPBCf1Abt4BX9b940rz2a4x/PtKKuOnT 88D9T6vfKRBibdNx8mLRKuZ4JPRZbpcmVV3NAsJxxKlbVOqFePNPCLTdrgtXL3KD7uhw xMWwqBKxXmkrb0kPcVaVtw9Ri0QMnUIZtE8Vvq70HjXRQX24JN+QmnxBzrylAbB3fWmW QB6Q== X-Gm-Message-State: AOJu0YzpBSbuR1WApfNjop4MJ+ZI5/W8IYeIhLBbUrtI1irEveuy7xz2 jXw4/6LGkUhRqUvNPSEWbvI= X-Google-Smtp-Source: AGHT+IFCexdp4RAER4K6Q6fHIXfkiCziZCFCNx6hf6En6Uwvo8ySjUJCFHMluv3skNYerb6HJ+PiHA== X-Received: by 2002:a17:903:230e:b0:1cc:4488:afba with SMTP id d14-20020a170903230e00b001cc4488afbamr8798614plh.6.1699462480811; Wed, 08 Nov 2023 08:54:40 -0800 (PST) Received: from omkarwagle.hsd1.ca.comcast.net (c-73-92-27-236.hsd1.ca.comcast.net. [73.92.27.236]) by smtp.gmail.com with ESMTPSA id a20-20020a170903101400b001c9ba6c7287sm1966177plb.143.2023.11.08.08.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 08:54:40 -0800 (PST) From: Omkar Wagle To: catalin.marinas@arm.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Omkar Wagle Subject: [PATCH 2/2] MM: kmemleak: Add %x to pr_debug Date: Wed, 8 Nov 2023 08:54:24 -0800 Message-Id: <20231108165424.8845-1-ov.wagle@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 7sm6izgch8ykp73j3mzdrok8zbn9159b X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 48704160011 X-Rspam-User: X-HE-Tag: 1699462482-489673 X-HE-Meta: U2FsdGVkX1/W/vSBDhuzpPVR9AD6ANLwIIwqvM6elW/itWsetdrrlsks5l8AeT+1hi/NYeQnnaQ1aRoEnW9o9eJkqODQ8YF5rtfMa83CgZH6msk23mRPo5fbedKhzoYM6k7Y5Ixwd/aad/L9sl6MdDiVc9O02jF9MCdItjr0M2UZeq49IYCwytoBPaLw0sclnonis7VB6S+w0jlI4KK0QnQCo0ow4yHDHx2a+exGbQrsdpgrhA9md8HBByPKKC3T0qXYC4wXEoLvf9u8wb+XFDDhISKhs/KHYXoT0hmsn60hP7Wp8Mr5IEv+SfLuzLcnoaMkO9ZhvwQ2Cfj0SfVf8vuzPtr3r1B7XbHCB/2GTqG8M5W+LNytOgG0dypTp1hqe8BoUDHWYpbm5fhPC46KdsHh2d/WatHoX/SeLubPSb6uKooWBgntmYZ/OsZUFMhWyb+2VvxhI1nlIcVgFZiiMREB34BMSHI/Sr6dWiJCavAq9Prbaq3VFrd0lX/slbRoDNZtOvakbaobxhFdUBp2hPy+od+yTOlyx6SRY+sirTr6abVGj5GbiqmZ20NQSR0Yyvhv/OUK9RWrs6pic1Dyth+A+mq1PxCTFqhjTq2FES6NRt5O39qkgUOFRzY++D7/8knEVAYW05hBAjKfWEQtRytvlNN0l3q42o+UZyojkCBCpSWhtfExgqbSYTvOH9qGkfIpruYdT+MX+fmB8HIHGgdLWK7wKCF+zCRbAEBRFLMsDMIddzA/SMOyE1LnydIQb5v0u3C6iSvjYy1b37N6M4qZhY4Dsga/LnQCLQVZz7oFx4om640nJH7Icz5gWNzR55/UlB0L6n7x8rdbBR+0t2eSntFKSJIc+vim0kEFRi7JfrfFw4k4A1XKcvQdpG+DHn6WnspPTXIRUBgzIsiVCDgMJ7xShAWsRLC1U/jXTJh7j1EcBBeMvS1z5Xcs0ZAwL88zk2FH1HyqriDi06P 45wE5rrr MdKVdUmjVHVQ/bc5yRMq/cimHaDG379c3LooyrsNhJUnB12K5yhlL8PVCbMhwVptd+c4NPesd5vwi/iYkaEbBjT7dZsDctZhIfD4D8Z4Cmhxq3l790yaH4Px971gS4CdPzYcL6l8fofWzfbk+ogStf1tLUPCcnMhToUP5mPpxoVOrSg+com0JQumXWEaXTD8RxszVf7FtyUT5o3RpK4YuxQIS2sB6D2S7zh4tCWcZkyJbU5hlkBhFDYSK4NF2lpnrTanKzf90Gy3yE76HFQR9K2tDyQP+xUQ9PoZb6jmkViwRZMbcmk10vuofTHcTuYvYIhVETPNNMP5fJ7y10kDJ/qO+8gvatGaKa2y/bT7tcwY1JARfvEFwEBL1q07dPIDjoka19h3l+K9VmDtzhpy+23flIGEjBo5OdBgpQT6DgkiibkIxgNk/5CK64ZVCIAJcAtqsVUH5PMKY47N/8KzD+Qj1HXNHo8IRdRGGqOR+43lsAHS8GTNIm040GwliwgvjHCglIKXhsw5/F6ALZix+TkDW0H7xhUWISkcgQqyx5FjZ/TG4PQCI5V+3mIHdlVI7KmE8ANb0BfOJSYKorFBmE7wo5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add %x to pr_debug to keep it for debugging Remove the NULL check for object pointer Signed-off-by: Omkar Wagle --- mm/kmemleak.c | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index a7b74dc3ff01..93b77288754a 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -410,8 +410,6 @@ static struct kmemleak_object *__lookup_object(unsigned long ptr, int alias, unsigned long untagged_objp; object = rb_entry(rb, struct kmemleak_object, rb_node); - if (!object) - break; untagged_objp = (unsigned long)kasan_reset_tag((void *)object->pointer); @@ -1030,7 +1028,7 @@ static void object_no_scan(unsigned long ptr) void __ref kmemleak_alloc(const void *ptr, size_t size, int min_count, gfp_t gfp) { - pr_debug("%s(0x%p, %zu, %d)\n", __func__, ptr, size, min_count); + pr_debug("%s(0x%px, %zu, %d)\n", __func__, ptr, size, min_count); if (kmemleak_enabled && ptr && !IS_ERR(ptr)) create_object((unsigned long)ptr, size, min_count, gfp); @@ -1051,7 +1049,7 @@ void __ref kmemleak_alloc_percpu(const void __percpu *ptr, size_t size, { unsigned int cpu; - pr_debug("%s(0x%p, %zu)\n", __func__, ptr, size); + pr_debug("%s(0x%px, %zu)\n", __func__, ptr, size); /* * Percpu allocations are only scanned and not reported as leaks @@ -1075,7 +1073,7 @@ EXPORT_SYMBOL_GPL(kmemleak_alloc_percpu); */ void __ref kmemleak_vmalloc(const struct vm_struct *area, size_t size, gfp_t gfp) { - pr_debug("%s(0x%p, %zu)\n", __func__, area, size); + pr_debug("%s(0x%px, %zu)\n", __func__, area, size); /* * A min_count = 2 is needed because vm_struct contains a reference to @@ -1098,7 +1096,7 @@ EXPORT_SYMBOL_GPL(kmemleak_vmalloc); */ void __ref kmemleak_free(const void *ptr) { - pr_debug("%s(0x%p)\n", __func__, ptr); + pr_debug("%s(0x%px)\n", __func__, ptr); if (kmemleak_free_enabled && ptr && !IS_ERR(ptr)) delete_object_full((unsigned long)ptr); @@ -1116,7 +1114,7 @@ EXPORT_SYMBOL_GPL(kmemleak_free); */ void __ref kmemleak_free_part(const void *ptr, size_t size) { - pr_debug("%s(0x%p)\n", __func__, ptr); + pr_debug("%s(0x%px)\n", __func__, ptr); if (kmemleak_enabled && ptr && !IS_ERR(ptr)) delete_object_part((unsigned long)ptr, size, false); @@ -1134,7 +1132,7 @@ void __ref kmemleak_free_percpu(const void __percpu *ptr) { unsigned int cpu; - pr_debug("%s(0x%p)\n", __func__, ptr); + pr_debug("%s(0x%px)\n", __func__, ptr); if (kmemleak_free_enabled && ptr && !IS_ERR(ptr)) for_each_possible_cpu(cpu) @@ -1155,7 +1153,7 @@ void __ref kmemleak_update_trace(const void *ptr) struct kmemleak_object *object; unsigned long flags; - pr_debug("%s(0x%p)\n", __func__, ptr); + pr_debug("%s(0x%px)\n", __func__, ptr); if (!kmemleak_enabled || IS_ERR_OR_NULL(ptr)) return; @@ -1186,7 +1184,7 @@ EXPORT_SYMBOL(kmemleak_update_trace); */ void __ref kmemleak_not_leak(const void *ptr) { - pr_debug("%s(0x%p)\n", __func__, ptr); + pr_debug("%s(0x%px)\n", __func__, ptr); if (kmemleak_enabled && ptr && !IS_ERR(ptr)) make_gray_object((unsigned long)ptr); @@ -1204,7 +1202,7 @@ EXPORT_SYMBOL(kmemleak_not_leak); */ void __ref kmemleak_ignore(const void *ptr) { - pr_debug("%s(0x%p)\n", __func__, ptr); + pr_debug("%s(0x%px)\n", __func__, ptr); if (kmemleak_enabled && ptr && !IS_ERR(ptr)) make_black_object((unsigned long)ptr, false); @@ -1224,7 +1222,7 @@ EXPORT_SYMBOL(kmemleak_ignore); */ void __ref kmemleak_scan_area(const void *ptr, size_t size, gfp_t gfp) { - pr_debug("%s(0x%p)\n", __func__, ptr); + pr_debug("%s(0x%px)\n", __func__, ptr); if (kmemleak_enabled && ptr && size && !IS_ERR(ptr)) add_scan_area((unsigned long)ptr, size, gfp); @@ -1242,7 +1240,7 @@ EXPORT_SYMBOL(kmemleak_scan_area); */ void __ref kmemleak_no_scan(const void *ptr) { - pr_debug("%s(0x%p)\n", __func__, ptr); + pr_debug("%s(0x%px)\n", __func__, ptr); if (kmemleak_enabled && ptr && !IS_ERR(ptr)) object_no_scan((unsigned long)ptr); @@ -1258,7 +1256,7 @@ EXPORT_SYMBOL(kmemleak_no_scan); */ void __ref kmemleak_alloc_phys(phys_addr_t phys, size_t size, gfp_t gfp) { - pr_debug("%s(0x%p, %zu)\n", __func__, &phys, size); + pr_debug("%s(0x%px, %zu)\n", __func__, &phys, size); if (kmemleak_enabled) /* @@ -1278,7 +1276,7 @@ EXPORT_SYMBOL(kmemleak_alloc_phys); */ void __ref kmemleak_free_part_phys(phys_addr_t phys, size_t size) { - pr_debug("%s(0x%p)\n", __func__, &phys); + pr_debug("%s(0x%px)\n", __func__, &phys); if (kmemleak_enabled) delete_object_part((unsigned long)phys, size, true); @@ -1292,7 +1290,7 @@ EXPORT_SYMBOL(kmemleak_free_part_phys); */ void __ref kmemleak_ignore_phys(phys_addr_t phys) { - pr_debug("%s(0x%p)\n", __func__, &phys); + pr_debug("%s(0x%px)\n", __func__, &phys); if (kmemleak_enabled) make_black_object((unsigned long)phys, true); -- 2.34.1