From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5BC1C4332F for ; Fri, 10 Nov 2023 18:31:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47DAF8D00F7; Fri, 10 Nov 2023 13:31:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 406578D0005; Fri, 10 Nov 2023 13:31:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A7F08D00F7; Fri, 10 Nov 2023 13:31:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 14CBA8D0005 for ; Fri, 10 Nov 2023 13:31:39 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D3EF3C0F38 for ; Fri, 10 Nov 2023 18:31:38 +0000 (UTC) X-FDA: 81442887876.29.A0F618C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 2E3278001F for ; Fri, 10 Nov 2023 18:31:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cLpW5BMj; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699641097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lfTOBxbh0F7j/b3NsEz2SFeMSi6yebNoI6YEG98zfWc=; b=yqN3Y3vC563pMSgsG2ZX9NvEio4Y+DfFuAMCR1Tbwhs7P0Ueo/XtN9VY0hn7dFDCe8go5t dYQ2xhw+2BD4olfs8W82hxin+N1+XM5gNz7kJG2Q1oNC1gagb8iWOXfqF5AvDiQ8Q//OPb OPExmwqWymlte3UCDxHFwIvm+oPvrpA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699641097; a=rsa-sha256; cv=none; b=pN7NE2Qt2mmjItaivmg3rcAO+l/bTEDtd5Rb8rRVwOa4JQCboEfZAviHDDeC8KZmuBuWt/ W3K4MnfapnWzhBjWhLi/p3QAiPCmloG4IDAELsn+L0QIJD3WOzjerIX/c8lBPaLDCH2Ur7 pG1jR102uXqS0vyxEV3luoBue1ShJKg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cLpW5BMj; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4AB7161A2B; Fri, 10 Nov 2023 18:31:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E427C43395; Fri, 10 Nov 2023 18:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699641096; bh=Cd+a5xzw1t7k6mz6ZPquvIB5Ojq2rLP5RewLP3v40qA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cLpW5BMj+iwJDnH11uWDwp+RwLlXxJL7ovTVethAaULIpRW2lNkTP+AW5E3SYrp2x 4BwwaIGsG5fmyT+COnH9i5YuP+6U33hW12UBly2A3EIrhf60g7hibgCykRoIMa4ti+ kZpWjxtJn2NhtqFEthWKsNa1cSK5s0aljGqfB2vbWJI6tD6UEUO2J0Ol/AyFfOuPrH mNzuaoStE9hZ1guJsvj7CqmPovnLW8Y2z9R2b1pJT2fU/ol2HQJKs7/gD3iadvoT06 E6azr0SzwftNQKfG26nKMtzbDAaezkj8rJoZ+w/y/qfQNwUCgxrs4RiOIGo955KX02 N6xOSz7wK3tng== From: SeongJae Park To: SeongJae Park Cc: Hyeongtak Ji , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hyeongtak Ji , stable@vger.kernel.org Subject: Re: [PATCH] mm/damon/core.c: avoid unintentional filtering out of schemes Date: Fri, 10 Nov 2023 18:31:33 +0000 Message-Id: <20231110183133.65565-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231110182240.65426-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2E3278001F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: paufcoggfyhzpwa488ta5835dbr4t7wi X-HE-Tag: 1699641096-745132 X-HE-Meta: U2FsdGVkX1/oFjr+MapCr3yjis5a6B3ubbcGB1maJTEbFLFlyu47AS0aaEMeTwBMa0dyypmdtYxgXxYp+3A8b8Q1GcVofRuwGMGcen4/+kn8Hcz0nDoEGG+8xBfbBHNik5lMFrFdgKbAkO1VvwMwCeQFX4aePfkISfswQUA6HG+rKcVLToJl81VDYfoxMOt+UP3Ad6uyHcooamNWPIt0JxHQkka0vGiJU2DoYfhuQFXYohKP855JONGPSjrNmMsbBUKm47hlhFzWgLOHfLuIUab78SjVeFlui+cfbHOz4T+4kHfcKbOdsq3NZXhjohfUwHsdPCSkksnxt7Ciz8CfsOLCh/I6ckM/30CaVYsXOzFqtGldBKc+2GyUDD+Ui5x8n7moITQlRwpefCVVp3UALUVIUO8Ikx8wL3XO1FzlWaH32JuJLhhdQhCcsbhpl2TSPbcUJcQR2ZsU8vvKIMHBtFT4rS5333QOxRzTDOqezlyIZjpBKoKTLLLHzW0WOccMBlyz7BlPFbKKMVDxRrcNU7cE5axhgul73d8cC+19B29r1tapHPe3quF6STapUF9MC5EzsRK+oaGcfJ5BQfCsql84/WWHdGiJ6sYdS3o0m+rXy5+t7ztBXx46UfCR5yKoN4k9l0a6gyHUZHSgqBfjL9vk1ObY/M8b2IT1kAcaQWbNEJSZX3MbXY38LEUzmaH6bgyg02yIFUgzPBY6sY0yRfahzdH2uLlgIGs5yvFlX4Q5uiCBwpQuhma9nSVWNpBjpabq0Dw7j7qFfNOBzpM7RNjYK2t3Uoe/qKcHNnf1bPbRgX6RrZKikBbHQBMwTYfhSDSRJheXHAmWeWS8rpgntSVMeasg/0XRmov5Haz+DLvjdBTU2IybBGVmf4bmHVj+nAEaJQaUn7gUqCYLaBktrOvawJeb10TxApbw3nRzaG4ajwnkuhjsj3pVTlj6CSTWtbZMmbS5kUq5783k1Dk iWbOIh1Y tf2DXUPKokLdVCBuKcuKFqUW1EpsiVg/Hm2R2imdgOSmuty3V53wondKVbTHD76U5HevqFf4BkUKRSB51Q0n1IhuVDwzILRbrZdxKKt0nktu24k4GkNQUdrgBQ0J3MJkoeDdtHFyQNQnhnn73VKBZteGVNcMO4vnxFSjjmTuU1Kinoahu0hyyabqeEFD0fTe53Z20fSkgnOKzj9J8A4QRutXK5qGiCxntd9tzpvX2sQv9FBv3Cj5AIKWhBo61tzXfiLX4689AfHvD+s8yXvAJHiuEUb7W6UPe9jRY7b1vdnAQOLb32rURrAl/Qrr7vkwR1pUvd0TwiK6JiFCJwMzwjVE1h+khLhB9ekO3E83ujMt9VBtH0wy1r6NbyT+o40U3IfylcMiawipszJf2CX5SbD/PNV0i+ePLU/d8SGekTDcAOhwTg8LpPj1kK9RB2SQk+iXuONABxni3STguYh61CxH/Mq3QSnjvE85O X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 10 Nov 2023 18:22:40 +0000 SeongJae Park wrote: > Hello Hyueongtak, > > On Fri, 10 Nov 2023 14:37:09 +0900 Hyeongtak Ji wrote: > > > The function '__damos_filter_out()' causes DAMON to always filter out > > schemes whose filter type is anon or memcg if its matching value is set > > to false. > > > > This commit addresses the issue by ensuring that '__damos_filter_out()' > > no longer applies to filters whose type is 'anon' or 'memcg'. > > Nice catch, thank you! > > checkpatch.pl shows one warning, though: > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Hyeongtak Ji ' != 'Signed-off-by: Hyeongtak Ji ' > Also, I think we need to add below? Fixes: ab9bda001b68 ("mm/damon/core: introduce address range type damos filter") Cc: # 6.6.y > > > > Signed-off-by: Hyeongtak Ji > > Reviewed-by: SeongJae Park Thanks, SJ [...]