From: Al Viro <viro@zeniv.linux.org.uk>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Chuck Lever <cel@kernel.org>,
akpm@linux-foundation.org, brauner@kernel.org, hughd@google.com,
jlayton@redhat.com, Tavian Barnes <tavianator@tavianator.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3] libfs: getdents() should return 0 after reaching EOD
Date: Sat, 18 Nov 2023 23:36:26 +0000 [thread overview]
Message-ID: <20231118233626.GH1957730@ZenIV> (raw)
In-Reply-To: <ZVk2m1scRfy4Xq0C@tissot.1015granger.net>
On Sat, Nov 18, 2023 at 05:11:39PM -0500, Chuck Lever wrote:
> We don't hold f_pos_lock in offset_dir_llseek(), though.
We'd better... Which call chain leads to it without ->f_pos_lock?
next prev parent reply other threads:[~2023-11-18 23:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 19:33 [PATCH v3] libfs: getdents() should return 0 after reaching EOD Chuck Lever
2023-11-18 22:11 ` Chuck Lever
2023-11-18 23:36 ` Al Viro [this message]
2023-11-19 19:18 ` Chuck Lever III
2023-11-19 20:22 ` Chuck Lever III
2023-11-19 21:14 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231118233626.GH1957730@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=hughd@google.com \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tavianator@tavianator.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).