From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB63C61D99 for ; Wed, 22 Nov 2023 15:08:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FD996B0253; Wed, 22 Nov 2023 10:08:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 75E886B0255; Wed, 22 Nov 2023 10:08:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FF7C6B0257; Wed, 22 Nov 2023 10:08:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 503AF6B0253 for ; Wed, 22 Nov 2023 10:08:37 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 12A3CB5E43 for ; Wed, 22 Nov 2023 15:08:37 +0000 (UTC) X-FDA: 81485921874.15.F6B4120 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id 3AE2F40044 for ; Wed, 22 Nov 2023 15:08:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=brpcOLLS; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700665712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XCslEN6Ry/OHVdp27GD0HdeZtopW8St7MBskladM+I8=; b=hS4BeeVYlfuuUwBnV1MsohXDbbCezF7neGY4DNFKxPWigMahzyLUFLDBybczAoxFBefpDJ GY0RxzllmOKq5de/PTYdRiiHGLnQyA1ELGdkPF0Fd1CU4VXtjKCCTPN7HZWUc9/EqouSvB l+/9l+qEldldnBfSPBVGhzOwol7xFRM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=brpcOLLS; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700665712; a=rsa-sha256; cv=none; b=zkd8eJXll5LkYTmFwV1k46nY2tCyykUIoViBHNRTx/AXoZGmeQzZZz8KLi5lBsTzt38wiM szTT6iE+pKDqd2HrGEJQwMArzG/dB1khM8iR6iv7sCEqU5SCrFM0ol1XywEtAEGbg8BCbo LjaYVt+iB9b8VUOjSlav/zdwRivVAhk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id ACE82B827AC; Wed, 22 Nov 2023 15:08:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACED5C433C8; Wed, 22 Nov 2023 15:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700665709; bh=3D9EkTRhwtR1KDxVCyO9ozwIYZoKnc8Zlmn/8isrzRM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=brpcOLLSzeO16fp0mqb+2kpVrX92pwlI3oRyIEuDj7iOmSymXwZ7IP66xrmUQh1zh 1P4F87hKRKm/sOF/kR87V4CC4ceBJQBeKri8MSIEdaw8hBGPpa/IvL7XkhxTKpA8hr aUhjPRZPfth/y2lTSSkNM4ljwDPqu2EJIMb4nlIPRozDJrdttLwHorHcrts11Df12T O0KLKMy42j1EKsJh769b2Z9DT1i9mruHoO512AiJ5u19s/SQYNjlG/ihoeSJ1lIkux rf+H4pWgWCxJN2HONYwcsbJMGGMs/f44X0JD+N76I0ZEWCskYGt/oOktkDOizAD2/X ZOo1LgmniveDg== Date: Wed, 22 Nov 2023 17:08:17 +0200 From: Mike Rapoport To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm/page.c: move mem_init_print_info() to later place Message-ID: <20231122150817.GA634321@kernel.org> References: <20231122043550.489889-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122043550.489889-1-bhe@redhat.com> X-Rspam-User: X-Stat-Signature: gtzdgxqsznxxi18bag8a7b77e1jnfcs7 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3AE2F40044 X-HE-Tag: 1700665711-605627 X-HE-Meta: U2FsdGVkX1/PuDKOaJjH7tHkhcpeogzUwC4XSlbqkJLQLX7LCjmlkDyORCCPBQ/oHL4pruldzGSE3EMrpQrJMO1Pff319ZNrxuWFz816LFr4dXzqPisXND56pYZfsWHTnx3F6UzQmK5S6kmiiALtoUFZiPvlNAhjZAZl7CUmsQoMcAyGLb8PDycCjpBvpuT8xF+ca6jBxy7sVOd7bdieJcGcDH1wdFsBOx6ojkUNTrWfTx9upAbLccfCh/DjxqMXQvWtdOuILeotNw26eIpvwd/Ks9e6duA/6oN0HSjARR/sZ7nb/HA8n5jUNjlykWjdm9TKPHKal5Ntq5BcWGI0SulAlXy06YW6qbmkR0Vo6ajzOYEBc1l7yUt1R0MvWHQvmffSB6pfcQHtn6UGQ+lqYX9c5bFfXvvgjfFizn44EJdKp83y6iDQNsuWBGIEV3qnRAzy3F7EiayvYBgznt0XV5J94lCiItYNcUf9zQfMVas7EbMoqIke4NIyJUKG0R94vHydtczHcOEhfCFiZgxT1su48+BEhJ/H2AcBMWU1F39OYgAUYsafLorxyToadHP+GXqVJQrcwUjyIYuOrdJ2EhgkYYts4v1xczbp4FgOGX7hn6UyQqa7HwtIy+PTXSqzABkKbjge4B+lQAYXLC/O9qMge6X7prGntk3Ki0DQzlKgRRQ71HlBtF3CmuZRMJoWwcEuGyH6JRhAzjdiq43WmeRBWBmc+Shq2MyMYnd9sd4e1J2SMrv9WNPQDGDUH1923CLhj29Gbhgng7sbdHrdknT71zM1KaoJ4OBqbdFj4wa3GkzzydlD5+pg8FOaQDRDtNXvclfImqwMRaywSgvLeqdcqq+Qt1G/9f8dBlsnbcUs3jlSbhn2wm5eqfrPZP4YX00lyj/iboM56YqnFvFe1Br5O9snREUV5J25M6HZhKjNg+49/cdISZqCxjP2DAZZUi6OQKWLklfFxDWEkT4 nHy5RDp5 LGF4A/LNjfVu+w8K/0TlK7qzrnB/44bCgLrWFWgIBioAYm+hWg7IvtHf23Key1iiPbM6BVnb5KIiCN5CEN5n399HJVNZ8aJAHS0g24hR0Sg2OslEP65fPV2x904qXoAmqT6wt5jXOe/EdeRardy8tZ7e+c43BjuAr+145ACo2zx2zm7ESjvuRQ7wM0RFo4cxWSbkC2hxZ73/jkxIyN+phAua/DwdBNyzyDjShOx4907eQI8JxYbiI7dDUEKtQiRA+lsoZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Baoquan, On Wed, Nov 22, 2023 at 12:35:50PM +0800, Baoquan He wrote: > Subject: [PATCH] mm/page.c: move mem_init_print_info() to later place We don't have mm/page.c, > Currently if CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, only part of > pages are initialized and added into buddy allocator at early stage. Then > the system memory information printed by mem_init_print_info() is > incorrect. The snippets of boot log are pasted here: > ----------------------------------------------------------------------- > [ 0.059606] mem auto-init: stack:all(zero), heap alloc:off, heap free:off > [ 0.059622] software IO TLB: area num 64. > [ 0.143887] Memory: 1767888K/133954872K available (20480K kernel code, 3284K rwdata, 8972K rodata, 4572K init, 4916K bss, 2529756K reserved, 0K cma-reserved) > [ 0.145111] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=64, Nodes=2 > --------------------------------------------------------------------------- At this point only the pages that were initialized and free are available. The message does not reflect that large part of memory is still not initialized, but it's not wrong. > Here, move mem_init_print_info() to later place until page init is > finished. After the fix, the printed memory information is like this: > ------------------------------------------------------------------------- > [ +0.001002] smpboot: Total of 64 processors activated (293724.92 BogoMIPS) > [ +0.050086] node 0 deferred pages initialised in 45ms > [ +0.007309] node 1 deferred pages initialised in 53ms > [ 4.035449] Memory: 131272772K/133954872K available (20480K kernel code, 3284K rwdata, 8972K rodata, 4572K init, 4916K bss, 2529700K reserved, 0K cma-reserved) > [ +0.015995] devtmpfs: initialized > [ +0.003943] x86/mm: Memory block size: 2048MB > ------------------------------------------------------------------------- If we print this message that late, some of the memory will be allocated from buddy and it maybe confusing. I suggest to print how much memory is not yet initialized and leave mem_init_print_info() where it is now. > Signed-off-by: Baoquan He > --- > include/linux/gfp.h | 1 + > init/main.c | 1 + > mm/mm_init.c | 3 +-- > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index de292a007138..2d69fa59b489 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -335,6 +335,7 @@ void drain_local_pages(struct zone *zone); > > void page_alloc_init_late(void); > void setup_pcp_cacheinfo(void); > +void mem_init_print_info(void); > > /* > * gfp_allowed_mask is set to GFP_BOOT_MASK during early boot to restrict what > diff --git a/init/main.c b/init/main.c > index e24b0780fdff..88f238a478a1 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -1547,6 +1547,7 @@ static noinline void __init kernel_init_freeable(void) > workqueue_init_topology(); > padata_init(); > page_alloc_init_late(); > + mem_init_print_info(); No need to make mem_init_print_info() global and call it from main.c, you can call it from page_alloc_init_late(). > do_basic_setup(); > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 077bfe393b5e..d08f7c7f75f1 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2703,7 +2703,7 @@ static void __init report_meminit(void) > pr_info("mem auto-init: clearing system memory may take some time...\n"); > } > > -static void __init mem_init_print_info(void) > +void __init mem_init_print_info(void) > { > unsigned long physpages, codesize, datasize, rosize, bss_size; > unsigned long init_code_size, init_data_size; > @@ -2774,7 +2774,6 @@ void __init mm_core_init(void) > kmsan_init_shadow(); > stack_depot_early_init(); > mem_init(); > - mem_init_print_info(); > kmem_cache_init(); > /* > * page_owner must be initialized after buddy is ready, and also after > -- > 2.41.0 > -- Sincerely yours, Mike.