From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30A19C5AD4C for ; Thu, 23 Nov 2023 09:53:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE09B8D001B; Thu, 23 Nov 2023 04:53:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B68478D0002; Thu, 23 Nov 2023 04:53:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A09C28D001B; Thu, 23 Nov 2023 04:53:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8E2218D0002 for ; Thu, 23 Nov 2023 04:53:26 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 554061CBC1C for ; Thu, 23 Nov 2023 09:53:26 +0000 (UTC) X-FDA: 81488756412.05.7000DF5 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id 58320C001C for ; Thu, 23 Nov 2023 09:53:23 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="kI/ltCMX"; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700733204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ElpKkmNZwkQB0x53s438aBdXInP+5S64dJxKxUrzijY=; b=h/LpEvdYE/FfyNcRmODZhcAm6R5OWBl0PYc0502ZdK/XED2NIvyuZz/y2Dy4DZ7Gqc+qal CTa41MTBQXPDPBaim9GbF0jL/f6K7BakOzpQ8XplPLcond0Ytdgnjg4GwF+EBU/Et9XP0v RGZbZ36RpZKNncuz4uf9uII4TwQhfa0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700733204; a=rsa-sha256; cv=none; b=ivd1fwS3LiKDAecMnCAk2FbeoPcYpSuTqm6ikqLP5ujX2B0np5WzeU4EX6lzwusQP4J+/F zGGN7DdgjrV87LDU+SVR/kCayzN382qkI//MlSAzNJKaDU/R2zahr1goJoUHGekB+rjiAF cfSr+8OFCsWUlSp0axJkVfLS5bIF8mY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="kI/ltCMX"; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5B43FCE20A6; Thu, 23 Nov 2023 09:53:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D63AC433C8; Thu, 23 Nov 2023 09:53:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700733199; bh=vpNmPLyRtojWpj1u7BZ0pUMeZOaVneyGtaclUwQtGhM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kI/ltCMXyxvzOM/NbQhlwrVBdCBGUlmL/N+aVb5kqz5WPlU1V1adn8tG/VvssuJyz +pWMA4sWZVtJc/Db7AdoLSkpJb7ZXrfsBNoQYLWv3xd/U75grqwwoLRO31cFE5Q6ZR TQETi0f9ubSu8PMMwpec0zokFtqW6nzKRvyJQx4HCKknPxD1Ou0gYBwxtEW11KEa4l lLqgHW1pMrIZoOW9rgMptbVcoidM57w86a5BWMteqF8NH2Bx6PXaBvU0ql0ijcOG8s dAOhicpX5TK29HlC5aTow2U5C2/R1aZk1QBS3kBEZ3uj/0EDfYQArg5Q9ZpLxu1/jK +JYYW2fe+3mXQ== Date: Thu, 23 Nov 2023 11:53:04 +0200 From: Mike Rapoport To: Christoph Hellwig Cc: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , "Kirill A . Shutemov" , Lorenzo Stoakes , Axel Rasmussen , Matthew Wilcox , John Hubbard , Hugh Dickins , David Hildenbrand , Andrea Arcangeli , Rik van Riel , James Houghton , Yang Shi , Jason Gunthorpe , Vlastimil Babka , Andrew Morton Subject: Re: [PATCH RFC 03/12] mm: Export HPAGE_PXD_* macros even if !THP Message-ID: <20231123095304.GD636165@kernel.org> References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-4-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 58320C001C X-Rspam-User: X-Stat-Signature: 4i6j51sjxf885jawjabfey8ju9wkjnax X-Rspamd-Server: rspam03 X-HE-Tag: 1700733203-456627 X-HE-Meta: U2FsdGVkX18d7eLc/C4drcEhprF5R9iUGnA4RXb4wcgW8zWAM7/vo5Ma6HKcxP5jg0mu96rwecK/ImyvNLJxiZxmCnW03tj+VAThQ7jgTqGDXsPfwICa0P9UzfqzsWFjoMQjbdX+KK3u+IYhGB2tHNQlaUQ626QFSlNfpXtSef8ornZmOiA4WiWFvQtvd6GeZ6RYLWe40YlG6Z48lq4IHrcxR4QVe5y4ziNOD+6wrQML5gqgSMgGOtHeXzZvmjvGKRPO2BbC9fVMjRSY+FBKXDvVqk0dO1sfg0l81P+EEyDt2d4Qq9P4Yrl0snNlEcktuKZVnvJKb+RFNLF0GrE0qzBTs9yCBrMrmBm01jaBVTw55/s8QlAEJDQHsf625Hp6nTUvs4awRtq9VMDCvCImpOoyIuKuO4I9sh29Gh9Qy/UYKcRMVM/L4V0Ykdrx4xeP3jxDoWWCFA/aRPLkS6KVqZKXz8hMSDyu69wNqcjJsRb/rFYLDFUbjqCOlypPxs+YerQcr3Vt5ln4IrmqQbW8cyK5RvnTlCog6zcWrxLedoQ/UCzwi38foC5yDbcTu7k4x8QRg2Gowqk+b3IxTSJWDY3b9ve1+qJ93+M2SjpXV+Os4cKQp7h02r0iUBSUswfu+UqHLRS0wG5nWmOvjPPxI7GCylNt8TLEWkPEm5sHsu9u5MVMsz+u1W617Y+YA72sOEVZs6FFU8VvLouHJhX4tlsps3yIXQ3nmrQjPM8tDEIgsV8Nt0t7Cxf7l8Z8SxUribOvNHoSfYfVRsJZFVurjB0/CHlcRYeAhBWfY1h7ZLc+ahUxOWEXgtwTxi3mKNaBqLMJ7ZsSrjk/IRnZoqdjOPAiMWD7eYUIHGEAQWLqu6ioxFL61kZjSATVe+/XJmGwXqzjrQceFP0HeEcrvgdssZ3wzGkcJe3CDCu3q6KdmYauPPmX4A8Yw82RYiatZt3L95iZEyTamMQug6y1eCf PyhpMWLP LYfV8bfgPYJNiv92bNCmvaQNuoihBs7cxIl81YYesK7r/FZAi1ZYBlBWN8Tz7KlFyOhK2pW6P9bDJEo4Nr3xQmszHJn9OQdX+uX42/9UvhBBDpYFo15VkSXlsNuNngsK7ktjjw+WPUL5MP2ZLRXeGPlfdk/khntXFi7i7T9Hz8nfBE3cl/Nvei6rBlIbBIwyfkE7N6/ELxPULDPaiggszgDgXLCif7IxTJN5DolaTVN1vrDPlNlWzS6fkYjZtksr8T+XQyMOvzvHYKmA/2/CeGxUB5n2AuqNzqCJcYS89DtYcTlQ4aTT8Ewzexss80ozlT6ox X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 22, 2023 at 11:23:57PM -0800, Christoph Hellwig wrote: > No way to export macros :) > > I'd say define, but other might have better ideas. Make HPAGE_PXD_* macros visible even if !THP > Otherwise looks good: > > Reviewed-by: Christoph Hellwig > -- Sincerely yours, Mike.