From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44DD6C61D85 for ; Thu, 23 Nov 2023 10:19:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDECA8D001D; Thu, 23 Nov 2023 05:19:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C90AB8D0002; Thu, 23 Nov 2023 05:19:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B568B8D001D; Thu, 23 Nov 2023 05:19:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A77818D0002 for ; Thu, 23 Nov 2023 05:19:14 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7B81B1602C3 for ; Thu, 23 Nov 2023 10:19:14 +0000 (UTC) X-FDA: 81488821428.29.3452E57 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id 7A04B80012 for ; Thu, 23 Nov 2023 10:19:12 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BfisG42w; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700734752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c4JTGti4GhuSZ/OotEc0cqAq6x3w/Kd5/0tMB4loZVM=; b=wSwg9gktrlFf1ClPu66kmQ/zmgKNYMhUg5gxmQmv1BJWJ+i5jpF7+ZiBO8A921Na+2T3Fs fEOCL4HVkM6ZUsZwNWpaq7PdzHh6WsW7FxWx+NVSAq6JkAVlhvaPYnn3fPAtGt0lPVTshb d5tQUMnLC6Bb20DnQ4KWGDyGRG9QpnY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BfisG42w; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700734752; a=rsa-sha256; cv=none; b=1ZLsV8Z1+BUhYZ7lVrEkbENmVx4/13fW8kiDe+Th7+kzp/h2Km/StoJldXhiFPh0NCNS05 FZ9+O1TLXkoo8bDICg21j0FSFqmu3zGrBDVRL6gkKCueCwgss4MU0ePsKgnPudD/mer4Kf Nab2F8cO2V8HP18SCcYQPCR6pp2nF4o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2EFF2CE2694; Thu, 23 Nov 2023 10:19:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E095FC433C7; Thu, 23 Nov 2023 10:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700734748; bh=BIsZoyFkGqybSMp8LsFEV/t0sEtZKTYGcLF/WgdEU8A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BfisG42wNKSu3613Sr6vuiVrQghiiyZTRf7R1sFUOw1Oha90RgZu8eBFpTxci+zF1 agbbICZLrwQfHlza87s+C4NXEcoif+I8cE/Uql2TVYmm03S+sncf7anWPLPm9epCcW b8NvfnciZgPu9yLK1bBbA7oWJfble2vM5hsF4SB1DIHmjv4XRW784yDrPu7L5vu7eA rdFN0/essbPCun0V4WMDFBMNofYDMYllC1dWxjXHV0nS+4ZMoEdvncJ40jsOmz83pZ A2YiFWVDVNq1DNhvUvopxNOLIIgwS91e6CfYOORHvJZi2r0qtc0dEDCJS1Tuwfggng nrgAVeuDrFwnA== Date: Thu, 23 Nov 2023 12:18:54 +0200 From: Mike Rapoport To: Serge Semin Cc: Thomas Bogendoerfer , Andrew Morton , Matthew Wilcox , Alexey Malahov , Arnd Bergmann , Aleksandar Rikalo , Aleksandar Rikalo , Dragan Mladjenovic , Chao-ying Fu , Jiaxun Yang , Yinglu Yang , Tiezhu Yang , Marc Zyngier , linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] mm/mm_init.c: Extend init unavailable range doc info Message-ID: <20231123101854.GF636165@kernel.org> References: <20231122182419.30633-1-fancer.lancer@gmail.com> <20231122182419.30633-6-fancer.lancer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122182419.30633-6-fancer.lancer@gmail.com> X-Rspam-User: X-Stat-Signature: njeb1gu11pdt9ubu5turziquwhi5zwuc X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7A04B80012 X-HE-Tag: 1700734752-457892 X-HE-Meta: U2FsdGVkX19gR527EAM3lc9cgVDRsM7c0S1tnrcfCrm6kxv1djWQ2X+7rdvbUQxrzSZQ9GpLUAk4jykX20mIzcarFQ1NrIWFB2ZxYn+81daLm44cgY9nlWHvzyFhSEww/bo6egXJXS5DNeBhsYYCLnh+kKi2H2GXO2EDMOHmdwfW8pKDkSOcX2uwqg5eNQT/8WtxoYLFcp5cgdpVXRHT0bAFhAc+YZ2t7LauVPiJs49yY/FFNA32R1pkbk2ifnVBBLHiC06+cqOlZzd1g8bJ0/dHXwKCT/FC++0mTnXVOoh3U3vie2s4ZOfJ3ZoxNsMMQtH8x3kqlryHqYGgn0VfVZHvUXxw1KGX45RMmmpFIQv9DBB9JtvBgP+eVtjYYcA3Nq0lPlW7HSzu2ZIbb0j5TH+lSjN5qNwk+D6Ry1BbqQJM1yl+GvgGCqtuNXt2Cpu4ipwt/H9FdjeYqLDYVeOC59+rGwYEnQfdGi9JBm+6ruMnjBbVdM/jsIoO8/u2bLweATV2Mr8+GtsLrWaZLDHHKH1ARoBWDVHJVq700w/10KV8KeKCEQVAhyWAJ+8Kj3Uw+bblJGxLaaXPIU1YYh+Hm1yZd/Fvoau5CF083nxzXpSyv2XQNiAulxYwKU/UZv1obSXm3LuOt+dQ6kjVSYgTF7QNqcAHNSX4P4qbyOpuUm8Y//nG2hoVCBrpgPxY6xB8bW5uObsS9nqAJkviqcVlZARr8s8nbtFeNk96cptEbS78usk1pdj/3NrMPZcqYLJfdt5BUPZlIDaGsCBlaZxP3Ae01+4+rdgyplI9mZ+DWj8Uti2pfc6NijoppbwskCMVg9hvAmmJFGZUUiPPBSlsYYW/upKoVtm5iJxLTNwTBmpKlUCClPOLQMODbTHD5W6ZvXYGLLePkhJsjs0wtAEegZhFEmpJ5pM42De+N4eLrIi0XsXbiBrNjptqDYXdhD8jE5Z3H7TRe4pxKa5Jfxd VJJYaNUx JS3SbpwnHtDD3eRUHc2p7NiMPFAsgKwbuNFdLuqgHLTWyX1p8SniJxM2RoqD0RwA1ry2NkxRg8asdKPyTkVVnCXS11n3adEp3FSYLwoccB7hi7H30khs0bV1EaEHDt4eYzlyNi7ifqSCb/aj4vGaunTjqMopoJoAJijJ4WOU+wOIoxd32Q5v+SR2o1nFT8V43kM9RrljM/lpmvlzTVzX1mMvOOXkOCo5AKsvOBLEKGgbW9fCsVCaufHiSmsz8sA5XggjbCLyMwQHNYu7VM4cK+GfJBLrjI3lGHB2N+BqgMwfGEleF8fzfm4uxK26TTfcYZAiH71LGrjcqs0o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Serge, On Wed, Nov 22, 2023 at 09:24:03PM +0300, Serge Semin wrote: > Besides of the already described reasons the pages backended memory holes > might be persistent due to having memory mapped IO spaces behind those > ranges in the framework of flatmem kernel config. Add such note to the > init_unavailable_range() method kdoc in order to point out to one more > reason of having the function executed for such regions. > > Signed-off-by: Serge Semin > > --- > > Please let me know if the IO-space pages must be initialized somehow > differently rather relying on free_area_init() executing the > init_unavailable_range() method. Maybe I'm missing something, but why do you need struct pages in the IO space? > --- > mm/mm_init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 077bfe393b5e..3fa33e2d32ba 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -796,6 +796,7 @@ overlap_memmap_init(unsigned long zone, unsigned long *pfn) > * - physical memory bank size is not necessarily the exact multiple of the > * arbitrary section size > * - early reserved memory may not be listed in memblock.memory > + * - memory mapped IO space > * - memory layouts defined with memmap= kernel parameter may not align > * nicely with memmap sections > * > -- > 2.42.1 > -- Sincerely yours, Mike.