From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA93C61DF4 for ; Sat, 25 Nov 2023 10:03:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6785E6B05C3; Sat, 25 Nov 2023 05:03:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6002B6B05C5; Sat, 25 Nov 2023 05:03:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C7A46B05C9; Sat, 25 Nov 2023 05:03:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3A03A6B05C3 for ; Sat, 25 Nov 2023 05:03:51 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EB1BA1CAFF1 for ; Sat, 25 Nov 2023 10:03:50 +0000 (UTC) X-FDA: 81496040220.23.1F6FFD6 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id AF67840005 for ; Sat, 25 Nov 2023 10:03:47 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jJr6hJe4; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700906628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kLE4IRjWf77JlCuwUSkmhXl/3/2gI7dIwSPNxFBPrtM=; b=KFN5e/3PA7Xo8EwVftfHLB6SmBnVS0pUXgMs1GgQtfGdfbVj7kyFSp490N5IfvXGTkNpSu rll1KKX8QGMQM/HEykYFV/RGWVQeCykSzecqhv+kAe6touefqmSmmNiCEQB2+DzgSCLpQL Rx7D29lBAu/CsRQnhAYXuD+G2zH7C6w= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jJr6hJe4; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700906628; a=rsa-sha256; cv=none; b=euHMZkgPfhx4KZh3Kls61QGMTZnuxs07FwlNndMT56VX9BDemY7hXCFwMzteIJ/KxJepYl dsPopTPSiCu2SkmISaF2N/ilqueyHsNg/6ID5So+znUnVk5xiZHzOK/HxiX6i8aznkeLAC ZjVEMyVXjt5oQFFGT0qThZxXnAw6v0c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1144FCE2AA7; Sat, 25 Nov 2023 10:03:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51C7FC433C7; Sat, 25 Nov 2023 10:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700906622; bh=p2Y9N2XAI98q4rgvMYuaA64L0HRfC61PSCaNKkKNa08=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jJr6hJe4kA/IFAUVu+a8cU5PwRzwHnpFw+BVZV7Eazw1jADD5q48cknChA+YK0kN8 75wfNkXi0+hrIRRHvA55kPjFOdCjMIbK/Nkk6J8qugNc4KU2N3JpsizBoq9axvSDaa Ama3nZ62v0b1HOPzmQ34RJS4uA7Q85Cej3G/DZRQQRdtHL0nUXTyRy8I5kixlxPqkN A3S/bhP9BjywvJGFlYqE0IPpGyVfH/D+4vbA24fxy8h6mvVAKXzhtia7+p/TWtN8Xd nbnTiXnGyzJuCC696fLSjtzVxsHlbJEVUtDxOz+tdxa2r8pLb7IFNRXfBAm33IfoOR j2kX5KdSQknKw== Date: Sat, 25 Nov 2023 12:03:22 +0200 From: Mike Rapoport To: Alexandru Elisei Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2 04/27] mm: migrate/mempolicy: Add hook to modify migration target gfp Message-ID: <20231125100322.GH636165@kernel.org> References: <20231119165721.9849-1-alexandru.elisei@arm.com> <20231119165721.9849-5-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231119165721.9849-5-alexandru.elisei@arm.com> X-Rspamd-Queue-Id: AF67840005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 3bxfx88xfsj9uw7q3qhbw5e1tqjod6jq X-HE-Tag: 1700906627-150428 X-HE-Meta: U2FsdGVkX1+92JN3TyVdzh5epPOTVPIiHw3Cx98GQHwdib+fT4/n93/L4laAJ5RWzp5F8AbflK0QEDvK42qAvI1F3+HndIq0js7n2V7VEB6lXnjIhx07jthtxZ0ixUSgkyJCKgTJ6tcnJ0Mi/BnUxyoi6HloRYAwGHtEB9gNYPkWsIzTzy9uW+EKcLf8cp7FVxE1Ab8Szzh4q/jXHkb7CW2ksjCc/t+T3mGVViOFNjqE4Ob4hvDz+VXdvRqRYwu3ns/a4heO+shtPBqK6nYg7b9E5JJGC5N6YSFH5Ampq7jXr5F6ivGaXLa4Ivh4+gcPc3PDO8bqfNCD6p/H4N+bIlnDFdSjn8L5FT0BbX5CqoN5eW6leZ/m45otWCekukPJ3MrifUTn4ZYzCHW2iMvIIZ2Xt/SrcqhCNgBYTaWKh4NMzG19xZRZhwnxpW/XvmBzi0iD+Yw1wYmR8C2Cfxj51mu9tQ5E0gARMZv0KkLRyJCTamYriwWPI7Z2JIvaNnY3fRVYG7Vgl5PRu8RuGi+/UV88KdHIr3EA+Vj20VWXxG9zIXPkzv6cQoXKyrkzQTOq+6pCD9/EqhQCG0oWfVRmbveXt0/qCuLw3RD8HHjRDhLCpjWQ08PKwnmz/oieHbuWjnvz8xk7Ew4tvX3uXyN2gCpnhZdnW5GddvF95ujwsDy4Ckk+JRzsV65ShquMN9vh4DMeAd0thRzfa13Yt1jvLT0clBSz1bcRJ+FiKZM0vhJmX2Mtf5jyznVCsYCcJkEVKrQPBkFwUDpEvKxqhSJ//OgU+e7FbjY4TWWanBoWGA+5WGPUZDoNcwvgQb3PkLAS3cvZOuNwVZVTADKRhaFxNup4acCs6d8yhv+lkNMC1pDWV66TJ0QnEgxcT9UCORrVRaO/U2TMtXFqxYcpe5dX48RIEH3XiI09SvrRSGs8JMXdedqpf10VtiF4ifs+VwEct0e9Y8QwlQxkStDpBt3 /65Vefzu jgY5aISgUinYsi/eZZjFJk1cJlYi9lK9R38zT34I61i27sW8r47q+bSSRAHu4n4Dla5u5rfZ6v3d9Ju7sGSZkLupQE+agU0P+YzNqph+bzIMGw94LefJc6rABNYSBKCB/XAhD62y1Lz2+mu+H4cuQxJ93vjNlCaQMMasvW44Qm0GhM7kuIEwB8om5Cl0YDljKZ52R1IXJZuFBtsibbteVZykFQcgEy+j9KfF2YQGO7nQziMnuxFExB8gu8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Nov 19, 2023 at 04:56:58PM +0000, Alexandru Elisei wrote: > It might be desirable for an architecture to modify the gfp flags used to > allocate the destination page for migration based on the page that it is > being replaced. For example, if an architectures has metadata associated > with a page (like arm64, when the memory tagging extension is implemented), > it can request that the destination page similarly has storage for tags > already allocated. > > No functional change. > > Signed-off-by: Alexandru Elisei > --- > include/linux/migrate.h | 4 ++++ > mm/mempolicy.c | 2 ++ > mm/migrate.c | 3 +++ > 3 files changed, 9 insertions(+) > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index 2ce13e8a309b..0acef592043c 100644 > --- a/include/linux/migrate.h > +++ b/include/linux/migrate.h > @@ -60,6 +60,10 @@ struct movable_operations { > /* Defined in mm/debug.c: */ > extern const char *migrate_reason_names[MR_TYPES]; > > +#ifndef arch_migration_target_gfp > +#define arch_migration_target_gfp(src, gfp) 0 > +#endif > + > #ifdef CONFIG_MIGRATION > > void putback_movable_pages(struct list_head *l); > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 10a590ee1c89..50bc43ab50d6 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -1182,6 +1182,7 @@ static struct folio *alloc_migration_target_by_mpol(struct folio *src, > > h = folio_hstate(src); > gfp = htlb_alloc_mask(h); > + gfp |= arch_migration_target_gfp(src, gfp); I think it'll be more robust to have arch_migration_target_gfp() to modify the flags and return the new mask with added (or potentially removed) flags. > nodemask = policy_nodemask(gfp, pol, ilx, &nid); > return alloc_hugetlb_folio_nodemask(h, nid, nodemask, gfp); > } > @@ -1190,6 +1191,7 @@ static struct folio *alloc_migration_target_by_mpol(struct folio *src, > gfp = GFP_TRANSHUGE; > else > gfp = GFP_HIGHUSER_MOVABLE | __GFP_RETRY_MAYFAIL | __GFP_COMP; > + gfp |= arch_migration_target_gfp(src, gfp); > > page = alloc_pages_mpol(gfp, order, pol, ilx, nid); > return page_rmappable_folio(page); -- Sincerely yours, Mike.