From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B88C07CB1 for ; Mon, 27 Nov 2023 12:04:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 049356B02DC; Mon, 27 Nov 2023 07:04:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 01E946B02DF; Mon, 27 Nov 2023 07:04:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E51D86B02EB; Mon, 27 Nov 2023 07:04:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D5CAB6B02DC for ; Mon, 27 Nov 2023 07:04:34 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 94481801FB for ; Mon, 27 Nov 2023 12:04:34 +0000 (UTC) X-FDA: 81503602068.25.7AB62A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 99685180031 for ; Mon, 27 Nov 2023 12:04:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JMYuadUz; spf=pass (imf06.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701086670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KWNuo6JI/OYsTU4e3seiEKnPSTG4IX85SKhKR7+RBiE=; b=7mWvz6FRUJfLSoos/GTx4B1WU0scc7J+PFuk79/c+yKco/mweQ3BGE37sxBFvZcvpcJJEZ KjwkmabELzXM9VGWuhpVB8mPoKpiT5GjMgg7DtSJkNkxCHzFMD8mYfJrv1dN6quh6+rBi4 g7RKCjrVccPns4IPcYRnzWsbfPZ/1U0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701086670; a=rsa-sha256; cv=none; b=nZ/dEQ6Y3YRcxVduX2eu9YNGCsXOczB42i+PeCDNWEwVnGf1Y23JZAqHg3S329Y0OWmVkz 05+j6Q93gEmxpvVHrFZF2iwQrwq4SA5wqJj1aZooEeg7gVk1VEO9vsArsevOP8WGE3Jbhc cG1wZvfGytYkTetzipmWO1GgsqjNDwE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JMYuadUz; spf=pass (imf06.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701086669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KWNuo6JI/OYsTU4e3seiEKnPSTG4IX85SKhKR7+RBiE=; b=JMYuadUz3FqM4x0r1yXCsWhzdAdXzVjNY4D8D21nxlkFgznlkbNgajTXBZHlZvGN6hx4fu UX+cC7Ih6ap81m2cnCMq2KlbzkMm/BAagHOMbUDTgMWvEd12tPXCtCACc01pCtOw8Q6OKy b0TtIyOAoLCRg6zCeon9jp8NY1djnDI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-nDYczEEeP4yMToRKl1A7GQ-1; Mon, 27 Nov 2023 07:04:24 -0500 X-MC-Unique: nDYczEEeP4yMToRKl1A7GQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B767085C1A0; Mon, 27 Nov 2023 12:04:23 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.14]) by smtp.corp.redhat.com (Postfix) with SMTP id 731645028; Mon, 27 Nov 2023 12:04:20 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 27 Nov 2023 13:03:18 +0100 (CET) Date: Mon, 27 Nov 2023 13:03:14 +0100 From: Oleg Nesterov To: Kuan-Ying Lee Cc: Jan Kiszka , Kieran Bingham , Matthias Brugger , AngeloGioacchino Del Regno , Andrew Morton , casper.li@mediatek.com, chinwen.chang@mediatek.com, qun-wei.lin@mediatek.com, linux-mm@kvack.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 1/3] scripts/gdb/tasks: Fix lx-ps command error Message-ID: <20231127120314.GA19669@redhat.com> References: <20231127070404.4192-1-Kuan-Ying.Lee@mediatek.com> <20231127070404.4192-2-Kuan-Ying.Lee@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231127070404.4192-2-Kuan-Ying.Lee@mediatek.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Stat-Signature: 1d7mmxh6px5rftcsbso8o8pn36k4uh7t X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 99685180031 X-Rspam-User: X-HE-Tag: 1701086670-816797 X-HE-Meta: U2FsdGVkX1+rLxlyg7DMLJPvO01x9JE2HDwnrulbx5xxkAxHpmjBjj3STtoqYIGhn+3hTSvCPjWxcEEV4Hle4IgGDsWFw5ksFX/wpbj3u+urOMHcobhga3S5nbkaWix2QH3Y7jMFG16eArxTon7lsbtdznO+dsVN5EYHWQtV/VrVN8Ycp4eDTFfOdyOUt4UL2IIaC6iPhIyicO7FSV3mUVFzUyDepQngbhbBwbq4vCyOHEFfkgdT8ZuOZUScBJ/Lx4LwAVCl8qfoFNE3y6R+G95oxCIskOGpKjHYj1ZER1CQ2nSIANxFIeS1+TbBKio8GKO+BVvW4jJ+10fFdrI83tDM6KyGterd+3Y1TRbgsaK8Ng/5/nrD3EP3lqGT+UqfWm9wVc8MhwFbPOn1Ku2ZpdhIlLLh/mNzVmaAM5qgof2haai7n8S3cfNwZz0gpzs7pof7ppUYwhAjVzFBD7PX7blPr67IyWa9yg7WMpnqwpEnDbA8vn23mMrTKddK9qyYBh9y6IzFQKaNaSBmZgIl7dz8ilE1vNUoWWNVRwhdUTpx59/v8Gnt5oJdd3/BwGgCnpCy6KUivKdDeEaOA/teqz7iuUC/8Eza4lJvQ8w7gfEci2EKmcE8DvnbUU7HskniixvwkGvjhZE5tvKFsYsPAW4oVtHaEKDKgRsj8jjGc/fUz4Eby0/iEU2gvMLOA9fC8GbT87ZDD0zLQhxvFmobKBtaCEWm6k2tYzBMcouhskdJygPrajXA77wS8QRIx0tpblHDNBFmtzxJWLS8QKtq48BFLxhvcwy+oOk8WDl8t8z3kzcyA4d7H2YBQvsaomdK3AfdAqwtqcvfhftrrDyCdSakbw5xRXHqH0RiU9ltDIsmar8uqi+KZ35WHWoHo6B6ZlE3hcvVhu/ypgIhgDlLYKlR7z++E7O744jnLzdVezpAkmCUhlrfpXma2vsDvmfluVLDZ64ADldKS4+wC8t aZQUKlqI Bc5v+mmoDY75DipKwb/LJmMeoMe6B124qYFTXQaH+oQ3OuYvNpi9OhaBnDLmYUhDf7RGitwaJcvuAayzW+TZTYtcBDMPGtk8iWUC3m1zdP+cxb4l13QqwQN0ofpv/DTQMx1r0zw8PXhA7K0ZkA0ATaUG6PxKGmPFxUPBqrZoVoWMJ/l9qNWnsMmvOeWx2JoV8YnSTdIWLbHp7x3IuHCSYHDzpd2b0m3rYmgVE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/27, Kuan-Ying Lee wrote: > > @@ -25,13 +25,9 @@ def task_lists(): > t = g = init_task > > while True: > - while True: > - yield t > - > - t = utils.container_of(t['thread_group']['next'], > - task_ptr_type, "thread_group") > - if t == g: > - break > + thread_head = t['signal']['thread_head'] > + for thread in lists.list_for_each_entry(thread_head, task_ptr_type, 'thread_node'): > + yield thread > > t = g = utils.container_of(g['tasks']['next'], > task_ptr_type, "tasks") Thanks! I do not know python, but it seems that with this patch we can kill g or t? Can't def task_lists(): task_ptr_type = task_type.get_type().pointer() init_task = gdb.parse_and_eval("init_task").address t = init_task while True: thread_head = t['signal']['thread_head'] for thread in lists.list_for_each_entry(thread_head, task_ptr_type, 'thread_node'): yield thread t = utils.container_of(t['tasks']['next'], task_ptr_type, "tasks") if t == init_task: return work? Oleg.