From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 580FCC07E98 for ; Tue, 28 Nov 2023 06:50:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B36726B026A; Tue, 28 Nov 2023 01:50:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE7126B027E; Tue, 28 Nov 2023 01:50:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D50A6B029B; Tue, 28 Nov 2023 01:50:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8F1956B026A for ; Tue, 28 Nov 2023 01:50:19 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 694D116010B for ; Tue, 28 Nov 2023 06:50:19 +0000 (UTC) X-FDA: 81506438958.23.B6BB25D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 81DDFC000F for ; Tue, 28 Nov 2023 06:50:17 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=if9fM89P; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701154217; a=rsa-sha256; cv=none; b=4VB/jWtNxNEyG9TSogKE7rG1cxEhunPnCgTEPJXuUvFk6061VITbt8gPGS3IQZPf9hQ0b3 6rLQ2+rPrbc3o2cS2g7qZ59OIfibl7snbJp9WR0GbEoiTSlEE2ri5ZbpolKQp9BdG6pOAS KLyJI8vyDuwXsZY5oQB+eqw3Ux+WppE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=if9fM89P; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701154217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=INn2t3m9W8b2w+j0OQX2a5Pi5mkrqP4M5X7d+HtEGIY=; b=AcLkD0UpS378PIGzjC0zrKoqiB4CGEzFiquK1cRH+7zXSPTMC8JihNcm0RBzBVOg+DPcYU UyGUC3+ESbVIcpfdCgWuCcI111aE2Wzh/GuXVADBQhTJkVn00A/9B1bHe7Q+BvjQlEjKcz kr2RG4GDjVdTUKLHWIpA7Y8kAad+Dyg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 8EFF1B838D5; Tue, 28 Nov 2023 06:50:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3030C433C7; Tue, 28 Nov 2023 06:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701154214; bh=BijUODoSlZIznO9rdGnXggiSdi32BpO3PHuXhYrN1B8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=if9fM89P+gYlCDnvkkF1Yr+BLEwcjrzHNVmL7eGBgP+mcsTCAA44Zo/jA2dVG0hka h/LUzMc86Pns899eb+eBzUHUyopA70K0VId+L6bo9UvWEtksLRnYfQgsCIcyFXTmsA StTDz/fcXiBOKdqidbSxUBOYr9dC1xwA/C8VFRnyTj6XuPag4Tu8h7UGU8HWcwBG9+ 1fH3R1gOS/OEy8/WIfOf04Wk3ofHB909dr1lvVQRSa/GLjFVYWIitbmdb/iG2c0hqj gI9GkHgvnjBOAPs5NT6aeOVlwPQnvsC/4BEjUwfK4dSUKeT8i6bctj0fIX1Dbg8u2L G9GIlEM7e/Y1Q== Date: Tue, 28 Nov 2023 08:49:57 +0200 From: Mike Rapoport To: Alexandru Elisei Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2 04/27] mm: migrate/mempolicy: Add hook to modify migration target gfp Message-ID: <20231128064957.GI636165@kernel.org> References: <20231119165721.9849-1-alexandru.elisei@arm.com> <20231119165721.9849-5-alexandru.elisei@arm.com> <20231125100322.GH636165@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 81DDFC000F X-Stat-Signature: t1jcg1zx39gtn8wguq71nbxj6cagca78 X-Rspam-User: X-HE-Tag: 1701154217-189710 X-HE-Meta: U2FsdGVkX1/ynNUl0bWIEYzRDWi3Cqo8M02tjyZkUr4pqPivPCurpmxzZfzArmWGkaljjEitO1TL7j9Xm0UbY8gH6Ga6P6qNUIjw/MAbV4eOiUEFuoZybfNiD8iUNSs+0hyFMwEfAWgEL6zOdv/pkCIYMhPwvokZTD50PX/+9WGnqRb8D6/bUAI5EIKmhxmSsw9Mr2sByZOMXLW39Y852l5EsoSDD7o1t2l3jDxwfah0oyu0JXgO8StfVyC5HkxZRgmQI23USFx3U8QId5P/V+ElHWk18kvemfYLqwddqMHT3K6YAuHFeWOXvp84zblTdsd4ks4nLEMbQJ2eQUe1CRg1o02anYDUNQR/Dq9TonLHcor7ccYj9JO1v13uT+mZ+vfoYr5yu9ZJY2+IJy5aoucf83NVWbfncmxc6SKerJdHTyC++Byo1YVDcB70q8btKwfKgbEt7RfiTrxyBgDOF+NmisXlV2/QACT4nOojJH8siSnaMxj2xU1Q8QqAt9fd7TRBX/cBD9hfIoapihyO7Avc39UkD0wkjKNbhfY2DHjDbJymeCRhkd43OZ7Jw5PB6hpIHtazwpzXscfsX0IaTd+tS4iYfD3GN4Y07ERX4J8Gtu0kU14HstTlBTR7QlsrakVGrvwUoAyCZsC3woT3T6j5ZgEWnV2tAAnhHPtdYqax04hIzK1Ugu8nLhJ8ympqmlimcNIytfqPngWeLNmvWsq4FZYNxPfxdr93SyhTpVNjQoGOvgmUJ0vQXIpK5WI/gKXKIhGhgHDvFZJFKolpuy+cJW0nktpzDkbuFdwXNL1Zwd/H4jg3mHXoTQKSorhTK668go4uDKRtXixqYnUC1I0ZP+LnfIBPXn6mqwoGeIAjKffk8CeOCRHGCnoeurFdZfogBjwxPUeQcxhfG4MznegYhDnQiF/s0ZZYn+dP1C+73JMy0EKCgunWu2E6g/MM+288Foqu6DuJPtxyXG0 LqzTqzG1 jg4YjkV37IK2rlkBn8vedoBW7Bh5Ys/BBgtauaqvvtHcyQFDY8qgnGxb1DQYcuyqMYL0IKCMmY2tuSCYgYBjTJG/QIO0Zp/pLGmc3LVx6vW2lpTmh8BjSxNymGjBb8uTz5TyC9T95oFdOUCop8tJa+xnL7mtIBUYS7G44WrJ8t9qI6tTlCT7icns0JeRkyM6TuU1kaOzL5nqX9twDkp6NdqfcXFjCRrAxa+G9ktzrxGUbdEQMoK6/luXhoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 27, 2023 at 11:52:56AM +0000, Alexandru Elisei wrote: > Hi Mike, > > I really appreciate you having a look! > > On Sat, Nov 25, 2023 at 12:03:22PM +0200, Mike Rapoport wrote: > > On Sun, Nov 19, 2023 at 04:56:58PM +0000, Alexandru Elisei wrote: > > > It might be desirable for an architecture to modify the gfp flags used to > > > allocate the destination page for migration based on the page that it is > > > being replaced. For example, if an architectures has metadata associated > > > with a page (like arm64, when the memory tagging extension is implemented), > > > it can request that the destination page similarly has storage for tags > > > already allocated. > > > > > > No functional change. > > > > > > Signed-off-by: Alexandru Elisei > > > --- > > > include/linux/migrate.h | 4 ++++ > > > mm/mempolicy.c | 2 ++ > > > mm/migrate.c | 3 +++ > > > 3 files changed, 9 insertions(+) > > > > > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > > > index 2ce13e8a309b..0acef592043c 100644 > > > --- a/include/linux/migrate.h > > > +++ b/include/linux/migrate.h > > > @@ -60,6 +60,10 @@ struct movable_operations { > > > /* Defined in mm/debug.c: */ > > > extern const char *migrate_reason_names[MR_TYPES]; > > > > > > +#ifndef arch_migration_target_gfp > > > +#define arch_migration_target_gfp(src, gfp) 0 > > > +#endif > > > + > > > #ifdef CONFIG_MIGRATION > > > > > > void putback_movable_pages(struct list_head *l); > > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > > index 10a590ee1c89..50bc43ab50d6 100644 > > > --- a/mm/mempolicy.c > > > +++ b/mm/mempolicy.c > > > @@ -1182,6 +1182,7 @@ static struct folio *alloc_migration_target_by_mpol(struct folio *src, > > > > > > h = folio_hstate(src); > > > gfp = htlb_alloc_mask(h); > > > + gfp |= arch_migration_target_gfp(src, gfp); > > > > I think it'll be more robust to have arch_migration_target_gfp() to modify > > the flags and return the new mask with added (or potentially removed) > > flags. > > I did it this way so an arch won't be able to remove flags set by the MM code. > There's a similar pattern in do_mmap() -> calc_vm_flag_bits() -> > arch_calc_vm_flag_bits(). Ok, just add a sentence about it to the commit message. > Thanks, > Alex > > > > > > nodemask = policy_nodemask(gfp, pol, ilx, &nid); > > > return alloc_hugetlb_folio_nodemask(h, nid, nodemask, gfp); > > > } > > > @@ -1190,6 +1191,7 @@ static struct folio *alloc_migration_target_by_mpol(struct folio *src, > > > gfp = GFP_TRANSHUGE; > > > else > > > gfp = GFP_HIGHUSER_MOVABLE | __GFP_RETRY_MAYFAIL | __GFP_COMP; > > > + gfp |= arch_migration_target_gfp(src, gfp); > > > > > > page = alloc_pages_mpol(gfp, order, pol, ilx, nid); > > > return page_rmappable_folio(page); > > > > -- > > Sincerely yours, > > Mike. > > -- Sincerely yours, Mike.