From: Alex Williamson <alex.williamson@redhat.com>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: account iommu allocations
Date: Mon, 4 Dec 2023 17:00:52 -0700 [thread overview]
Message-ID: <20231204170052.5967e9cd.alex.williamson@redhat.com> (raw)
In-Reply-To: <20231130200900.2320829-1-pasha.tatashin@soleen.com>
On Thu, 30 Nov 2023 20:09:00 +0000
Pasha Tatashin <pasha.tatashin@soleen.com> wrote:
> iommu allocations should be accounted in order to allow admins to
> monitor and limit the amount of iommu memory.
>
> Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
> ---
> drivers/vfio/vfio_iommu_type1.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> This patch is spinned of from the series:
> https://lore.kernel.org/all/20231128204938.1453583-1-pasha.tatashin@soleen.com
>
> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
> index eacd6ec04de5..b2854d7939ce 100644
> --- a/drivers/vfio/vfio_iommu_type1.c
> +++ b/drivers/vfio/vfio_iommu_type1.c
> @@ -1436,7 +1436,7 @@ static int vfio_iommu_map(struct vfio_iommu *iommu, dma_addr_t iova,
> list_for_each_entry(d, &iommu->domain_list, next) {
> ret = iommu_map(d->domain, iova, (phys_addr_t)pfn << PAGE_SHIFT,
> npage << PAGE_SHIFT, prot | IOMMU_CACHE,
> - GFP_KERNEL);
> + GFP_KERNEL_ACCOUNT);
> if (ret)
> goto unwind;
>
> @@ -1750,7 +1750,8 @@ static int vfio_iommu_replay(struct vfio_iommu *iommu,
> }
>
> ret = iommu_map(domain->domain, iova, phys, size,
> - dma->prot | IOMMU_CACHE, GFP_KERNEL);
> + dma->prot | IOMMU_CACHE,
> + GFP_KERNEL_ACCOUNT);
> if (ret) {
> if (!dma->iommu_mapped) {
> vfio_unpin_pages_remote(dma, iova,
> @@ -1845,7 +1846,8 @@ static void vfio_test_domain_fgsp(struct vfio_domain *domain, struct list_head *
> continue;
>
> ret = iommu_map(domain->domain, start, page_to_phys(pages), PAGE_SIZE * 2,
> - IOMMU_READ | IOMMU_WRITE | IOMMU_CACHE, GFP_KERNEL);
> + IOMMU_READ | IOMMU_WRITE | IOMMU_CACHE,
> + GFP_KERNEL_ACCOUNT);
> if (!ret) {
> size_t unmapped = iommu_unmap(domain->domain, start, PAGE_SIZE);
>
Applied to vfio next branch for v6.8. Thanks,
Alex
prev parent reply other threads:[~2023-12-05 0:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 20:09 [PATCH] vfio: account iommu allocations Pasha Tatashin
2023-12-04 15:46 ` Jason Gunthorpe
2023-12-04 20:31 ` Pasha Tatashin
2023-12-05 0:00 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204170052.5967e9cd.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).