From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B57BC10F05 for ; Tue, 5 Dec 2023 17:23:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BECF86B0093; Tue, 5 Dec 2023 12:23:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9E3F6B0096; Tue, 5 Dec 2023 12:23:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8B9F6B0098; Tue, 5 Dec 2023 12:23:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 99B6B6B0093 for ; Tue, 5 Dec 2023 12:23:12 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6EF87A08A3 for ; Tue, 5 Dec 2023 17:23:12 +0000 (UTC) X-FDA: 81533435424.29.368E80A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id BCB3580003 for ; Tue, 5 Dec 2023 17:23:10 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EpMPJv4X; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701796990; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1SXkarC0ezEFReQKF247WpU/Heq+L2MxovVLAGrXWHU=; b=yCWHttedmS3Vvw0uLdTK/7DcUEFbMjOiFu7AqQLQbnV+kLn2kMawkEPCs0Khv4GA/vrHVu rCvB8JCrmlyRw2uHeWsCACA1tTQw4KPFXWu98KlaUX7cAwpIkRYjk29uZ2snwuT+LUwMMv PLKRL3MCC+5DFiS/hRx84vG+y6YtCu8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EpMPJv4X; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701796990; a=rsa-sha256; cv=none; b=Nz/eZ1g1P8Ts0kNpZs/oNWeqtRXfFUXhw9ZARg5aWIU8ZYnBNvvUtbYOq87xYS/w0KAwHo d4Wlo3F/JMRmArioxFmZrfAsiBf87RYW6d6zdXBziNE4/LDNkH0qRiINfPRZyRZeDyIimH wT7qVPlOVRl/8pbhWHtF6GP4DcxmkpA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A43D261880; Tue, 5 Dec 2023 17:23:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEEB9C433C7; Tue, 5 Dec 2023 17:23:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701796989; bh=pU9M00dkHKU1TS7CBL1inocdlITXmGP7gY/XTaLHoyc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EpMPJv4XEKXQyQYQR6FkqXiXv1mDf/eSYeILTXcboW3xOS8bPLZL+N2huZtkLCQEL 0OtFsxwzAd6kdDSsD7WpB6tttxUtHcP0gxlldD7BJAy6XYXjMH4NSuRVOLFiD8ViIy rWHgLBD2A0HITc0L8KBBIrpwPPqNjiN6VBG8xMYo0PWwMyIboOHek+V2R7b3GUSmdV autTFncMlnDQxky1Dx0r5f3dzmt4BusJ8adkxkZBjU60FQGxSve3/r7MfAq/fQFb18 eYlvLHBXmriqKTncHF0mpyF1m4N3EZQG6v7p8F46z0Eip5rHX+UGN6gOo/6LwvQAcW Zv1JAF3oYGeZw== From: SeongJae Park To: Christoph Hellwig Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] mm/damon: export DAMON symbols and add sample loadable modules Date: Tue, 5 Dec 2023 17:23:07 +0000 Message-Id: <20231205172307.2310-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BCB3580003 X-Stat-Signature: cpwq5zwgh57tbwgnhzg3iynrweddez3q X-Rspam-User: X-HE-Tag: 1701796990-144517 X-HE-Meta: U2FsdGVkX19PJM/cxPHsTcfpf3ROu4meVr/SRvYXi7c+kWHSNUUt5cs5PJm2zham/GQqjPsZilSsWv0FkpEYZaHR31VdqCeCK7LvWx/keN0WaRVOYlSEHu7H/EFZgcSFXdjSTn58DrfG7vF5LFKsxZKpDrMSiug2vkaoMJf8MazRDQXUOUjQ51gDmihvD750yuQMJ5fKHxOLn9yP57kBc9CrbU1pntWPbuljCvSQINE0FuJh+Anip899NBU0ln4kBNCAvoWr3Zw1ml5o160MwP3m75cQuDRoJQmjGc+I1zu/zo/xumKfTEbJSduXaUz8VSoxrwqhmmvsA7U3vDj4X6U63B31Z89323Ow2QFPAa31rzGaUoVXKeKZQMApg5ILl2+zSSEJLtCsPRf5bZrZFDSgPGS6+C4Srpf+cUlkyapeNuttbK1R3Whl56Rzn13knLCrE5FtmTrbZjXxuW7AnywabBeHJ1zaXJFMIUdpR7De/ts5agbp1J71hSxd2rt1g9kxLahQMpQJemBYPdc4sWWnZClxF+3MBS1MOXb6ZQy7BorDqh9k55e/mGCaan6yPkR4Y3SAKcxkracRtn6rOyC4zcmljHOKlw/+Ok+8vFv33WhEsdtG9b3gWmuPHH+fYrSOweyOLrFSHox+MtcBKemQIp5PhaBPdqWU73Qo7WOyC29I6H/JNBsBobtKYks1nPfXsoL6sHYiWRdWkTc6dykRtjwuxoK+T14M26O5F7kIlI0JhdgKQuSapsuMqduYkWuahPPbXk8rS0yZq7Yrq91yU7k20KTRxD2k2aoe5EphR0vZFS8bImIHTo53pyz1dHVoQcIUrsfBBSb8SNFjLanSuNzEc+ZOC9DwydQXYOLCJbieiHFCQTz1oDzfQ+YtTW6K5kuVQXbRfUyu9W0aCfH1bco3mjRV6x3MX2Klw4mK07OMvR4QEm27uPyoWozklWCNyMm5RfRuPKXvMPq 0Dnwl2ke ia2TGTRq7AEmswqP+OaQz1hTQcrYCfHRX5cMjdvhFU+KUKezYvuk/ALuWVWxDzmMJd9XfwSCp6Kk2EHmKeI8Bv3Oy/aEVRIBJhN2hube0iV52C7NNwVe78U2XO3u1Q7ejQU3CB6j4dMJFKTPkb/J6s2MQ8HR+6TcOZCoD6/qhO2qz4ZiGXuvTXR1K94LgRR8E26bPkzeFw3q1Jt9X6cOqkwdzprGJhc2XojyGeIa2PVXjNHI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Christoph, On 2023-12-04T21:12:47-08:00 Christoph Hellwig wrote: > On Tue, Dec 05, 2023 at 02:28:55AM +0000, SeongJae Park wrote: > > DAMON cannot be used from loadable modules since it is not exporting its > > symbols. > > And that is a good thing. We should absolutely not allow random modules > probing MM internals. I agree. > What you posted here is basically just adding hooks without even real > in-kernel users. I was thinking someone might be able to think even the sample module as real usage since there was actually some questions about it from real users. That said, those were more like questions than strong requests, so I still think this change is somewhat better to be made for at least some folks, but I also agree that this wouldn't be not really essential for everyone, and could be only long term maintenance threat. I personally don't have strong opinion, and thank you for raising your concern. I will hold this patchset unless someone request this change again with good rationale. Btw, I know there were many concerns about unnecessarily exporting symbols, but do we have a formal guideline or documentation about the requirements for exporting symbols in sepcific subsystem? I was hoping to have such one so that I could provide better answer to DAMON's loadable module support questions, but I was unable to find such one with my poor searching skill. This reply could be used for the purpose meanwhile, though, so appreciate again. :) Thanks, SJ