From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4544C4167B for ; Wed, 6 Dec 2023 15:17:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 563F66B008A; Wed, 6 Dec 2023 10:17:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4ED1E6B008C; Wed, 6 Dec 2023 10:17:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 366DB6B0092; Wed, 6 Dec 2023 10:17:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 247656B008A for ; Wed, 6 Dec 2023 10:17:56 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F308840125 for ; Wed, 6 Dec 2023 15:17:55 +0000 (UTC) X-FDA: 81536748510.03.87F8C29 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by imf24.hostedemail.com (Postfix) with ESMTP id 5E90B18001F for ; Wed, 6 Dec 2023 15:17:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="ao2cs40/"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf24.hostedemail.com: domain of lkp@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701875874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WMt4EEn3QC7BC4/9x8vsgbviZtpoOf8Ms9pHauXHNWE=; b=YlO6iUm+RX8SxJICfOw9tQbTXHbyjGo167Wv+AF4NSxVVPRX+4rSzqC/OSsyv98/vKZ6B4 vrqknz+dzYIHy/RGz8LIucLOSlMsVl4HKRRwsWLzsdGTaIO/ARs/Zs8XjZ2jSuKLA85Oqj 08Usctpk3AY3JDrAQa7Ihu2xD4jLz4c= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="ao2cs40/"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf24.hostedemail.com: domain of lkp@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701875874; a=rsa-sha256; cv=none; b=I6MdfH3eTwSSt04xq2+60OmetUQfDd0DwnmhVaubV1UijDmxwBU8tpgjIiOIWmES7aOMrO TkrgLo8cLpvAaaB2oLZx114G+1KNTZaIOwlcZQgrYdfra0o4wRHvah67yrkYl4MKIt/a+1 Q59spssHJ7Xm7/p5a2Hjr/e2P8ARXdg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701875873; x=1733411873; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=waumdTvJZcsBL2ArztxFKebgk3BhCdNk/+PYejbqe8M=; b=ao2cs40/0HkvGxHS8G3OCVmI4/WrmEXFx/lygxiJvFI/kkVtjhuCIgHF ZwQrvWdd6a/FfoAeFQIUdbbKcOYfGFYXg+2B6bBuE7qrnwBg/CghEG8dp X+HTZKqBOfG6Pf21TcS51Z03ShzlPMfyG0c+cYd8w/BcP4kIFvWDJXI75 ML2PfhcE9exEDjo/SPpF/pVuz5yksfbYQf1U+dVFlTif7cfCRngEC2Hvx rgXKgnCfyPDIt7QAZt/rLPhUuKiREReS4QlmcOEi1Wgot0AGmE4j2i0uQ D/nn9oWzEAW5QJ78vtx+fRDlotCBlEW+LfhExREGDetM+YM80o9XIylQ/ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="374253688" X-IronPort-AV: E=Sophos;i="6.04,255,1695711600"; d="scan'208";a="374253688" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2023 07:17:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="805669853" X-IronPort-AV: E=Sophos;i="6.04,255,1695711600"; d="scan'208";a="805669853" Received: from lkp-server02.sh.intel.com (HELO b07ab15da5fe) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 06 Dec 2023 07:17:48 -0800 Received: from kbuild by b07ab15da5fe with local (Exim 4.96) (envelope-from ) id 1rAtek-000Azq-2D; Wed, 06 Dec 2023 15:17:46 +0000 Date: Wed, 6 Dec 2023 23:17:02 +0800 From: kernel test robot To: Stefan Roesch , kernel-team@fb.com Cc: oe-kbuild-all@lists.linux.dev, shr@devkernel.io, akpm@linux-foundation.org, david@redhat.com, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 1/4] mm/ksm: add ksm advisor Message-ID: <202312062353.lBYSA7Eb-lkp@intel.com> References: <20231204234906.1237478-2-shr@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231204234906.1237478-2-shr@devkernel.io> X-Rspam-User: X-Stat-Signature: np4xzyfc1a6gmhktj1ix4upf6f9zxddi X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5E90B18001F X-HE-Tag: 1701875873-95896 X-HE-Meta: U2FsdGVkX1/d5KigBhfZ5Y7oqU8Dtd3l41feJusKHV+ba/Y3Izs4ig83sEKhAYvwJRknKIo0MuV9kqyFGrujYVwZhmoSV23lY7+ArvRH56VMr4nOGMM6mgadrwjIbWEVhuvXtYMYnqoRlS8KiZDbvalvl/IiY+PxP4fym53Wtrt/76dJ37mrLKpLZYF/7T1/vxjMreU9/knPEftuRDg4EBVFOvgwoKNCol4WSvzlCX6b/oO6KfCmqE0pO5VyjPYKgME/NYuy0N4Uu4mLxmkL/OGXivyOcoTWJTULCrY/4R+4yTDYUI+eYWVZrTNLhx9xMNG6I60R6p89m3XSLXQZfEUlVLqpZCbdxi2Xu7niGx6o/Ez1PuV2fVOTgjUkHUFPGWxeyiqMpnWBwdRwThjOi0OMGUDWdm9ALaWh2QaApMlSn+M68q53Jt1V7AUhTrSc2uj/9j3YVIfREYEiyzjElpXAPJfM0UgPvkpi2/H1ILvQQwDnaq0On+FswMXQ2i0f+bZ82tF0qdehero6/J+2VvlUCfEKJFDB1jVW/mHGFk5SmJeQZofKdGvmHH36EQ8D1RNj+sP2fGxjQqTIZqhFfNVJ1pqy4qUm2RwUt3KstS3xiQcMOzqdG6Jf+z3nWuVxfZR3eJQxfuqS9VHUffRnWKJ5XYne38Xrzx+oXPhA16zImL1dIBzpMdee71s/24SRcdnI68sGxaCVT1v8SUCobXCMYP2OeTdB+RCVuATwOyxd89WinSF0kTNJtTognOTqKLmQhY5apGvAoUr9l//YWX9Gd1aoz6VwDcD3y+wSnjkKi1VkkKjBZ9bF7x9hlpq0PElk+T3vFcfl4rJKQ6ipn2z/Q4v+hd6nvLJ8e6oH8WkCpeT8Txi+DRlSSrF7iGUJGT42GgF/t60NGJjcfecofw/MFiasjQ7up4FSMHvcKHJ4g3YblSVg1BdREDfTZ83HlJ+ZJAf8xAeC8SFDUZZ laWS1jFQ 9GVuGGqfdkOahErvMOkowQwfDxG/ZJywffAU5gE//vYmiyCngqtip09dKLcuV9qiNojPb4o/ZIK1SsGe02KgtqfpG9I8oxM3GTQY3vEMCOumczehtVLqgnt44nf8VhOOJ2WoPyjoCSXCE14p7/YhBZva3Fpy7mcaNi7SksS6LQ6fTSe6n0emi7soo754pja4s1uQxeXqIvXRM2l4alac/ZFw6ke/FgBVBtUV1lflYx7RSjW4vUjQLGgOUdCdZi1azR/UBPH9VCE7WDbBvCcXj6t1dTlOm/clIl4SjRvDx9IdVu/0uJflGyAXQpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Stefan, kernel test robot noticed the following build errors: [auto build test ERROR on 12d04a7bf0da67321229d2bc8b1a7074d65415a9] url: https://github.com/intel-lab-lkp/linux/commits/Stefan-Roesch/mm-ksm-add-ksm-advisor/20231205-075118 base: 12d04a7bf0da67321229d2bc8b1a7074d65415a9 patch link: https://lore.kernel.org/r/20231204234906.1237478-2-shr%40devkernel.io patch subject: [PATCH v3 1/4] mm/ksm: add ksm advisor config: i386-randconfig-011-20231206 (https://download.01.org/0day-ci/archive/20231206/202312062353.lBYSA7Eb-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231206/202312062353.lBYSA7Eb-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202312062353.lBYSA7Eb-lkp@intel.com/ All errors (new ones prefixed by >>): ld: mm/ksm.o: in function `scan_time_advisor': >> mm/ksm.c:423: undefined reference to `__divdi3' >> ld: mm/ksm.c:435: undefined reference to `__divdi3' ld: mm/ksm.c:428: undefined reference to `__divdi3' vim +423 mm/ksm.c 383 384 /* 385 * The scan time advisor is based on the current scan rate and the target 386 * scan rate. 387 * 388 * new_pages_to_scan = pages_to_scan * (scan_time / target_scan_time) 389 * 390 * To avoid pertubations it calculates a change factor of previous changes. 391 * A new change factor is calculated for each iteration and it uses an 392 * exponentially weighted moving average. The new pages_to_scan value is 393 * multiplied with that change factor: 394 * 395 * new_pages_to_scan *= change facor 396 * 397 * In addition the new pages_to_scan value is capped by the max and min 398 * limits. 399 */ 400 static void scan_time_advisor(void) 401 { 402 unsigned int cpu_percent; 403 unsigned long cpu_time; 404 unsigned long cpu_time_diff; 405 unsigned long cpu_time_diff_ms; 406 unsigned long pages; 407 unsigned long per_page_cost; 408 unsigned long factor; 409 unsigned long change; 410 unsigned long last_scan_time; 411 s64 scan_time; 412 413 /* Convert scan time to seconds */ 414 scan_time = advisor_stop_scan(); 415 scan_time = div_s64(scan_time, MSEC_PER_SEC); 416 scan_time = scan_time ? scan_time : 1; 417 418 /* Calculate CPU consumption of ksmd background thread */ 419 cpu_time = task_sched_runtime(current); 420 cpu_time_diff = cpu_time - advisor_ctx.cpu_time; 421 cpu_time_diff_ms = cpu_time_diff / 1000 / 1000; 422 > 423 cpu_percent = (cpu_time_diff_ms * 100) / (scan_time * 1000); 424 cpu_percent = cpu_percent ? cpu_percent : 1; 425 last_scan_time = prev_scan_time(&advisor_ctx, scan_time); 426 427 /* Calculate scan time as percentage of target scan time */ 428 factor = ksm_advisor_target_scan_time * 100 / scan_time; 429 factor = factor ? factor : 1; 430 431 /* 432 * Calculate scan time as percentage of last scan time and use 433 * exponentially weighted average to smooth it 434 */ > 435 change = scan_time * 100 / last_scan_time; 436 change = change ? change : 1; 437 change = ewma(advisor_ctx.change, change); 438 439 /* Calculate new scan rate based on target scan rate. */ 440 pages = ksm_thread_pages_to_scan * 100 / factor; 441 /* Update pages_to_scan by weighted change percentage. */ 442 pages = pages * change / 100; 443 444 /* Cap new pages_to_scan value */ 445 per_page_cost = ksm_thread_pages_to_scan / cpu_percent; 446 per_page_cost = per_page_cost ? per_page_cost : 1; 447 448 pages = min(pages, per_page_cost * ksm_advisor_max_cpu); 449 pages = max(pages, per_page_cost * ksm_advisor_min_cpu); 450 pages = min(pages, ksm_advisor_max_pages); 451 452 /* Update advisor context */ 453 advisor_ctx.change = change; 454 advisor_ctx.scan_time = scan_time; 455 advisor_ctx.cpu_time = cpu_time; 456 457 ksm_thread_pages_to_scan = pages; 458 } 459 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki