Re: [PATCH v1 11/39] mm/userfaultfd: page_add_file_rmap() -> folio_add_file_rmap_pte()

Ryan Roberts
2023-12-18T15:59:50Z

On 11/12/2023 15:56, David Hildenbrand wrote:
> Let's convert mfill_atomic_install_pte().
>
> Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>

> ---
> mm/userfaultfd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
> index 9ec814e47e99..330a481a1654 100644
> --- a/mm/userfaultfd.c
> +++ b/mm/userfaultfd.c
> @@ -114,7 +114,7 @@ int mfill_atomic_install_pte(pmd_t *dst_pmd,
> /* Usually, cache pages are already added to LRU */
> if (newly_allocated)
> folio_add_lru(folio);
> - page_add_file_rmap(page, dst_vma, false);
> + folio_add_file_rmap_pte(folio, page, dst_vma);
> } else {
> page_add_new_anon_rmap(page, dst_vma, dst_addr);
> folio_add_lru_vma(folio, dst_vma);