From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B54C46CD2 for ; Tue, 2 Jan 2024 13:13:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDF688D000B; Tue, 2 Jan 2024 08:13:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E90258D0006; Tue, 2 Jan 2024 08:13:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2F908D000B; Tue, 2 Jan 2024 08:13:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BCF3B8D0006 for ; Tue, 2 Jan 2024 08:13:31 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9249BA1A74 for ; Tue, 2 Jan 2024 13:13:31 +0000 (UTC) X-FDA: 81634412622.02.2ADDFB0 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf18.hostedemail.com (Postfix) with ESMTP id DFA4B1C0002 for ; Tue, 2 Jan 2024 13:13:29 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Eko96B8O; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf18.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704201210; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0BwxzTkbv6fMj2IlVqqVSI+5ecpQCg7jHconULcXMhU=; b=U+CSIMf7fEKDINQeiNCfoJLbbR7OUprizI0xrfjO9TcSumNR9ehMEAwEgtk5fyXe4RqfcA xm5OD1QpB9A+cEs0ZVRcts8bT4OSMbBz9duVUyOoZ3b+7xNjjBSUaVrQzQninXYV9VTSaZ YMn0eFxEHiIfoIXjvKhdErUYOXJl4oA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Eko96B8O; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf18.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704201210; a=rsa-sha256; cv=none; b=gTes3Won4SELHSCGXBJhgfCygE1dBFPKbRcRC0hBmzKYG2o1YYOiHKP+3JVi0t4bE5Zjuv BtFS6Tk0qld/AH8+izLlK3yCAo5cRpRYsq0cRp2v8gv3SwgBjhoz8fsOkcvtY3eznDZl4x HLp1IkL5Zbp03V6CCgqwuwoePdsuKHI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704201208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0BwxzTkbv6fMj2IlVqqVSI+5ecpQCg7jHconULcXMhU=; b=Eko96B8OaBJVKkDyhD/UM2q4AYrrNykiYUCYNcfOZ1A32BsBy/zQcEdL/Y94CQ0FhNyARP ty7rzZ3ZddQ0yUhcxHQr6aLFHRTzuQy4e+fg9Mn0btG4rccV9gwgX3Wz1I1oA73vy9Mlfb eNChOv/zhRPqCB0SpDniNhAQ6XPQGOE= From: Gang Li To: David Hildenbrand , David Rientjes , Mike Kravetz , Muchun Song , Andrew Morton , Tim Chen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com, Gang Li Subject: [PATCH v3 3/7] padata: dispatch works on different nodes Date: Tue, 2 Jan 2024 21:12:45 +0800 Message-Id: <20240102131249.76622-4-gang.li@linux.dev> In-Reply-To: <20240102131249.76622-1-gang.li@linux.dev> References: <20240102131249.76622-1-gang.li@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: nsd4dp4xf7n118ar41yxsyofh8ekfqi5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DFA4B1C0002 X-HE-Tag: 1704201209-83537 X-HE-Meta: U2FsdGVkX19j4dLxhD39PmGMJZIP9l9IkLiFUnwpxxhk1Y/J8HIZoFV8vrRDmVi5GUUp+2o2t3TZbST+rDClrCHI+P0+QJSatsiQG/2PHQkoYoXUQrZuqIZDxbqpX12NR7iZxe2r+H5cJ2rhzL94isC1UPxF7CU4eeSegUz76CrBEhXh0cWTXtXiAvXgyqthfNhMDQzULAV2faPz2pqk7U7mDUW4dtsqBJYxaX9Nj1c2YVZdzl2UKJEVchVdVthEK2F22WAxefFIYksXhxmAueqUhuIN3djbhnSSFw79DNERfd4jiTp9/OLT2hDAcC95hjTLAPo8wynvaIycjH9uPW0gCgEaMXOE9dKVgvilc9qj6nb4sIftqGzTbLQV3G5+MvG+uksghY1D8CCUCz4U9SV3nUk0nhJ1CrcYSGNtveJe6Q2gz7zR6svUrgUKco/alJUo3d9rBVgGM0Ssgy3oz13+/HWCfpODLDWenvMG04w+pc4C9axJJY+FLTLaaWB0k10x4/KxdgtMrCtRziIR1Ck9PG52M0Gj0opa4zYbyy2iGmuWa6v8HkfX+PsBY8HuEYCTEeocZUtrWvSkf245n4k/zXgC4CVirPt58+GqxSVnWFPVXhFEdhSJL6zQrI9RO9ku6UVDrsqghxIfRutn3xIn71UP0iVLd4z2ZjuAzqZmdiG34/D+Bgh0Xi30gqjfUL2sGAylCd3P5Caf5IIlszAkomTWOEAMg8KucjbHp2hz7CKMlQuVt/dC2W6mOvGEeW1DYZx8CKMAeV23Xe+MlaGp2OtAcJI4+Ty8YaWiUSW79SKVNCXy56sEwJkJCC1J69zg7PhdPfj1CQA0k5IBtujDYKwT8K55YLVS2FCVcLgtStVpisfCgmtbx827YtibPGhcTOI6UswWlxhf8qj4ck29QbYSuibFgrGZkJS3pirJjdOa8wwrPdiaNSI/CFQWxIZSe1WqFRSngVr4Pyg U8LabSsS 856CbQEoEjYTE2Hx0NcoNDqr2VWgQhtBqG2Muu7b2pNsUzYAzt+IPs5EAAK7ZDBc2oJiizzKqnafeGzQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When a group of tasks that access different nodes are scheduled on the same node, they may encounter bandwidth bottlenecks and access latency. Thus, numa_aware flag is introduced here, allowing tasks to be distributed across different nodes to fully utilize the advantage of multi-node systems. Signed-off-by: Gang Li --- include/linux/padata.h | 3 +++ kernel/padata.c | 8 ++++++-- mm/mm_init.c | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/include/linux/padata.h b/include/linux/padata.h index 495b16b6b4d72..f79ccd50e7f40 100644 --- a/include/linux/padata.h +++ b/include/linux/padata.h @@ -137,6 +137,8 @@ struct padata_shell { * appropriate for one worker thread to do at once. * @max_threads: Max threads to use for the job, actual number may be less * depending on task size and minimum chunk size. + * @numa_aware: Dispatch jobs to different nodes. If a node only has memory but + * no CPU, dispatch its jobs to a random CPU. */ struct padata_mt_job { void (*thread_fn)(unsigned long start, unsigned long end, void *arg); @@ -146,6 +148,7 @@ struct padata_mt_job { unsigned long align; unsigned long min_chunk; int max_threads; + bool numa_aware; }; /** diff --git a/kernel/padata.c b/kernel/padata.c index 179fb1518070c..1c2b3a337479e 100644 --- a/kernel/padata.c +++ b/kernel/padata.c @@ -485,7 +485,7 @@ void __init padata_do_multithreaded(struct padata_mt_job *job) struct padata_work my_work, *pw; struct padata_mt_job_state ps; LIST_HEAD(works); - int nworks; + int nworks, nid = 0; if (job->size == 0) return; @@ -517,7 +517,11 @@ void __init padata_do_multithreaded(struct padata_mt_job *job) ps.chunk_size = roundup(ps.chunk_size, job->align); list_for_each_entry(pw, &works, pw_list) - queue_work(system_unbound_wq, &pw->pw_work); + if (job->numa_aware) + queue_work_node((++nid % num_node_state(N_MEMORY)), + system_unbound_wq, &pw->pw_work); + else + queue_work(system_unbound_wq, &pw->pw_work); /* Use the current thread, which saves starting a workqueue worker. */ padata_work_init(&my_work, padata_mt_helper, &ps, PADATA_WORK_ONSTACK); diff --git a/mm/mm_init.c b/mm/mm_init.c index 89dc29f1e6c6f..59fcffddf65a3 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -2225,6 +2225,7 @@ static int __init deferred_init_memmap(void *data) .align = PAGES_PER_SECTION, .min_chunk = PAGES_PER_SECTION, .max_threads = max_threads, + .numa_aware = false, }; padata_do_multithreaded(&job); -- 2.20.1