From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5397C4707B for ; Fri, 5 Jan 2024 18:30:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 012E16B0246; Fri, 5 Jan 2024 13:30:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F228A6B025F; Fri, 5 Jan 2024 13:30:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEA176B026A; Fri, 5 Jan 2024 13:30:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CE6B26B0258 for ; Fri, 5 Jan 2024 13:30:44 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E496940AEA for ; Fri, 5 Jan 2024 18:30:43 +0000 (UTC) X-FDA: 81646098366.02.AA83E5D Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf14.hostedemail.com (Postfix) with ESMTP id F2DB1100013 for ; Fri, 5 Jan 2024 18:30:41 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=J8HpHhMc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of mhkelley58@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=mhkelley58@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704479442; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3sjtnuQv0aW8e3tX/O8I3CPvFIKJ9WnNTakGmnE/PQ4=; b=m/kWvQs1eFB1xaB/TMYW4XfWnSbZu3gjVNfnGHt6ENk9biITg2Pij3/wT4rmdCND+cgyFh O13AsnKXAbCnYvg70Fv7jiYK4J7bTKOCrxvj937DeDm/ZIY+6PGapv28Bq8xsjteciosXb 4YdKJFgCBjzv6mXM8ndXYEgvR2D8bs8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=J8HpHhMc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of mhkelley58@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=mhkelley58@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704479442; a=rsa-sha256; cv=none; b=T/Aw77/6fm7CLCDZAuPQBMVzyJFc1s9iUu2FUacOMF806wMCFvEGWkiZ6aMgoWB16bqDlg rLDHnm3BYqzpNVDS+zCrmmtccYH3hCMvPXHxUQj+qJtrrs2/998DChTGi8nwyZKJIoOjKX YaXG0SsDk/YOB2LXeAfZp02R3nNIAt0= Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5ce2aada130so1111745a12.1 for ; Fri, 05 Jan 2024 10:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704479441; x=1705084241; darn=kvack.org; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3sjtnuQv0aW8e3tX/O8I3CPvFIKJ9WnNTakGmnE/PQ4=; b=J8HpHhMcpAYDn74MlcwHuBJzMLKfKAUHGPrPLnYQuUDk23xoXjrtlLs9ODDc6ByqJv G08JeWmHNt67ufVhstpwpOwSeiI9nGDmuNMuOx/HDV//hErskx6VKp2D5eVLzzlSZXOu MMMdW1P7hrlHxyQGqsV698lScvkQvLeezcq+Duwuk8MtxjpFU0fulYC3ZXg/Czrj1Xcz eCNVSY1zRhhoG2v1UrNjggU62uFOrK+q6sKAxIGPPU4lfPO+fA98IEK12M4jtJh/Lbtx N/AswrZqPI1BiF0Qw620N9/FmxL+EaQpfdxl/3yBdjJhViM0/zX8I6UcJoAwybf+BsoY OTbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704479441; x=1705084241; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3sjtnuQv0aW8e3tX/O8I3CPvFIKJ9WnNTakGmnE/PQ4=; b=NrrrXIhhyyXjYvd9kMHPoHhPYrX08B1gZUnRPd+PHH5XjvmBE1L48HRk7JWwAnoDGh qbB7Od/HUynaoa2ik7EhK4yfepfGIrKkY2TXo/lTjUUvOzWTKNmnayc5gi/tPta2wnXF g7Ymh65EiOGPtXbVeI30AC3qZlx7mfqR3H0NjE7Q3YGAz4TgovSrMdaQC4GL0AfRrK7E 0Di6zPBIoaWl2NHv7iU1enWpAyjz3f8H+fif2CV2EvVX6dsR12zCwRGaYJOFtt+kXLD4 2IXLR+VaQPrF30tNMdvjbn+IMhPOpTZh/Cz+U5kAVFrlPUYz//MiTpfbV8/HY9Aujekk cRAA== X-Gm-Message-State: AOJu0YzTrgQf3YO3CkqkQOSqMYDI1wioRcOSISLMg3gDSVhNxooHyM8i kmzRRpNJPmkm1JIT5Pfep3A= X-Google-Smtp-Source: AGHT+IGZaFoZdBTf7Hf3s9plZg+SJexjwJwB03dmWIM7+favexb3cAjsi05kOu2bP0EG5HtVpfK9Dg== X-Received: by 2002:a17:90b:1d0d:b0:28c:4a67:eb7d with SMTP id on13-20020a17090b1d0d00b0028c4a67eb7dmr2069534pjb.48.1704479440839; Fri, 05 Jan 2024 10:30:40 -0800 (PST) Received: from localhost.localdomain (c-73-254-87-52.hsd1.wa.comcast.net. [73.254.87.52]) by smtp.gmail.com with ESMTPSA id 23-20020a17090a195700b002868abc0e6dsm1687293pjh.11.2024.01.05.10.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 10:30:40 -0800 (PST) From: mhkelley58@gmail.com X-Google-Original-From: mhklinux@outlook.com To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, kirill.shutemov@linux.intel.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, luto@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, thomas.lendacky@amd.com, ardb@kernel.org, jroedel@suse.de, seanjc@google.com, rick.p.edgecombe@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v3 1/3] x86/hyperv: Use slow_virt_to_phys() in page transition hypervisor callback Date: Fri, 5 Jan 2024 10:30:23 -0800 Message-Id: <20240105183025.225972-2-mhklinux@outlook.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240105183025.225972-1-mhklinux@outlook.com> References: <20240105183025.225972-1-mhklinux@outlook.com> Reply-To: mhklinux@outlook.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: F2DB1100013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: g954racdtra13aa8tai3tdn9zrt5tqiw X-HE-Tag: 1704479441-184957 X-HE-Meta: U2FsdGVkX19hnoRmIrnaUfUuKRjLDHS1wXa9Uoj+8eZqUSv+GhPX58Q8ZtR1YUNEY30GTNhkT3chC4zdCG9LNnYCNq1uMW6yA/CRkDghQLY5WLlVGOMB+M4WlQSXLWl+jY9oOz+NmUqTgKTqj3lr5P9LqnSAoVdFWQoD5a4APZ8ggRwJbP7gcKUo9JM+o4RUKlIgWUiei7cmBI188Jlj7FQdWOo7FymOCUsCUmZXWSDm2xjA47QpMmU8vX1UI8FuzN9Nb2eYcGdHRPnTJrU60Mbi7Pd2RDMN4YDmy8ZxhIMPA/DP7LxyJHSbR91bQDSDxmqasrLurpYdgFMWy14zrD/2P19HclMWlGTxAsbLHbwwOBT3khFDgKsMSnpMbgUROqkJoRjH7pxdOyzLvD1ZqY4HlgsqvsPVnMM5hpfWp1GdB958SEJTB8qMTO4BQVFFGcV928vvbk/2DTsetHRdG+djbBLAJXVBKwuH4JqO0E7V4oqlSXGTM34tSwtJjZVKBeDVXs4ta6HyaZjALx5WircQAAU3JiQtOOfd9BFUgQpQF/juGnPUTluHvlr9mXIdY1jvSz9QMGqzE3EgaCc98glIPn3l65kmsc9m/QK2Ujg+tJgG73xOkd19vQsv3w4s6P46B6fUVvARMc5CHpOoMGGdSxzYfmw03sbYMQKCfEGbvMEVWMqPszx2SGMZHq+Tg8eA8a2WtmAevBnwEOp5WUIFPkEpgsTj/66+GpDOjBlGRvY+AMgpflwFNdxtotbPRlRt+OvDCNk/FLoNq5MqHQVIyQT9glRLzxUdtLRWgebtzXsZId6kE3DcjvL+A/gvfWKaK69tWEfTsXV73HF/IrgRiwf3qIETwNkYrFV9O/oDNhPVpQYhVzNpzPf7cVdqdAHwWWodjCiYPvi656B7XjanPmQCXkSi6OaimkEKGWY+cDsPhAW2HM2jOtG+rZRbL5Owzn4BYTb91psyhXN Od4EYy05 tKGCRJ0wCk3csXPK4FvCJ4oQPim58jVd1SrdpidLD3BPb1qH2MChOdfC3TPH+68RHq7YFKCexJmqChvAdwVNddTpjFHfsCB+B1MQkD/RU36c88Dp0Gh2IQ9CznZBg3YvDcSeUnAJK6fMvgLjnaktPpPl+fEZ1bvnCpYKuaTSCyrgx6GRbD5Vu4Prhb0kMd7rVjFaMLbQa/GmD+Ed0kYnBsL/cDPAAPJ/u4VRMixyLPKebl8t69jcuYdvdZjHWPNIbABgOso5F8WR5YZs5jadwYU+OPSE3pPKFlGij69PtOPHB/shQ6w2GicLq/iaS4o1xhW43OZ28h5Kyel350ewAeTTy/LFRbJEwbpn7f6Pm9UaA2hDn1Cun2uLs5C3C7+zx7uBouSySMGt4Xd943BeQDcfDj8XzykcOl5cvydz4oO6+C+n4l/t0Ty7+678sBRztIHEr2q0IcO776/0wvcdCG4bOGddcpYiQUu/FeNspOr+M9gM7aUuls8QEi4ToIbVASbnuMmV9uqn4IWI6u6QzsKB3Qg842MK9G+40pP69BLd9X84oQB/8G7bsivFeYdhP/A3OOszwQcBPX2LcJkO64vVuuhXQV9Ew14yebBqCJTNkUQr5uL+Sl2+DNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Michael Kelley In preparation for temporarily marking pages not present during a transition between encrypted and decrypted, use slow_virt_to_phys() in the hypervisor callback. As long as the PFN is correct, slow_virt_to_phys() works even if the leaf PTE is not present. The existing functions that depend on vmalloc_to_page() all require that the leaf PTE be marked present, so they don't work. Update the comments for slow_virt_to_phys() to note this broader usage and the requirement to work even if the PTE is not marked present. Signed-off-by: Michael Kelley --- arch/x86/hyperv/ivm.c | 9 ++++++++- arch/x86/mm/pat/set_memory.c | 13 +++++++++---- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c index 02e55237d919..8ba18635e338 100644 --- a/arch/x86/hyperv/ivm.c +++ b/arch/x86/hyperv/ivm.c @@ -524,7 +524,14 @@ static bool hv_vtom_set_host_visibility(unsigned long kbuffer, int pagecount, bo return false; for (i = 0, pfn = 0; i < pagecount; i++) { - pfn_array[pfn] = virt_to_hvpfn((void *)kbuffer + i * HV_HYP_PAGE_SIZE); + /* + * Use slow_virt_to_phys() because the PRESENT bit has been + * temporarily cleared in the PTEs. slow_virt_to_phys() works + * without the PRESENT bit while virt_to_hvpfn() or similar + * does not. + */ + pfn_array[pfn] = slow_virt_to_phys((void *)kbuffer + + i * HV_HYP_PAGE_SIZE) >> HV_HYP_PAGE_SHIFT; pfn++; if (pfn == HV_MAX_MODIFY_GPA_REP_COUNT || i == pagecount - 1) { diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c index bda9f129835e..8e19796e7ce5 100644 --- a/arch/x86/mm/pat/set_memory.c +++ b/arch/x86/mm/pat/set_memory.c @@ -755,10 +755,15 @@ pmd_t *lookup_pmd_address(unsigned long address) * areas on 32-bit NUMA systems. The percpu areas can * end up in this kind of memory, for instance. * - * This could be optimized, but it is only intended to be - * used at initialization time, and keeping it - * unoptimized should increase the testing coverage for - * the more obscure platforms. + * It is also used in callbacks for CoCo VM page transitions between private + * and shared because it works when the PRESENT bit is not set in the leaf + * PTE. In such cases, the state of the PTEs, including the PFN, is otherwise + * known to be valid, so the returned physical address is correct. The similar + * function vmalloc_to_pfn() can't be used because it requires the PRESENT bit. + * + * This could be optimized, but it is only used in paths that are not perf + * sensitive, and keeping it unoptimized should increase the testing coverage + * for the more obscure platforms. */ phys_addr_t slow_virt_to_phys(void *__virt_addr) { -- 2.25.1