From: Eric Mackay <eric.mackay@oracle.com>
To: linux@armlinux.org.uk
Cc: Jonathan.Cameron@huawei.com, Matteo.Carlini@arm.com,
Valentin.Schneider@arm.com, akpm@linux-foundation.org,
anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@linux.com,
dave.kleikamp@oracle.com, eric.mackay@oracle.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
robin.murphy@arm.com, vanshikonda@os.amperecomputing.com,
yang@os.amperecomputing.com
Subject: Re: [PATCH] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512
Date: Tue, 16 Jan 2024 13:06:44 -0800 [thread overview]
Message-ID: <20240116210644.116421-1-eric.mackay@oracle.com> (raw)
In-Reply-To: <ZaZnYrv/QThRjW2Q@shell.armlinux.org.uk>
On Tue, Jan 16, 2024 11:24:18PM +0000, Russell King (Oracle) wrote:
> On Mon, Jan 15, 2024 at 03:59:11PM -0800, Eric Mackay wrote:
> > Whitespace issues aside, I have applied the patch on top of kernel 6.1.55 and tested on both a dual-socket Ampere Altra machine with < 256 CPUs, and a dual-socket AmpereOne machine with > 256 CPUs. Works as expected, with all CPUs visible and functional.
> >
> > > config NR_CPUS
> > > int "Maximum number of CPUs (2-4096)"
> > > range 2 4096
> > > - default "256"
> > > + default 512
> >
> > Nit: the new default value should be in quotation marks, if we want to be pedantic
>
> I can't find anything that requires the quotes - and as "range" doesn't
> for consistency it seems that default shouldn't either. There's nothing
> in the documentation that indicates quotes should be used, and looking
> at the code, it's just treated as a string. The only thing that quotes
> seem to do is to ensure that whitespace will be included.
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Ack. I withdraw my nit.
next prev parent reply other threads:[~2024-01-16 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 0:05 [PATCH] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512 Christoph Lameter (Ampere)
2024-01-15 15:39 ` Russell King (Oracle)
2024-01-16 7:10 ` Kefeng Wang
2024-01-16 9:28 ` Russell King (Oracle)
2024-01-16 13:08 ` Mark Rutland
2024-01-16 21:06 ` Eric Mackay
2024-01-17 19:59 ` Christoph Lameter (Ampere)
2024-01-15 23:59 ` Eric Mackay
2024-01-16 11:24 ` Russell King (Oracle)
2024-01-16 21:06 ` Eric Mackay [this message]
2024-01-17 20:01 ` Christoph Lameter (Ampere)
2024-01-18 17:53 ` Eric Mackay
2024-01-23 23:55 ` [PATCH v2] " Christoph Lameter (Ampere)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116210644.116421-1-eric.mackay@oracle.com \
--to=eric.mackay@oracle.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Matteo.Carlini@arm.com \
--cc=Valentin.Schneider@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=dave.kleikamp@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=robin.murphy@arm.com \
--cc=vanshikonda@os.amperecomputing.com \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).