From: Chengming Zhou <zhouchengming@bytedance.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Vlastimil Babka <vbabka@suse.cz>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org,
Chengming Zhou <zhouchengming@bytedance.com>,
linux-mm@kvack.org, "Christoph Lameter (Ampere)" <cl@linux.com>
Subject: [PATCH v2 2/3] mm/slub: remove full list manipulation for non-debug slab
Date: Tue, 23 Jan 2024 09:33:30 +0000 [thread overview]
Message-ID: <20240117-slab-misc-v2-2-81766907896e@bytedance.com> (raw)
In-Reply-To: <20240117-slab-misc-v2-0-81766907896e@bytedance.com>
Since debug slab is processed by free_to_partial_list(), and only debug
slab which has SLAB_STORE_USER flag would care about the full list, we
can remove these unrelated full list manipulations from __slab_free().
Acked-by: Christoph Lameter (Ampere) <cl@linux.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
mm/slub.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index fda402b2d649..5c6fbeef05a8 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -4188,7 +4188,6 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab,
* then add it.
*/
if (!kmem_cache_has_cpu_partial(s) && unlikely(!prior)) {
- remove_full(s, n, slab);
add_partial(n, slab, DEACTIVATE_TO_TAIL);
stat(s, FREE_ADD_PARTIAL);
}
@@ -4202,9 +4201,6 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab,
*/
remove_partial(n, slab);
stat(s, FREE_REMOVE_PARTIAL);
- } else {
- /* Slab must be on the full list */
- remove_full(s, n, slab);
}
spin_unlock_irqrestore(&n->list_lock, flags);
--
b4 0.10.1
next prev parent reply other threads:[~2024-01-23 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 9:33 [PATCH v2 0/3] mm/slub: some minor optimization and cleanup Chengming Zhou
2024-01-23 9:33 ` [PATCH v2 1/3] mm/slub: directly load freelist from cpu partial slab in the likely case Chengming Zhou
2024-01-23 10:45 ` Vlastimil Babka
2024-01-23 9:33 ` Chengming Zhou [this message]
2024-01-23 9:33 ` [PATCH v2 3/3] mm/slub: remove unused parameter in next_freelist_entry() Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240117-slab-misc-v2-2-81766907896e@bytedance.com \
--to=zhouchengming@bytedance.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).