From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01D27C4707B for ; Thu, 18 Jan 2024 12:39:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78E866B007B; Thu, 18 Jan 2024 07:39:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73D766B007E; Thu, 18 Jan 2024 07:39:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 605286B0082; Thu, 18 Jan 2024 07:39:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4D6836B007B for ; Thu, 18 Jan 2024 07:39:25 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 194F612031D for ; Thu, 18 Jan 2024 12:39:25 +0000 (UTC) X-FDA: 81692387490.06.43176EE Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) by imf30.hostedemail.com (Postfix) with ESMTP id 4674680011 for ; Thu, 18 Jan 2024 12:39:22 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=U90JDt6u; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705581562; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=mt7uxPpjB752dElB/c3PRb1FTXGnRTlS8CZOndsR1VE=; b=EIz04uTNPO86R5knDq0nDaBhH30eeXVWDz+RzZD+YDrvDni3cIiVUcMOCcGkf1dbr1OWk/ jrEzadRQmD0NBMcwACsMsdK7RQ7yI0M0DCtH0PmxEIgB2XKquga9yrV9l0yGFEI+3IMD+D 9EuLgtD3zQHrIi+xCLE4ElIcAdtjrwk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=U90JDt6u; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705581562; a=rsa-sha256; cv=none; b=o2gupdEN2n6mWhI0GZNEb4ITeSB3bhyRdxNqnrXho9fSxACvB8OjKI+AOkLNO4YIbZZgV6 Aj8FbfN7xXEtmSFcrj/ktRFiz/tlJTjQ8PavoXZKJaScOgXbqdvYsdlk86Hj0rpF4PZrbX RlLlBgIb2Mwb5cq7EOi6UmBaMenohns= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705581560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mt7uxPpjB752dElB/c3PRb1FTXGnRTlS8CZOndsR1VE=; b=U90JDt6ucUwcrDktw242XqJWfIO/nYOyVq/b3qXuPddYIIP2Lh2AZhHzkoMomBPDQxqr0K 2ofMqd9Y0luwEz6RLuSjEs67WXf9rmwzE7wCBqMaSgpbGS9WFFWkzGCM2zdZ31uqhx0HJn vgw+XVn9ExdETDheQciWjv2wvDsWoS8= From: Gang Li To: David Hildenbrand , David Rientjes , Mike Kravetz , Muchun Song , Andrew Morton , Tim Chen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com, Gang Li Subject: [RESEND PATCH v4 0/7] hugetlb: parallelize hugetlb page init on boot Date: Thu, 18 Jan 2024 20:39:04 +0800 Message-Id: <20240118123911.88833-1-gang.li@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4674680011 X-Stat-Signature: ugucjx3yxa9echjupg34479yuxiimcde X-HE-Tag: 1705581562-364089 X-HE-Meta: U2FsdGVkX18vcjByace6+w1l/PYdzTqb5xPJZbsDczj8fb1ODyBnLqLIYouu9euwJVTiw8mg3F3zVRD1LzURea8vIGlhR8AzYIVdGANFyMJ8UkghlQEysovq8838TVhkWfKEyBkEmPCMugvToamcqtf96fzqZ0NJHXvenlrvEoApoKeArWY7ONoF73sJxyi0V6gNcIgrB5n5xrlyVQcId0VzEcF9aLmy55NhKFV9PSgvcgHwQfPu6Na/FloFohVAK2acO/PLzYGAj08e1w1WmmjKfT9JwogPY+FIWLTWI7x4KORfpqHn+JAt031wx1APN4PrXdEImz/y8PE7VlvqdZWw0Y9LQXWSShLnGVKkqbWDhFCL7C7xtAIwmFjjklqmbznwGklBbgotnPpci52Ef7KcMqhROhe+uFDIFrVMMOIJ7wtEaMn7yaCd7Nsaddc6GEybBcP1M8y6KCgQ68XTOzzILfLhpwxe0BcS9ogVDGTj+vTAw6n+eHBD29gY6L0f9kvpquOkY1ucjp4fERcquPgrctaz78GBU3FE3iwLsky94uutzDh5IfrvTKf6KnUlVbvwjwScJgXy4XhsfaxV7O53ydZEGEJq3PBVS8uuKHuyiTAvE2mMfC1SUcoEYau2DR8TwltK3Xi4vg+Am10uoBWtw7H7wC4xIqW12DYHmyxSQIXg9niT5GKwWGB1y2IY+WgzlsmgluBuvsFI93b2TOuWKmtaNiv9BXkFuLzyqf+BMsM3sbIfD0YtJoPi9iXmZiIabS6JOx8B9pbHN+I4kNzVWWiW2nL+8+vV+f9Cis9mIHgP4qXcJuwLnJtgKKOaOx50h9yJYLFEsxXeKK7uAf1zQfgjNU9Nq4aCmrnsP+qbj0WdooznksguZitKiENmS+40r3dSMrbzTR+XBadPRKYxIV2U+//Zc4Ch1QQzrp+Ctm/8haoq4qSOOY1UW/RKJLYnzNhywN9+++ol7+J xdOIJbwH TMHTQVC0H4Hu3woXdDV2eTTTqhcE/OM7TUIEOPmLVbTn+u1qGla2avfs1Pyo6eb9xxQyLuL0hFD4jfWPBIgb4cD71dHLQZcDsgNNDG1g1lniDbL0jgfqzzpfLLGXobNo5YAqqRWhoPmFFCAi4NLNVS/DUZZcluHziakA2wuHpm1++mMW0PdiNf7Y5SMIn+kFyuXsElmwbQkIgJR2jT4je4fVWlf9KlYjbPYxdO8S22cF03l4+smAbRYe3ng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi all, hugetlb init parallelization has now been updated to v4. This version is tested on next-20240112. Update Summary: - Make padata_do_multithreaded dispatch all jobs with a global iterator - Revise commit message - Rename some functions - Collect Tested-by and Reviewed-by # Introduction Hugetlb initialization during boot takes up a considerable amount of time. For instance, on a 2TB system, initializing 1,800 1GB huge pages takes 1-2 seconds out of 10 seconds. Initializing 11,776 1GB pages on a 12TB Intel host takes more than 1 minute[1]. This is a noteworthy figure. Inspired by [2] and [3], hugetlb initialization can also be accelerated through parallelization. Kernel already has infrastructure like padata_do_multithreaded, this patch uses it to achieve effective results by minimal modifications. [1] https://lore.kernel.org/all/783f8bac-55b8-5b95-eb6a-11a583675000@google.com/ [2] https://lore.kernel.org/all/20200527173608.2885243-1-daniel.m.jordan@oracle.com/ [3] https://lore.kernel.org/all/20230906112605.2286994-1-usama.arif@bytedance.com/ [4] https://lore.kernel.org/all/76becfc1-e609-e3e8-2966-4053143170b6@google.com/ # Test result test no patch(ms) patched(ms) saved ------------------- -------------- ------------- -------- 256c2t(4 node) 1G 4745 2024 57.34% 128c1t(2 node) 1G 3358 1712 49.02% 12t 1G 77000 18300 76.23% 256c2t(4 node) 2M 3336 1051 68.52% 128c1t(2 node) 2M 1943 716 63.15% # Change log Changes in v4: - Make padata_do_multithreaded dispatch all jobs with a global iterator - Revise commit message - Rename some functions - Collect Tested-by and Reviewed-by Changes in v3: - https://lore.kernel.org/all/20240102131249.76622-1-gang.li@linux.dev/ - Select CONFIG_PADATA as we use padata_do_multithreaded - Fix a race condition in h->next_nid_to_alloc - Fix local variable initialization issues - Remove RFC tag Changes in v2: - https://lore.kernel.org/all/20231208025240.4744-1-gang.li@linux.dev/ - Reduce complexity with `padata_do_multithreaded` - Support 1G hugetlb v1: - https://lore.kernel.org/all/20231123133036.68540-1-gang.li@linux.dev/ - parallelize 2M hugetlb initialization with workqueue Gang Li (7): hugetlb: code clean for hugetlb_hstate_alloc_pages hugetlb: split hugetlb_hstate_alloc_pages padata: dispatch works on different nodes hugetlb: pass *next_nid_to_alloc directly to for_each_node_mask_to_alloc hugetlb: have CONFIG_HUGETLBFS select CONFIG_PADATA hugetlb: parallelize 2M hugetlb allocation and initialization hugetlb: parallelize 1G hugetlb initialization fs/Kconfig | 1 + include/linux/hugetlb.h | 2 +- include/linux/padata.h | 3 + kernel/padata.c | 14 ++- mm/hugetlb.c | 227 ++++++++++++++++++++++++++-------------- mm/mm_init.c | 1 + 6 files changed, 168 insertions(+), 80 deletions(-) -- 2.20.1