From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E21BC47422 for ; Thu, 18 Jan 2024 14:48:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E84F6B008C; Thu, 18 Jan 2024 09:48:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 072436B0092; Thu, 18 Jan 2024 09:48:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E54EC6B0093; Thu, 18 Jan 2024 09:48:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D163F6B008C for ; Thu, 18 Jan 2024 09:48:27 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A3F91A0CD4 for ; Thu, 18 Jan 2024 14:48:27 +0000 (UTC) X-FDA: 81692712654.30.D4CE1B7 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by imf17.hostedemail.com (Postfix) with ESMTP id 745424000A for ; Thu, 18 Jan 2024 14:48:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=sdGncl7D; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.54 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705589305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xVxmjtoLbdX7EDdsXjVidtJhDNnF1SPUOgvPjPFVQ/I=; b=duWDNyQhIBRboKTW9MPa1clquM6CE8uDixGhAHfuZ9kQSu5AU3PdsG4TUXcJWpBAcEwAUL r3fiOugWqJFpbRYTgRwxWS1Ny10YaPDCDsvUGw4DzN9kgKteErtbSAgTssV2E9Ou87RPrP 3G1kFrj4aflHRqRO3pMK8uwaQLBq8io= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=sdGncl7D; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.54 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705589305; a=rsa-sha256; cv=none; b=i66JO/ytltzryUYTn5SjFKRWC++ViOTItRKAzBEUuoIrDcthrbS+vf4BjbEcThO2ZbNo2/ l9/JTfWto4AsHgxFktux3Y8W3g/peMpD0gEsY8+9RiBMA92taA0D1rvZgsEZ7xDg/G4WzC 8t+ZU+oIW7lIvh8SwF8Ta+6VlmIBwV8= Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-68183d4e403so8232296d6.1 for ; Thu, 18 Jan 2024 06:48:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1705589304; x=1706194104; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xVxmjtoLbdX7EDdsXjVidtJhDNnF1SPUOgvPjPFVQ/I=; b=sdGncl7D4XeAiGg4kSyI1tBzhVD48B33Z/3xacI44VJSFH6hy7VNUFJIFXqf2+rJV+ fL0QB5PJ50AGrmec7t4NDoCPB9vHrEnDPn8iL/v5yEeXplIq5eLnzBYmioreHF4qqJhN RcpKlwoU+py0NBV3t1BldqV6QjLea0lJocIhzLp5dWzszM8gLJl4Xf2qBDAbs6voENtz e1SoMdIos/iQl4jLEsCX9PijBtqN0SO20PJ5HVnvNyAKbe6B8Cx7Fb4pG86qjqbAnE3h f0iRJ57DMcoXgb4wXMiQttfPhj3Gm9B93vXDNpAuMQxuME3kfriANJyic45xYAYsXdch DHww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705589304; x=1706194104; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xVxmjtoLbdX7EDdsXjVidtJhDNnF1SPUOgvPjPFVQ/I=; b=ZVdC2oq9oK7QZZFK8JvFBZVf8JQfX0z5IjNcUg704fT3G6CaHXdC9j7oAAAh6lEFRg XdlG9I/FZ+xPXwYHgwNwQtGM3SXe554/ASoY4iBBEZRzDNsYo9ssdK7lTtYw9DDAKLb5 VMHU9Y9RRGrHmUEK3u7av64qjo/JwxRc0YoWbxYHc9g238KvfnwzMV70hrJeBhCtT93C PWjyUKJXF+hjY6fgUifmMYJP73VAx1xpR6KHTdRDLK/EP23hz2dmEInSmpAtG52Pndvb eV2/SSASxiHBpz4/wLgSuiGaSyzbU12iZZH5n4Mu/hdcsLv/zRn3k60H81Bapx5ASsWk Mr2Q== X-Gm-Message-State: AOJu0Yy95rzPUQ2FPV8uRyeFGCOpaiaHUC0YoiKwJf9uwA+Sl/DPh55a JAQ+XP5B+Khb03cdBT9mAxruFFdWiLYtZ9E0ADWcD+hHgaEeHG5uI0BLW/lXfrI= X-Google-Smtp-Source: AGHT+IGajBJ36LmLjSs9/3yRFfq0ausFe3LXPKC7KV8Lu+uOJ5KX+HjVmDDJ/4m3FU3/212zX7RDlg== X-Received: by 2002:a05:6214:5186:b0:681:7567:86ee with SMTP id kl6-20020a056214518600b00681756786eemr1017913qvb.71.1705589304433; Thu, 18 Jan 2024 06:48:24 -0800 (PST) Received: from localhost ([2620:10d:c091:400::5:e85f]) by smtp.gmail.com with ESMTPSA id w20-20020a0562140b3400b006817d42eac6sm1361209qvj.53.2024.01.18.06.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 06:48:24 -0800 (PST) Date: Thu, 18 Jan 2024 09:48:19 -0500 From: Johannes Weiner To: Yosry Ahmed Cc: Christopher Li , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Wei =?utf-8?B?WHXvv7w=?= , Yu Zhao , Greg Thelen , Chun-Tse Shao , Suren =?utf-8?B?QmFnaGRhc2FyeWFu77+8?= , Brain Geffon , Minchan Kim , Michal Hocko , Mel Gorman , Huang Ying , Nhat Pham , Kairui Song , Zhongkun He , Kemeng Shi , Barry Song , "Matthew Wilcox (Oracle)" , "Liam R. Howlett" , Joel Fernandes , Chengming Zhou Subject: Re: [PATCH 0/2] RFC: zswap tree use xarray instead of RB tree Message-ID: <20240118144819.GE939255@cmpxchg.org> References: <20240117-zswap-xarray-v1-0-6daa86c08fae@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 745424000A X-Stat-Signature: znywk4ma9hd9pw6f8hnq16qhrq9oypys X-Rspam-User: X-HE-Tag: 1705589305-266287 X-HE-Meta: U2FsdGVkX19+Y15A/wPwbQtnUJxyFq/NR4V5m3l2oLkZEM4/rJyc+OeddCAikrQR1L8LRaF16MeAXpYUB8m8KdAwv5dK4eTrlj8Vf8NeZMVVg+91xXDMqXsr74cmhwkRAMWOp5gy2bewmCGE4S3KHAmKZ/Wr82tgZbFcpQRYFnepVEkgB6Dzo2CVDakkScWxP8C70vcnJoJ1/8E/qDM6tqvZb9ZRP3URBQQtw4BRU3d2cDsa3bvtM1dXoywUdWesLSndrvuKynoaqXGbWPKFbPQ1mq6lz8UVl1zipV75wOMeJdlVG4xinKihwM46GPW/aKOV5Z1LYOq+Cymhzn/EwXOmvQLZzOFeOncLQcjaEfgccP6BGtIQnbzMWR9y/0rWMR01FqzqHhnsOEJhyxaxDF1PbuCfmoE9gJDDTfeTY2aTNd4gVE9WbDyp+qz0iZ1/7zdRWzLsN7bBaKxa9RgU15bBomZz1U2L0adyEeHs4YPzHgbOMRCCnC+YVQqkuU9H7iHMs9ejyGPUd2CgQnqbGNZZ1KnMqopWWvBDvesJKn7HSQ7eciht5dQfq8bhDRAIMRwrOu3+e0+HN3EgK4KopSAJ5yKkvzbrfUaMR+OK8ewVMIfCyKvWiWMHI6JGPcl7wA0IS8jW8RPKOBJT8Gqn1issC4DWJg3mxy4G0Tmf+K58M0drHgDtxOG0MK2502FbUfJ75ILpxdxmzbCL7/4wGJRDtOvM/MVZFWjPurCmMAhmpFKKk439h61PY/Gbis1m1E68E5ENx0+MvSr+5EMP+b448AYe/ZnT7dZ6/hL0j6K5/LGDoKGTHoYjTaV6fuEQlb+/PjBIL17m91+qgQ7PnDTV31ZveFoHzyxdzGTh336SqFPZJPifypzhX2yvPk9JVZGfSiSp22U1PHF6r0IalBc1ZTDY+LwwuyyxaU0XJmK2W5LUxVXLc4/78fgF6cXU5d1YPzXdLwJrfBvpxGP H0XMrRD2 Qqt3KHeXh8tw/+fqfH4rYMRsMGVs16ETyuPGDmN5n8I4e1vQQa3lZuiLdV5RnR4gvEAOow6l5N9pza15WTskOQ6WUsM8wuEo3VZndnO6h7linPglDPKkVx/Vp9Ex8Vosn1WlUjkO9L0Fl22B+36ucsfp5rEOWNX1ntoka0k6WeclGYl05NDupq0aHfHXet1rznv+aOBXsQbwPLM0J63RUj+IUQ/ak+e12eQlz6fgRV7uf6p/gEbwYH8XvYQ0QvZfRcUQQiXhQz2c6U9IaWnvrL3MFyD90sitIspYaEIb3IuW+uxyFlDUP9wGrS0RhPJi4FHncPN4UKE3mbzslW473kVaTQBD2l4bnTqaIQDuxSz9USvLiMKOyXAnWcGJYR6pzL4QHAIhKwBZdxmruyXtRiAR5ohHJ51w9Rk73h59kmODibEHbMDNAdfXARFWKlClOU6zZaflf4YaoQdhIkjZXCwMZGPr/oZZpiXLM8uLFK0Ehn2Vc9FHYAdBOnPGAn7qwxVjF3CVJFayLtyXZdpu3V18XOCMxJWKweCni X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 17, 2024 at 11:05:15PM -0800, Yosry Ahmed wrote: > > I think it makes the review easier. The code adding and removing does > > not have much overlap. Combining it to a single patch does not save > > patch size. Having the assert check would be useful for some bisecting > > to narrow down which step causing the problem. I am fine with squash > > it to one patch as well. > > I think having two patches is unnecessarily noisy, and we add some > debug code in this patch that we remove in the next patch anyway. > Let's see what others think, but personally I prefer a single patch. +1