From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE5DDC47422 for ; Sun, 21 Jan 2024 22:32:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14FE46B0071; Sun, 21 Jan 2024 17:32:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FF776B0074; Sun, 21 Jan 2024 17:32:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2FAB6B0075; Sun, 21 Jan 2024 17:32:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E2DBD6B0071 for ; Sun, 21 Jan 2024 17:32:02 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7F77FA08EB for ; Sun, 21 Jan 2024 22:32:02 +0000 (UTC) X-FDA: 81704767284.29.54FDC80 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf26.hostedemail.com (Postfix) with ESMTP id 8E705140004 for ; Sun, 21 Jan 2024 22:32:00 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=x4DdY3Co; dmarc=none; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705876320; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bpZHHl7W/YPNyNRX4YmMbRGBfgPEjFVNxyFteww6AMU=; b=3lW07bfBq/hQ9aF8zzH4IaUsc1vhRZftwhaPWhf5Gbp1doU8yo5YepWCceoeJcAJPRYnEr llwUzHeD/7TeSHzekMzm7N4Yyx+EbFdXrwtMuCSMb+AUPYFku6PyK1ZAxovGSa1MaL7cSY 47nUpYjIdkzVeMaIDfxYZUOW5Yd0efo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=x4DdY3Co; dmarc=none; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705876320; a=rsa-sha256; cv=none; b=n4RvC4netxeW0TKYCbIcsmsd6oerXzi2jJnbJkmNg6wD7CwxTsgGY/1vsbYvGpBS4JqwL6 7HSELtIXT9m5aH5WKgm4VLfHolkvSSyHVFLgmwC5pDfUqWoyjkwomHujh+CQSMU7vn1mUg ooVwgZiH/hfDzFqae9VYUdowDv0wjWU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id C0406B80AD6; Sun, 21 Jan 2024 22:31:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 875C4C433F1; Sun, 21 Jan 2024 22:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1705876317; bh=rkM/sUveJZH/3tT1dW1uZCos4SbkOb6XoszRZAKTad0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=x4DdY3Coz92mTQor+OYJ+Gu0tmUhkt3KAOd6xfdJ1+YRk8ff82QKalabBHoyjvGJT T+T1iJNXuJ/h5BCM9brDS7l8l7ef3BIcE39VyQ74274yQ/NZbP62vgezklm57PwJP2 F/nnz7NzHCCben/wdY8WTm4XMTXVtpRUuk1DI4Qo= Date: Sun, 21 Jan 2024 14:31:53 -0800 From: Andrew Morton To: Audra Mitchell Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, raquini@redhat.com, Adam Sindelar Subject: Re: [PATCH] selftests/mm: Update va_high_addr_switch.sh to check CPU for la57 flag Message-Id: <20240121143153.5dcfe26dea53ba0e896dbf85@linux-foundation.org> In-Reply-To: <20240119205801.62769-1-audra@redhat.com> References: <20240119205801.62769-1-audra@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8E705140004 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: bgdqzieo5ikaun8awqo17k1oqidnwe6r X-HE-Tag: 1705876320-120962 X-HE-Meta: U2FsdGVkX18qZfqWhPVjdCDgkyFOTTUQY0coknoI95di8NKfB9agpodJy3FwG+GmMwdVTZlIEzRfC/G3T9GRCYkMGzXC7bLvfv7muLcfjNS/8yD5XVdQqosmwQm5M1AO+o7lOeUiW05prG74AEfueUjYIBc0XLlflqy6zYmqmGr4RLW+/H4IIEWBS7E/0TXdN+/U66MTVe3X9tdx7YML5mP1Kb7z/IVcju+wsJK8VabmRnpXe7+aA37pkYtl5yDU1NYBcuk/D90S8RdcFQ47uccLW+waQSBQRjB9sE+/iSJwkf24G96Vwwt9zU+VP4ntzJjpCGtRTUhukLzPLw5O/rTFADlwMqLkAVrfyhtjTuS+51xkLNYpLGLM8dVKxI9JP9XX3RvB+1BDo6mcLupDnkTTESt6oXdsebk2MYGq94xV/AvyW9FktS9PZB9TEZ+PTkZQzLVEWRPa1KT6JBmtPOJGRU9lnLUKi+BGBD5JUaqRIN4u2H2gl6Y6sxYQ/mOO1wnvsDRSldr8JGGXFtV/Xc5MVr8k6diIy0T4S7gVCPyxwDHNqGGq+H5LQZeXxKUbA5EoKzgI8MBxu+RArkv/sim2j2P/QKE78a5sHsqOgJ+9SvQVm8Ia+YVxOXLlaYBNopMLoRVJHl7B8RUAqbjFTHLzeLsVA4OYr4BC8+UOanvKigQjAGD3KLIU5MdHP2aa1cWHPq5JNGHE/cBSNB/TNXUp9GOo9gDuWcE/Nsnr5Pxd1PFL9YNG1J1Ge/BkaHD5pWrKnELdO3aay32H9WTJ2ROJWk9CMLM5NdEO7qNwNO8uT9/zj+Y3rMmn5jK7NxODg0GR6R/SZCoJ9wS6a+KJYgxe3zw0vXyMN409HdDAQf5aW2a/J6GWkK2KrDb7EWhcbBUI83SlD03+O7/6bSpSNo3NEpLGU8neKG6ZU471wgvePs4fb9AULxW8MoW6183IEtLYkCMzj5umCRb4KmX LV/cgQPL 86lF4UrD0u1HbR0ONNwD+SPRQVUOprW+jea1NFbU+JAOz6wm0bcnfHV4ksFzIQqgkDoa3fTiLbwR30wBGnLAvMeU48zJn7QlbG9OF3Ydj5Rx7376aje11xTyxN2tCR1Mi8W7IPrjodDtz8Ftrcx6slzWCKurbs+DKVPuPV5muwse8r6/StWdn+mv54Y2DZ0Ly46sJGyByA8YlAy/k0a6qoZ+enT0xF7acsG8nTRfOTelBLrwfI9cJFsplSc5SMtU+c/7h8v3j5PH2XNvV3f/Bvn4+8dtuyLDbZU8IF+ofwHZ+dfL6Dmnm6nryPKFPT6PyYjFmAMXeFwe6zw+DQ8IvvJ6KiEsIIDjsF7kq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 19 Jan 2024 15:58:01 -0500 Audra Mitchell wrote: > In order for the page table level 5 to be in use, the CPU must have the > setting enabled in addition to the CONFIG option. Check for the flag to be > set to avoid false test failures on systems that do not have this cpu flag > set. > Thanks. I'll add Cc: Adam Sindelar Fixes: 4f2930c6718a ("selftests/vm: only run 128TBswitch with 5-level paging") Cc: A more complete description of these "test failures" would be helpful please. > --- a/tools/testing/selftests/mm/va_high_addr_switch.sh > +++ b/tools/testing/selftests/mm/va_high_addr_switch.sh > @@ -29,9 +29,15 @@ check_supported_x86_64() > # See man 1 gzip under '-f'. > local pg_table_levels=$(gzip -dcfq "${config}" | grep PGTABLE_LEVELS | cut -d'=' -f 2) > > + local cpu_supports_pl5=$(awk '/^flags/ {if (/la57/) {print 0;} > + else {print 1}; exit}' /proc/cpuinfo 2>/dev/null) > + > if [[ "${pg_table_levels}" -lt 5 ]]; then > echo "$0: PGTABLE_LEVELS=${pg_table_levels}, must be >= 5 to run this test" > exit $ksft_skip > + elif [[ "${cpu_supports_pl5}" -ne 0 ]]; then > + echo "$0: CPU does not have the necessary la57 flag to support page table level 5" > + exit $ksft_skip > fi > } > > -- > 2.43.0