From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DC0C47DDF for ; Fri, 26 Jan 2024 15:25:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C0D56B0092; Fri, 26 Jan 2024 10:25:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 56FDA6B0093; Fri, 26 Jan 2024 10:25:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 411026B0095; Fri, 26 Jan 2024 10:25:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 32FFB6B0092 for ; Fri, 26 Jan 2024 10:25:18 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0A92340F3B for ; Fri, 26 Jan 2024 15:25:18 +0000 (UTC) X-FDA: 81721835916.29.38B9B93 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf13.hostedemail.com (Postfix) with ESMTP id 7B70E2000E for ; Fri, 26 Jan 2024 15:25:16 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wyYlzc34; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf13.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706282716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RmrMLc6E2IVqKhV8ZhRU9VeFjN80rDuhVxh0u6+eJMA=; b=T44OEENYBmBPsRwp4LRo7BQSKU3P4ragP2xWZtawO7Cx1ZE2m6cetdfIgzbAfjVmF3hHEv 1Wl1R87RnDnQlp7eVu3SMrZDFcv8X+RlIZALShmTbp2Y0eDLzYCL8Un0ENDfXfksq5Ku7h Cl/fS4x/64AcpWT71wHDQabpzWwtFQ8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wyYlzc34; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf13.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706282716; a=rsa-sha256; cv=none; b=EdkgnsofT516LOJ+5bPxJRVEdVldpqtSTHiQ2wd4DDxRVjm82CrBozA5MDSkS1ifdrPRMk GxLSr2nuI5Q6G/Hx8z0Kcyx8RNepqltpHfZY4bkIwgbgmTKYOn388r4wr7BrJUokD7ln/j QAc11VMam674NKvw7HO7q0C+RyUNkG4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1706282715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RmrMLc6E2IVqKhV8ZhRU9VeFjN80rDuhVxh0u6+eJMA=; b=wyYlzc34oaBoDa42QsBypygqXrsoGKHAfb+deg3SuOPDAmbhiv09g6PCqoW3PG4AJbHsVA hz3+64qyLRhxOGW5ACJiiomiu2sHCxRKxpEOC4gAbDn/H6YePZadVNJJ/H4FtQXG7IOOjG 0L+u9CTOwvqS2DBzIXlE1TKDr+2kLOc= From: Gang Li To: David Hildenbrand , David Rientjes , Mike Kravetz , Muchun Song , Andrew Morton , Tim Chen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com, Gang Li Subject: [PATCH v5 3/7] padata: dispatch works on different nodes Date: Fri, 26 Jan 2024 23:24:07 +0800 Message-Id: <20240126152411.1238072-4-gang.li@linux.dev> In-Reply-To: <20240126152411.1238072-1-gang.li@linux.dev> References: <20240126152411.1238072-1-gang.li@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 7B70E2000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: d1eagbtfg1mgks3y3jgyyh7kcg4wwxzx X-HE-Tag: 1706282716-827688 X-HE-Meta: U2FsdGVkX1/BJeS/gV3dai9g2yNjcRE7Hgtr9VT9x8aMSd+SbQbuXwXFW/cf1iM4d/OcZeVSq6IXsjSgqpRDKgYlPERrHKtzbesl3NNFfnLxZfsdMlF2Ryo0e5MzmXIqtFoaI3CbP561KnZCp4GpFjTY+d0spjjIHXGeaj/Pt9WsEc6dAXoh/g+TzqPFY5dJ0+7o/D/QRVZwy2iTMm7jNySsY4fGO/wTzJzvZjksyxNcWELr9iFrRrhOAIagJpNuKLaSQPNWn2CiTFjggqyxxfiAA6dIl0kDASHarIeU9nh3nDxBDlAZqCbh57YvK9dj47Uqfb8nrFojiyHs5EVlenLH+lZGaD+yuLPiI6lWFQLRN3rgc0zV7W/dVOfqcmqMuFNNvvIuCXARRF8HTQfZxMioDqq8pwqFShIA5VzfwqxlPTphCPUZq7CM+Kr5Obq2x0tGUAdZmd7edMklEd+SX3fbiA218GaZwvpL8C/xVadzlRo7wyvje+Qq41KUtsWd/uYH692vZvfldxvy5j1VedSucQJImbsrmwZ4GPLrWYCRUziSHbaiAdd7iyx3NOFx/NykH4S2omChXtMWF6cOIGyrhS0vBUfkyw+IIRabF3cqAcw1i7uiTADMTJh9V/vjIjngYcQe1oV53OM87HSImfUq+Snx1CisFan7soWWh4k7/LHbh1HHsFX6FXnieP0whU/9VU3oxhuyC6bfvAhDLz+aFYVQ/W/9JV6hzYxKKwt4GGGDTeSvp6SPP9wVrahi2cCfCgYjCqYwKsvQv3ULCKsnu4IKU2p7IHgGsO8vEwngkvS1H/xfnEswxu596rI7aqGLx4k2Jt0hZe4m2vOriw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When a group of tasks that access different nodes are scheduled on the same node, they may encounter bandwidth bottlenecks and access latency. Thus, numa_aware flag is introduced here, allowing tasks to be distributed across different nodes to fully utilize the advantage of multi-node systems. Signed-off-by: Gang Li Tested-by: David Rientjes Reviewed-by: Muchun Song --- include/linux/padata.h | 2 ++ kernel/padata.c | 14 ++++++++++++-- mm/mm_init.c | 1 + 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/include/linux/padata.h b/include/linux/padata.h index 495b16b6b4d72..8f418711351bc 100644 --- a/include/linux/padata.h +++ b/include/linux/padata.h @@ -137,6 +137,7 @@ struct padata_shell { * appropriate for one worker thread to do at once. * @max_threads: Max threads to use for the job, actual number may be less * depending on task size and minimum chunk size. + * @numa_aware: Distribute jobs to different nodes with CPU in a round robin fashion. */ struct padata_mt_job { void (*thread_fn)(unsigned long start, unsigned long end, void *arg); @@ -146,6 +147,7 @@ struct padata_mt_job { unsigned long align; unsigned long min_chunk; int max_threads; + bool numa_aware; }; /** diff --git a/kernel/padata.c b/kernel/padata.c index 179fb1518070c..e3f639ff16707 100644 --- a/kernel/padata.c +++ b/kernel/padata.c @@ -485,7 +485,8 @@ void __init padata_do_multithreaded(struct padata_mt_job *job) struct padata_work my_work, *pw; struct padata_mt_job_state ps; LIST_HEAD(works); - int nworks; + int nworks, nid; + static atomic_t last_used_nid __initdata; if (job->size == 0) return; @@ -517,7 +518,16 @@ void __init padata_do_multithreaded(struct padata_mt_job *job) ps.chunk_size = roundup(ps.chunk_size, job->align); list_for_each_entry(pw, &works, pw_list) - queue_work(system_unbound_wq, &pw->pw_work); + if (job->numa_aware) { + int old_node = atomic_read(&last_used_nid); + + do { + nid = next_node_in(old_node, node_states[N_CPU]); + } while (!atomic_try_cmpxchg(&last_used_nid, &old_node, nid)); + queue_work_node(nid, system_unbound_wq, &pw->pw_work); + } else { + queue_work(system_unbound_wq, &pw->pw_work); + } /* Use the current thread, which saves starting a workqueue worker. */ padata_work_init(&my_work, padata_mt_helper, &ps, PADATA_WORK_ONSTACK); diff --git a/mm/mm_init.c b/mm/mm_init.c index 2c19f5515e36c..549e76af8f82a 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -2231,6 +2231,7 @@ static int __init deferred_init_memmap(void *data) .align = PAGES_PER_SECTION, .min_chunk = PAGES_PER_SECTION, .max_threads = max_threads, + .numa_aware = false, }; padata_do_multithreaded(&job); -- 2.20.1