From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A93DBC47422 for ; Sat, 27 Jan 2024 00:31:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD6B66B007E; Fri, 26 Jan 2024 19:31:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C86B16B0080; Fri, 26 Jan 2024 19:31:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4E616B0082; Fri, 26 Jan 2024 19:31:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A47B96B007E for ; Fri, 26 Jan 2024 19:31:52 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 73A2440FFD for ; Sat, 27 Jan 2024 00:31:52 +0000 (UTC) X-FDA: 81723213264.15.42C4831 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 43D9540017 for ; Sat, 27 Jan 2024 00:31:49 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=hy4Szcyq; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf07.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706315511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=knbdfgVePSVm8AW8NDfU6zlV1rJ44VE9GI+UrBeGRwc=; b=Gjjk4/O8UM9NZu6mZdeZ8DMqK5F1/WBTD+Fy7DNbklRs1BoWKD+lgxoAPz6w3klsxjsMO3 5T/0TKp4JPU+lAL6T/GYhVptuhQdAA0xXHx3chjjSUigqRMuSEsDRe+ub4JVTcmgg55F8N 7Cy6EzSlVjV+yABZqFmMXytCrOL4vRM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=hy4Szcyq; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf07.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706315511; a=rsa-sha256; cv=none; b=L0Ase41t5rCtHRMPDDOtDB9Lv/6zrl1Uz9WrZGGeqjXVz467uHL0RzJ/6dvLnGPxOfns21 AJ4Zj7sjqfjqneAv7obqp94KmUcRIN80cxpWVRxIy1Xe9P7NUGvd9LEqOTXXW/eEdHXayJ E3LOjKsHpzTKl1pGkq2jc3dHeeB9N64= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B5851CE385D; Sat, 27 Jan 2024 00:31:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDEFDC433F1; Sat, 27 Jan 2024 00:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706315506; bh=RaDKuFVZhN0vb+fPL3ijd0J96m8fpHt5sVQD+K/787s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hy4SzcyqDfyPcPSDeZEBcJ38qca/wNicOZrEybVUoHSIwtJygLHgV3fQWWYhi8KuR i2Ma4Sw5f8NwiIqa9eXF18gfZmEL/2W7/JlkGLmByqvbJKYJPBdj2J3xFb1A900cfj ro9qrL9Syj5sb7Pqj1CWFJBqwMsjvGvxYiUeAaYU= Date: Fri, 26 Jan 2024 16:31:45 -0800 From: "gregkh@linuxfoundation.org" To: Michal Hocko Cc: Joakim Tjernlund , "david@redhat.com" , "quic_pkondeti@quicinc.com" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "mgorman@techsingularity.net" , "linux-kernel@vger.kernel.org" , "vbabka@suse.cz" , "quic_charante@quicinc.com" , "stable@vger.kernel.org" , "quic_cgoldswo@quicinc.com" Subject: Re: [RESEND PATCH V2] mm: page_alloc: unreserve highatomic page blocks before oom Message-ID: <2024012635-stoneware-backboned-2ca0@gregkh> References: <1700823445-27531-1-git-send-email-quic_charante@quicinc.com> <3fe3b3edd33cd784071dd9b459d20a79605ec918.camel@infinera.com> <2024012205-undrilled-those-2435@gregkh> <2024012210-outshoot-dragonish-fe8e@gregkh> <01010dd280badd149291cf4d2a4a88847113cf6d.camel@infinera.com> <98318c510e39cf83beaa07a4dbf33f18209eb358.camel@infinera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 43D9540017 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7f676zkgpxcrontnni6so1soe77i344z X-HE-Tag: 1706315509-845737 X-HE-Meta: U2FsdGVkX18JQv1G/BYd5xLr8PvP1qpNX3mtsy9QUy3PkaH0OV/d4A03iIEthbHYQbVwv1e2jcERbUNHyMG7STOV1sHtAQWQDd7DN56Unvdqbzc3OchSTbGbLdZIXbXbswynytZ/BM0SozQdaINyqj6GENi0v8z0o570yG8WkDoIFdE5iGSbSlI2dOZEdqrUZRIDWFTQ+q3qrCmB7Cl/sdiTqPI2OLWybBqIsxxtRhEwrpq+NQZIzHUzv7HqYkHVmi50VpFpePvATVCk8CIAXm2rIYu6dx2ZzSeIzWvTuy8/U26MwTBUvooHYxHIvkda2aVjy5ZGnl4ID0zJjgKSpzseia8YrlX59SOfc4u6jvOUhsra8iNkr0I+yR7cRKNzstd9OrnnGB3BzyBXzsa8fsWs47aNiRahsqKWi+UF4MeL8a47LvaCd6BLD3M2RClb4ax7YvwicLMaqybNaBcx0alC1ZIQCHzQ21uZU8nMbhCOfJb/mgetlKG8Fweth5WxeWXDv3x506bElbjojdEMX5EJrAeIZWKqWFbY8ZcmFwbkdtzkNjlDbYns8MBsMwrvdRs2zgxaRufa6TrQDIfejy++L/KJEvn25tYHNpW+Fk2fe7IDFFt/zGi/8BxckpHBas3lT69Cnutlf6W1ZPfT1FQvs6vzH1LPL3/lT6iyXO0am0qDU0X4zdpWwBOcA7qvkFcrZ3SSfQsVkiR52KqBp5oR8f8m8Y9CnkjZtgrNDyMZw0SxwwtOtIYhEiD0ZY46TlLe6hP1fTSZBHc6F2LIItbuB/xR1ilawuYVBbjEK3ttERMVMhcAZqQ0J2QaklQaZqSxL1a8J+rkkb6324pgZqei4jSDelh+hhJxXqkOaSI6XlrSs9WxtaNizrw9o5sSbilkf4E8+vSX2kheOYgld6F/NVmUJrCNIP+6TRRJutyOIgaeJ4S3TaiT/JSUSQd4HprDZzV6svTqSx5/Xq8 OfwwRhF2 0OZj2uHaw2bLeU4vRLIOY4SdFljp7HBgAJnMDwwXvAMMLRGa3M3tCu7dS+HRYBMYYzLaVinM/mbEVe+Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 23, 2024 at 12:24:22PM +0100, Michal Hocko wrote: > On Tue 23-01-24 11:08:28, Joakim Tjernlund wrote: > [...] > > Mar 9 12:52:40 xr kern.warn kernel: [ 1066.001379] Mem-Info: > > Mar 9 12:52:40 xr kern.warn kernel: [ 1066.003665] active_anon:18 inactive_anon:2435 isolated_anon:0 > > Mar 9 12:52:40 xr kern.warn kernel: [ 1066.003665] active_file:1 inactive_file:0 isolated_file:0 > > Mar 9 12:52:40 xr kern.warn kernel: [ 1066.003665] unevictable:267 dirty:0 writeback:0 > > Mar 9 12:52:40 xr kern.warn kernel: [ 1066.003665] slab_reclaimable:384 slab_unreclaimable:2223 > > Mar 9 12:52:40 xr kern.warn kernel: [ 1066.003665] mapped:1 shmem:0 pagetables:309 bounce:0 > > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.003665] kernel_misc_reclaimable:0 > > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.003665] free:1054 free_pcp:24 free_cma:0 > > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.037938] Node 0 active_anon:72kB inactive_anon:9740kB active_file:4kB inactive_file:0kB unevictable:1068kB isolated(anon):0kB isolated(file):0kB mapped:4kB dirty:0kB writeback:0kB shmem:0kB writeback_tmp:0kB kernel_stack:9 > > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.061723] Normal free:4216kB min:128kB low:160kB high:192kB reserved_highatomic:4096KB active_anon:72kB inactive_anon:9740kB active_file:4kB inactive_file:0kB unevictable:1068kB writepending:0kB present:36864kB managed:2944 > > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.087595] lowmem_reserve[]: 0 0 > > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.090918] Normal: 206*4kB (MEH) 198*8kB (UMEH) 79*16kB (UMEH) 13*32kB (H) 2*64kB (H) 0*128kB 0*256kB 0*512kB 0*1024kB 0*2048kB 0*4096kB = 4216kB > > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.104104] 269 total pagecache pages > > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.107768] 9216 pages RAM > > OK, so this is really a tiny system (36MB) and having 4MB in highatomic > reserves is clearly too much. So this matches the patch you are > referencing and it migh help you indeed. Ok, now queued up, thanks. greg k-h