From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E07B0C46CD2 for ; Tue, 30 Jan 2024 08:04:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2919D6B008A; Tue, 30 Jan 2024 03:04:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 21A4A6B008C; Tue, 30 Jan 2024 03:04:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BB196B0092; Tue, 30 Jan 2024 03:04:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ECDAE6B008A for ; Tue, 30 Jan 2024 03:04:08 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B3C52C0ACA for ; Tue, 30 Jan 2024 08:04:08 +0000 (UTC) X-FDA: 81735239376.08.979D7AE Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf04.hostedemail.com (Postfix) with ESMTP id 767D240021 for ; Tue, 30 Jan 2024 08:04:05 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706601845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xqy9Mo/LkVxLYqg4ukJmfhxRcy60MyZZTy/xforGtZQ=; b=2FchLhDGxGPbNsc+dqTSu2yPxdy270mBhvm8owxZM/T8w6Yk5OxkB+MBQW2sS3h31kZhNT oPzAZULZJkDb0l+RQ38agFoCCknp0faCHpn6p6ciTrTW79oKT9mTpzlblVyJCse2+l57Ng Jlvbi5W7wbBVvIkaty68HvCQIdC8snI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706601845; a=rsa-sha256; cv=none; b=B5NfETwna/yolrcGjsvjcw8hGgG/zphemMOWpo63UbmmmhWCPQQdQbY9mP4nAzUZQnmre4 mLnq7dWOdFj67gfq3RUiFJXRmxfgzSEBcBd31k+lgIjYvixiCGH5t7xSqPCwQfy03bBMwB 7cHiSHgylqZiuu4e5em8KhOPsN9dloI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id B472C68C4E; Tue, 30 Jan 2024 09:04:00 +0100 (CET) Date: Tue, 30 Jan 2024 09:04:00 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 07/20] shmem: document how to "persist" data when using shmem_*file_setup Message-ID: <20240130080400.GA22621@lst.de> References: <20240129143502.189370-1-hch@lst.de> <20240129143502.189370-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 767D240021 X-Rspam-User: X-Stat-Signature: qob7hxd5sakp6a3hyaaq3o9775j8nh7i X-Rspamd-Server: rspam03 X-HE-Tag: 1706601845-725675 X-HE-Meta: U2FsdGVkX1+AOW48T3Fdq2OUX329/C0ZDQkYtBvG0QEdVzy8yLiBdwdgtgMiBt/1OJWMR4btDiOJ3Wq6MuNBfOw+nPJLX9fmf05eZU28PVuZ7ab5lxIjYAlIyXlaMVUD3kn12QRSNfD9cwifQXHCdHDXCrn3b1kGqRbIfY6mcFUOf2ofUsNt+WXbj+Ku0O4NTz3z7c4hTVfGuXzLsoU6ycWjUlacBzZUOgSf+IecR52uXP5fVfvSwJSp8GliIYHpC9GQYtCw4wI4F70Ug1s6Em7tdGT2yV7Em+t/eetSk1CQaGGCJBrKNsUo4PaZ9CsAVXEtUvHCMRu8KEtnp0UniLBvE5r6flE3IyGDYTk8zfO++BQ1rhPZbX8trd/7hFnmZdVmLGG+/t2W9gDZWV1jY2GsXG1pixe5NLFkRdkrg1YcwnpV7cBG1fGAGbKUstHzvgRXmXz0AcNnX0GvIq2sVxJHKJvxOhXSsfepIO6BlrffW7JyLGCjy++FPJUrVnyxKtRe3UgYKa79ENaZXxMj6SVtsUARCzNe+O7jPp/64r2tUY8IWN5vMwX7JCa36jn0fX1WP/TSIqYcYlsIclNSE9F81ZCSKfSkj8ChXqQNvK7WqSiF6LN18FCM2+DF1nW+QFkNF8JVvjKgFHj3ChgKWtnFvIJR9dpHrtQpk4rEFS+JBrmevbxT4NrZiG4lkzg0CXiW1yCrLWGVquDn2jv86+Syd0MosMYqGfUb267AUGBPHC28GvtxZJyRy/L8kwweQw4SDNSAX2rhMPeSUoJCHvG6a7egy1ZZJ6Y1luP3n/bm8VbppUZu8XwGdXHrmw7pzpU42e8mEjiZj/P3PvJ8ZXQOVR4Btm3R9VVfkHQkPjF18iluonN44XEl9x2A3spjZeKiYuVhlUFvYP6Y5RgldMMbXxOioMyItLhc1Xd8UR/5t+jawLRVCvOa6t+KrLzpyn3WXgEPbw76RPDdnV0 yz50KkjF CePGtkqKJhRJmt4b9hoLTjEWJqKIPxNRaZpEYdd8Qv4//VXVmX53BIpCc/NLLVevkHWjqNfS+wjMVGHV5gwYy6HsrG6dkOeArtpacDRZBxirnhH4UVdaBbT+nuHx/oBjoUG4WP8Jyzwm0WR2Irv32VyRgBaFdron8YdgMZ6YkNpdl3XYAUTl7LKYnb2mvErUHhU9NuUvb8s9s8nE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 30, 2024 at 06:06:12AM +0000, Matthew Wilcox wrote: > On Mon, Jan 29, 2024 at 03:34:49PM +0100, Christoph Hellwig wrote: > > Add a blurb that simply dirtying the folio will persist data for in-kernel > > shmem files. This is what most of the callers already do. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Darrick J. Wong > > Reviewed-by: Matthew Wilcox (Oracle) > > I noticed today that drivers/gpu/drm/i915/gem/i915_gem_shmem.c is > going to a lot of effort to call write_begin and write_end. I'll > take that out as part of the shmem conversion to buffered_write_ops. I was planning to look into that, but I'll happily leave it to. It also calls into ->writepage in a somewhat gross way.