From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 586C1C46CD2 for ; Tue, 30 Jan 2024 12:21:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E21C36B0074; Tue, 30 Jan 2024 07:21:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD1EE6B007B; Tue, 30 Jan 2024 07:21:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9A896B007D; Tue, 30 Jan 2024 07:21:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BBAF66B0074 for ; Tue, 30 Jan 2024 07:21:40 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6FB481603FC for ; Tue, 30 Jan 2024 12:21:40 +0000 (UTC) X-FDA: 81735888360.15.FD204EA Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf25.hostedemail.com (Postfix) with ESMTP id 97E16A0014 for ; Tue, 30 Jan 2024 12:21:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="adU/jqTS"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf25.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.48 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706617298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D8+4UFyRHhlEpNddltccPi9uQPG3sCghbVxOUf727vA=; b=ejTqWWTU45vCtqTWA8jkho1v/deoIaOxMaBNil9AG/BCaDee6svQwFJvJ7zDq2hz5GBAem jYedIPcYAVZqh4av9cT7hlyNa8nrlSfkxIvIkUxwO3Zr/QLfxuO1VDnOusSRcrzYo0RDqU qhcOAfRssbejC9c0X5v94rkruE+TlNM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="adU/jqTS"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf25.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.48 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706617298; a=rsa-sha256; cv=none; b=TLJb7XnZtXIg2ElF1CWQgBZhLEW/oe9x0ePCxYzZdTN4HLYLkX8OXcnjW1yeXsb1JJeB4t ZLN/C7BDltdYAB+hg+Q7n7d/SXgaxERR9PfYmVFI0k5SEVVtezPuvup7pwVxc+5FFabEgG Ue5NagQiBkZvi8GfHT48WO/3hlIASM0= Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-295af27ec73so328263a91.2 for ; Tue, 30 Jan 2024 04:21:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706617297; x=1707222097; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D8+4UFyRHhlEpNddltccPi9uQPG3sCghbVxOUf727vA=; b=adU/jqTSTsMKpf9dIZ+UPlJjqo50/0l46YFKWwZvCqdB7WOH21gEp/WDFGFi6fF5Q+ B7+dxMlrXLEQbUKnBMPfk9DueRRjc54kVGDt4Aw4TrK5fM7rchbk06LQ0st9Y7mYox8q 1qEFKTa03jvfStX/fW/HM4e9RluB6OMDEGkdk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706617297; x=1707222097; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D8+4UFyRHhlEpNddltccPi9uQPG3sCghbVxOUf727vA=; b=cCPGkl7GEgffHh60jGOzQAWec0UeGZXRMBoShOCiRfIJG9kmGxFpquHHM3oRQpclVl fIe2RrzgfLv2vwKpxMjshXptGOMnRK6LeGma40Jiasude+C2PqcceJdgp9qOz+M9nn2G 6Fkskywv+AggJSl4REdimxSG5pJQg+5UBy/cI0RliDtvGY/18kfrjxtvQKHTFaouq042 Y8qo3R95WrWU/5EwrXc/g2J4nWlQl3zLiY7c41ArdJBwIs2ErmERxpO8zGqtVMVnrPwk Gliu9i6ehTHo7CTBEplGZaaVnGYMA5WQ3h4NEi5PfWRXJVDE0hrpEw5nxKqnbglVMw8Q PAIQ== X-Gm-Message-State: AOJu0YzMjrdHf6rRYIJqFfdih7e8aDM/wNXpm7oSiSRcGfaCZDM6egiD eiGn5nGpDcql9NjBK3q3qA7zln8gav5NIi+HpDs+cSzNQaXrL0pMGpSDafalaQ== X-Google-Smtp-Source: AGHT+IFzPYWSqnlXBXe/yAEuLMD11R/G6uELISH0ZTJQSQlwhmX1VotK/WdsbPf4bCh86m1o3CfYrg== X-Received: by 2002:a17:90b:3a8e:b0:290:a991:8daa with SMTP id om14-20020a17090b3a8e00b00290a9918daamr4064472pjb.4.1706617297319; Tue, 30 Jan 2024 04:21:37 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUgYwgiNATSWxyNKdGZEBcNSFAtgmCCYVevXiwoUTXpKQMXlPo0w2LEvWgP2FfHLVbVhW63eqWoOw5sEXIeUbVx0KvCuJALTDWjNEVpT0v3zV0GBqo9mxIjRJMBTGXgsSAqm7JZH4WkRjP67mwtnnz7epQjOBhOJ6to+wbTtqIUHc1bB2azSAQChBDmoGq0BNyqtzMZZdwa/x8JEY6HlilnmguF9rEauOMgfyg= Received: from google.com (KD124209171220.ppp-bb.dion.ne.jp. [124.209.171.220]) by smtp.gmail.com with ESMTPSA id t18-20020a17090a5d9200b002958775b061sm3461826pji.56.2024.01.30.04.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:21:36 -0800 (PST) Date: Tue, 30 Jan 2024 21:21:31 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Johannes Weiner , Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/20] mm: zswap: cleanups Message-ID: <20240130122131.GA9406@google.com> References: <20240130014208.565554-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 97E16A0014 X-Stat-Signature: cidtwxpw6teuig4qh6h7heekp349xqwh X-Rspam-User: X-HE-Tag: 1706617298-965556 X-HE-Meta: U2FsdGVkX19Zf7dyaIgBCiiMes7ldyKwKK1tXqmscY7rUPVCbFDHqN3rkeLfQvhzMuUwt2pUFa46+vr7Vo/kAQqKhyS3GIfl3ZVUPB3dhaEfqd6TSIcvaTWc5ml5EKmxUIB8SCPIaROY8PDoaWaMw2wJSeBr8r8crdyHBWmjHzY27lE6hjNC7xYhzz/PT+zI0/Y9438iOOfdU6tVKu1BLmf8s4xKFiNi6zr2H27utuTxGrqUwPIznFpK2FxYaVAK1I95Uq49t+C1OesdB5VtRJVx5j9PXmlupmk6no+Z1PcbvGyiVjc8afZ2dYgasv267EPjxVpRCCaMX5rpu7NioujWH3wmw6nVBe+cDgFWNW86x8+7/jhF6oQuEPC/48Q5Y2MIMfoKnQzchrAJXXxOGKAQWSy9Ib0Zn7tzTA/ouUiHYzoNiE/erLTzphhLtnm8vWMpzJaXvBYsFha9Y8qbWBthipB6FeZMbsUjUeoLpXwob27Z0G0u6C+o4VzoKmKwWN48B2HztRgQfdi0Hy7dWoWW+nO7zccsLKctGY06lyx8yycU2xdFL81PpUcYTZGf1CnHLqJ2J7iBF4pwtxVqxyWiqCKVnXVV4s8RgzefhkMk8KAVKecF29qS0jgnbmVg7OQav7Uf55C8RYfnoeOdSXuEpmV+1h5vIa3XZd7qYb2fU6YAvDGCIKMPGrkrLHypis9sAi50qO5D0eNNL7Ixd7ydInXYszv5v5tWe5s2seDedwFZKFG3c5/SaO3LTznc1qOwJk9A/W7UydNpxsCF7GxqtEi7/yyBz8HYoogfaZGO59dMWyrmLz0af7VDwQTKLaHPnwR6HK8gPWZaTl99MuXQLh3DBvYQwxcsdEruSBvQnz/f0U3PspBkfb4NfsoUVvMw/+VhxU7+Lk8yww9WKr00EKKs+fpxi6LI2HCzeoVYuEH30ctDUtcsUroIpbE7gZSKiqsp/sWd1iq26xb 6klYwGbN QCK7X2bojwIb4IUHxeDvia34veRpcQrASL9cVFPxs+MMFJ92ypMgdACwGuHngbD4/xPDHnCwaScFavwqGFyM+P28OEaAo6tpHaX1JL7QtyWZ9eqsM4OHTPa9e5pab2EYFe5/ahhxRM9R0K9d7EvY0gg6EU0YymytLFKpi5I90UWAGYHXTyGOaLxQ2+c1B5XyQXuA7EKNZ92lnkbAgEqoL4oJ9lB/0JuV9MCj4nGfVI19QSrYs1EUfgMwHRY/EJ6W3wq59b4PuxEEtquAeO/1VagfhfnMuFlKsgLwvO/oOYXdZaXE+DMQF3Hd+pI8FjLaVB+0Es0OeqhgpZrPbqnusw4fAGE9sVsQKinMT X-Bogosity: Ham, tests=bogofilter, spamicity=0.088560, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/01/30 08:16), Yosry Ahmed wrote: > Hey Johannes, > > On Mon, Jan 29, 2024 at 08:36:36PM -0500, Johannes Weiner wrote: > > Cleanups and maintenance items that accumulated while reviewing zswap > > patches. Based on akpm/mm-unstable + the UAF fix I sent just now. > > Patches 1 to 9 LGTM, thanks for the great cleanups! > > I am less excited about patches 10 to 20 though. Don't get me wrong, I > am all of logically ordering the code. However, it feels like in this > case, we will introduce unnecessary layers in the git history in a lot This also can complicate cherry-picking of patches to stable, prod, .etc