From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96992C46CD2 for ; Tue, 30 Jan 2024 14:05:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 291F26B0083; Tue, 30 Jan 2024 09:05:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 242956B0089; Tue, 30 Jan 2024 09:05:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 131536B008A; Tue, 30 Jan 2024 09:05:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 035F06B0083 for ; Tue, 30 Jan 2024 09:05:08 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B729F12035A for ; Tue, 30 Jan 2024 14:05:07 +0000 (UTC) X-FDA: 81736149054.24.8DE090B Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf24.hostedemail.com (Postfix) with ESMTP id 5CFC5180035 for ; Tue, 30 Jan 2024 14:05:05 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706623505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HHoFdfMmSyM3w5BLIMeUZloPtbsgzZucRC80/CBCCVQ=; b=Lce/U8i0BG7i4fIS95thKKTd25rPwb6MOrRoIIIHGjSmb+j8iYUPulSSettAUkUrtCUR8O uVijBs6zgIu/V5iX7UppV3ARVog6TRYKM5CQrlgBzfIJFfpRn2obYY8ZLCVlpNPMxHbAQZ m4+WRNliwn+bjE+De629BuV8go1ZdQ0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706623505; a=rsa-sha256; cv=none; b=j/RHZ3ivDLmb7uYXI/IBxgD1eiQpQ3LSCEAIi45yscClra6wkLkQHTxLQ/CV0+nMN4mc/x N9lNPlvpspfLUljsOUD6BEne3t6RfnvafCKaF07xkFghyU89Xi+eRSRyFq/wQJhC1HnkCh UL0CDjVuspNcwaHeYSJgLWlBMe3UdQ0= Received: by verein.lst.de (Postfix, from userid 2407) id 3C684227A87; Tue, 30 Jan 2024 15:05:00 +0100 (CET) Date: Tue, 30 Jan 2024 15:04:59 +0100 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , linux-mm@kvack.org, Matthew Wilcox , Jan Kara , David Howells , Christian Brauner , "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , Dave Chinner Subject: Re: [PATCH 06/19] writeback: Factor out writeback_finish() Message-ID: <20240130140459.GA31126@lst.de> References: <20240125085758.2393327-1-hch@lst.de> <20240125085758.2393327-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 5CFC5180035 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qs7hiscxgiogkrjdn8cn8pckkga15knf X-HE-Tag: 1706623505-364038 X-HE-Meta: U2FsdGVkX1/+VhSTqXWu3B2hYcpRjIjyTV2eQ3u3f0ZnN1nrpOTl/hkXLU1e/TigtSB0IkBXfcBox2YDYFERsy7Nsy0FNWHVp38Bmbb4mWJBKgPsXMDBBK0qJL3IXqOsAYWu1T3GBBSAGmz9jDa+poZSyvHNJXQoBNFcLJSzlW4qi6QxqDoyWQm7eno6ikcWck8kwm99vZ73fCt/YVRNISkmoX7MvDnzy1KR56gJAD/0lwTOCr+Q8QJge+ljMFr67xeR5ZOTNReyNyjOqD1cbkvxB6GOyrVfvuIPX8Ir/QGHXXItYABOJRwvjGHT8sYFlqXQytPj3B1IsFY++6k1QoAuJRhKzRbHmFBGeHiRyrQslHYYvo7j5BXMOY2XaBmf+j4sUi6KqEy5JC3IASdQzNlJZVBMoIUgwYNhUhslzybwhOeEA2LH/NFD/ke5klH0ZFvb2DjPcK5vP1u33KfRLmPu6OZUSLcbOESi4s15bhwll+PDZ9p+i/yKPEQhLexgwYKI6zKVXbTATdmSaO3IPH9UowPzR26qR6cgh7pv4s8DMESpvC+XIK8CQriWPd3WiCsvvZvNVacbAUxvCtvt4vZ2PEjdvC7UbR6EDksW25zb3ySG93oD3BeT7EsAtWOMTSS9MKRdOVqrBa558WScXX90/+oiZgpVZ6ZvOo1Mhn/NZLRw0p0DeelNEV+roNpKEE43/W5E+a7pQZ1mnbubMeSb8t5cfgQWeDAZuoQQ1BW4xT/yARv4ioKRAFh2Rbx5kkcjQ/3nEiaV2j+Q5qXMQ9A42pub576n4H9ejO+ahJCimkoBsalv9JSaGbAXmcg9/eacwOD2vYSXKsJqu3J94674h/o5XOvTzCaculEIRW2+NoNGF7FOU9OPhUyOOZMNtKLdbDNhPm+/x93aHBbfkxtM4b8KaFJ4AjPi8aRBebFuIJF0NSMK0V8+n5QuxHyBIknqeFnFRjNAnoE12lB Kam44KvD AJwOidr+wdV2JuaqTfeEGzqXV+I89YoI3dO0ia8DHgH1hsLkt9g0f/TxPTJvwuBlysdXFDdLp0k2/xc1pgnnDhxpOfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 03:13:47PM -0500, Brian Foster wrote: > > @@ -2481,6 +2500,9 @@ int write_cache_pages(struct address_space *mapping, > > folio_unlock(folio); > > error = 0; > > } > > + > > JFYI: whitespace damage on the above line. Thanks, fixed. > > > + if (error && !wbc->err) > > + wbc->err = error; > > > > Also what happened to the return of the above "first error encountered" > for the WB_SYNC_ALL case? Is that not needed for some reason (and so the > comment just below might require an update)? No, this got broken during the various rebases (and is fixed again later in the series). We need to return wbc->err from write_cache_pages at this stage, I'll fix it.