From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3FCDC46CD2 for ; Wed, 31 Jan 2024 01:03:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0834B6B0072; Tue, 30 Jan 2024 20:03:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 032F76B0074; Tue, 30 Jan 2024 20:03:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3D2C6B0075; Tue, 30 Jan 2024 20:03:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D3A076B0072 for ; Tue, 30 Jan 2024 20:03:40 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 68839801A4 for ; Wed, 31 Jan 2024 01:03:40 +0000 (UTC) X-FDA: 81737808600.16.18A6873 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf23.hostedemail.com (Postfix) with ESMTP id 878B9140003 for ; Wed, 31 Jan 2024 01:03:38 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VYQC4zNN; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706663018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z2R32HEq+vuywQM3UpPUw4pXHTl87m8EtCirJzA1KJU=; b=N+cPtNo3Bt7DP3EjuORMUbEJ0ksY5tqdg5Fw7YDq+0fywzEP44pj8jrHVCuJswB+Bka2Wb m1gC7Ls7x41ZEpXg6EaatFsAQcuvwaiPnaXc4VgGV2rfXuVAzkfavXiydAUrh3/sy9JJDZ uqjVCntbfh6bl5kueK0UwjuWhABUoJM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VYQC4zNN; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706663018; a=rsa-sha256; cv=none; b=Lj/uSGJrKvbAdLVPMXQmV2IQgB20s+xm89Cn833UQlRbMK99MB3/hfx+C8oCfVdZK9jUCg +1WZ5Tq4n+nFJHPxFsx3eesh/CIJk/y8aH3qd084cNxfSf7XvK+AP/idL4c5LFtuU8ikv+ g6XgNKamb8iUTWBNkfUsdaVNq7R5bVo= Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-5cddfe0cb64so2499196a12.0 for ; Tue, 30 Jan 2024 17:03:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706663017; x=1707267817; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z2R32HEq+vuywQM3UpPUw4pXHTl87m8EtCirJzA1KJU=; b=VYQC4zNNTLtZAFEDQIXeIO/SLJr9w9Q3DZMKiJ/YmHYU0mUhuO/GeFp6w2Z2Z1tTJS f4Bt5mHdAxERFzjeADkI1bGD6N3PeFWhmoRmvb6/6mrYfB+cbjIU1vl8IRriyPbAMuoU D+tL8jV9Vp6xOCPc/5WQR3l6d7fMGMZbTO5bo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706663017; x=1707267817; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z2R32HEq+vuywQM3UpPUw4pXHTl87m8EtCirJzA1KJU=; b=phltAjAni07/peUvY8XpuXBubqe8frVtjK14YxTVF8e8HwFRq9dfs83uVruIAmb9JN Ccdv6WHiHcGAOET3cKflKdg+dvMvo1fg5Fw6UI6H0cfFSd59qDSSgqC9/cLKPaX9uFOu UfYWTizEqjdczcuDeVj6UxGkizgwfxxZBrCDH/HqLrzLboOzraFWLwbgXW7Ns3SrZ8nY rIrxDlv4VZDNFUDpwDfDq5Yw8ySaxuVa1x9SSiXavJeWcksu8Mq9DQliy+t0JH2pRGcD hOdIOo03170gZeGNsPQSLn6ig3u02kMsRaCb5LZC1+6Dr3NKjnLpGVatILIzF48l9vrP ccvQ== X-Gm-Message-State: AOJu0YydQ1v+2ErHa5pr46t6iXvXnW38I9ufQ8zCbqjDyYND9/vQ1R/p zqeAT98wr2GZfjqPraxZlk9hgrxAtvdplnwY/ZTlpxIxEJsTkeuOROgk7jd20A== X-Google-Smtp-Source: AGHT+IEKiaWAQq80mzMmGk3FsT9xgGBpJXc6jj4P5Q0pB8PIHdIt+jqHenmTSFx9QlPLTVK+SS6fFQ== X-Received: by 2002:a05:6a20:24a4:b0:19c:b10a:61d0 with SMTP id m36-20020a056a2024a400b0019cb10a61d0mr107912pzd.25.1706663017109; Tue, 30 Jan 2024 17:03:37 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCW0yxdv61U9Ph0riM4nwnLHvOyV1MA4icW7D10rIuc9crwin1on/sLBscuwTNdBEeyNKzEpEjWMdc0wLygUtXNLZtYKFw9bQsJ6UoyY5Cfr0jayAwMCmxWcIBj/aAsSEv1llXSMeuTysFl9uSgIs2C6MPAn2RTmsTq6Olkm/2KjHgVThpzm7n56mgUXAlbzNjp1A4e+ArpicjaVcAwPLzJhFWgVtimZL45//dx4BPfYPXGFhEpYBePAs6gPtn00wNFWBQ== Received: from google.com (KD124209171220.ppp-bb.dion.ne.jp. [124.209.171.220]) by smtp.gmail.com with ESMTPSA id z5-20020a1709028f8500b001d7222d8caasm7831874plo.50.2024.01.30.17.03.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 17:03:36 -0800 (PST) Date: Wed, 31 Jan 2024 10:03:31 +0900 From: Sergey Senozhatsky To: Johannes Weiner Cc: Sergey Senozhatsky , Yosry Ahmed , Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/20] mm: zswap: cleanups Message-ID: <20240131010331.GB9406@google.com> References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130122131.GA9406@google.com> <20240130155201.GC772725@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240130155201.GC772725@cmpxchg.org> X-Rspamd-Queue-Id: 878B9140003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 34hsxhm9mtgpq9trn9ysh3g4ec91npng X-HE-Tag: 1706663018-561029 X-HE-Meta: U2FsdGVkX18FZFFy0V5UkvzeslQZFkX6+cbem5dx6+V0qQtKCwrwPHy3GrJfuhfgad+Ui6ooDpPidjO1bRcAYSC/xXNFlLPdYr6v4+8d7bI629ZW2618hzoQWM40qcqbFbzjwwAxVHNY0n64jzQqhqh2605aGhvnOk0CRogUdLAtCXCx5dzKtuVrnp9vcUpMfKBtAJBvSCEDsjXFVyUxCAr/h34Xsl1aOX6+hSnlwkE2bv0g7td9FsaLSGEd2GD4N6juuq7EyTHhBY8s0/WmB0f6uxK/T3EeZvlKgQ1cqNmN1nqb0W6/pgRsLDcVPZp0UV3bvIWQW1KGeP+XNODFrM5eNKUKdGe8Z/APjfxRpmWjGGN9TlFcaY7+UYqXuKstpsV6nMDGNbYUjLt3FEFIZiIUOzJpOiAoEX2zyxob/LufLSrwCdcVZkwBiMWCx2C4CzhotKrI/ywS10IMq++fuoZQES4AsjgXFJG2qnVRPa3lWVUwB1GN2po+BakPjeI3M3060bEwRevt3nLt/L+2DyQHUprRzBGycYjh2lejsH4YFil3vc2DTJAl/qvfuFi6Evh5vvy3AEb+wi4ZXRuUdxuuuLNODEPx2kyxyIIMIYCL9GfCIxvpvRE7wtNmVvprgxnZD4o2BpoB9KWlteZAPQnegsb3z0mHHfAYFpwCPsSkhNL1ihjly26hsy2kCrCMqDubN/hihh9nBR7tB5gNbVaiCtghQTvYpYl8gQucGuhMNdsVP/VrMcF+AerbPxaF2NAmgCGQnsU3IrglTtdQsLqZ/GHm1lvMQZcJGATjn21GEpuok3DaekWIyPG3qGxG1azsnu8obq4agOEgkKpOcj8S1MAJ2wORVVOYgs/tIvyr4mPHZbYi7Dl4/7brxikURK2zQ14SwfJCTZ/7k36z0ligPIDKqNAJX6krkph/5h7ZOwBJe+oscwdqgFrlX4owWrV6hcwxzZaxuwEWzTC yTdnkBqq wgL83Vxl01s2Y8+wTFZ/HN2lS8Mm9fvZ3pibhIjp5MDxu8GL6aLdGawderYtx7ToWQJXKyXj5phEU+3T5gYdKcCPqLdV1e5gPl9KN28xFu85KHpcA156gvP6G+W7usJbyVnRLhrv4nPw7U+H+Cbxc3yLcZqbqUw/idj/2k3h1FGk/ueTDfWTQy/UKTJCJBqY+ErStrJfxQVvhPQQILr2kE2eyc5gWVHmxs/a0XEaFlILFB76s4HKxSRmTpZi0PWRHCVP2kByPa2mXC195UlkFpWsQcHndT9XQmfdyO9F3KvJ907ultwDMqWXqBCIefQRZo2ru X-Bogosity: Ham, tests=bogofilter, spamicity=0.000050, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/01/30 10:52), Johannes Weiner wrote: > On Tue, Jan 30, 2024 at 09:21:31PM +0900, Sergey Senozhatsky wrote: > > On (24/01/30 08:16), Yosry Ahmed wrote: > > > Hey Johannes, > > > > > > On Mon, Jan 29, 2024 at 08:36:36PM -0500, Johannes Weiner wrote: > > > > Cleanups and maintenance items that accumulated while reviewing zswap > > > > patches. Based on akpm/mm-unstable + the UAF fix I sent just now. > > > > > > Patches 1 to 9 LGTM, thanks for the great cleanups! > > > > > > I am less excited about patches 10 to 20 though. Don't get me wrong, I > > > am all of logically ordering the code. However, it feels like in this > > > case, we will introduce unnecessary layers in the git history in a lot > > > > This also can complicate cherry-picking of patches to stable, prod, .etc > > I'm sensitive to that argument, because we run our own kernel at Meta > as well. Well, it was less of an argument and more of a "let's consider that too". > But moves are pretty easy. The code doesn't actually change, just the > line offsets. So patch will mostly work with offset warnings. And if > not, it's easy to fix up and verify. Refactoring and API restructuring > (folios e.g.) make it much harder when it comes to this. If pros of doing it are more significant that cons, then OK. Either way I'm not against the patches.