From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 113EDC47258 for ; Wed, 31 Jan 2024 13:01:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 950E86B007D; Wed, 31 Jan 2024 08:01:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 900EA6B007E; Wed, 31 Jan 2024 08:01:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A2096B0080; Wed, 31 Jan 2024 08:01:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6BC236B007D for ; Wed, 31 Jan 2024 08:01:40 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3E4C8C0CBC for ; Wed, 31 Jan 2024 13:01:40 +0000 (UTC) X-FDA: 81739617960.22.BC883F5 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf07.hostedemail.com (Postfix) with ESMTP id 2FC9640036 for ; Wed, 31 Jan 2024 13:01:37 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706706098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ukCodLzb/G2VLqiQlvaxDGyFzovgifaCzLn8v5k78fs=; b=DTvFqtE2NbiWf9DLn00vdDSXPe91bz8+piLtsTejp3iBnHs5DPpNqogYuzKk4ZE5/w0hsl llPn2NtOAR6eVH80Fd7I0z9n41al9B79TTt6OA6Zyyap7y0xM5X+4Z2s23OSYx6ftQutFA EaeRs9CNy/kpUWXvhPULSi8nvxNkeLY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706706098; a=rsa-sha256; cv=none; b=B6htNR5g6gR5aYep1C4hBcbEoThY4ANkMLuPHm6IO4rucMmlcxKXaaV0cxkIHoWrLnzu/Y meh0BqVnEHER3PPQVEwICjLVmsZghTMdY+Jmt2Tddb70jxTJBGQxfewMwXeFLDWvg0Ig4E SBGc3Kw9iecxfjGroOJhC2SzQSdqbWM= Received: by verein.lst.de (Postfix, from userid 2407) id AEAFC68BEB; Wed, 31 Jan 2024 14:01:33 +0100 (CET) Date: Wed, 31 Jan 2024 14:01:33 +0100 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , Jan Kara , linux-mm@kvack.org, Matthew Wilcox , Jan Kara , David Howells , Christian Brauner , "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 19/19] writeback: simplify writeback iteration Message-ID: <20240131130133.GA25391@lst.de> References: <20240125085758.2393327-1-hch@lst.de> <20240125085758.2393327-20-hch@lst.de> <20240130104605.2i6mmdncuhwwwfin@quack3> <20240130141601.GA31330@lst.de> <20240130215016.npofgza5nmoxuw6m@quack3> <20240131071437.GA17336@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 2FC9640036 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: dwncwxpr94utuyosrgygoduoapwqwujf X-HE-Tag: 1706706097-744849 X-HE-Meta: U2FsdGVkX1+4XKmJxYU5ztfXhZwf4FcRHmRbC04uTMlGgXg/+LdwNokktE5gxEhj+WwASGQV8HhQ8cfTWYbwOWvIdnKAW9DJ5lGNAgfC6jdHPBS8IJqbhuc2Z0BQ9bWROn2m+HmB4YebTZpDlZc938ymrU1fGumJB5xOFS9jVKTkZ02+n5dfAuvb4hR3xs46da9iAoYteIrXxLXl5feSECLtdc5P6sl6TJj4a+QKU39PPfpQM/7ggExS0HsHwdH8pmb1FgV0fhFD+/Vj4Jll37dLrjRUbJ1fqaODwophXpg65+wWMghKk/XFWnSxQh+8RmX/u1chdvatUCzr6Ot008pD4AYDlZudcD10cI8xC7v2tSRztAl7g7aoSHyx1FvHyo0URKdZm6PcBVB2iOe9TMeEGWvLFmgPMtEmRzPho1c0UdchK4xq8rwxeCqNWH15qI1st9aAXTHcuWitfal9KtEhMKSJcV5mTdWTfbaxeuSEq5WxXn/k8SnW+KJWaz58KaJU6W74ycRJx39WBAEq0hlFud3F/x7yVMtF8yBydXZ8ZdUMjTVi9z8SqOwZYTFohY/+dGBrfoP4GUnRWOxNzDzNPXguwRk5ccl++TNACB3uj6e6mqoz0KuVecgzFdfkq//bvoptVlBgjZqGha4lJAfrClKk8I/Nqm7Ce5HjeYH5s9t7W+FRXp/UcQ7ahl+U/ZAl4cdYFatY7muVj5z4FlMgqIbyds8dlmFQYKjt/ydLr4vG36o6X1AJ3AmfvRwWW+ZhbDO4zdnfBkI/gOGlShEcikuqlKZl880H+YUotyyl45ZjX6wK8TfzAhJMk8ovVWnuwmzDErReobKhfOs01OIKKMh8HjoUzCEMXkEEXTfz/hos0c7OmLca1M6jiXT2rw7153Yy9Ty0HqethFCEcp2aPAq++nDJCiRxi1WNYAIz8kGCNTj3Nybc6RyVTaIe0lPmqiEyo0Q8s36hLmF w5EfBy+R 87Dba8pAnjXS2RejasB1P2ZPq6AQClyxEQu1GMpdL+w+Vipg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 31, 2024 at 07:50:25AM -0500, Brian Foster wrote: > The implied field initialization via !folio feels a little wonky to me > just because it's not clear from the client code that both fields must > be initialized. Even though the interface is simpler, I wonder if it's > still worth having a dumb/macro type init function that at least does > the batch and error field initialization. > > Or on second thought maybe having writeback_iter() reset *error as well > on folio == NULL might be a little cleaner without changing the > interface.... I like that second idea. An initialization helper I could live with, but if only folio needs a defined state, that seems superflous.