From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA20C4828D for ; Sat, 3 Feb 2024 17:57:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9420F6B0075; Sat, 3 Feb 2024 12:57:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82E116B0078; Sat, 3 Feb 2024 12:57:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 681A96B007B; Sat, 3 Feb 2024 12:57:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 450D76B0075 for ; Sat, 3 Feb 2024 12:57:17 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E43CE1C0F14 for ; Sat, 3 Feb 2024 17:57:16 +0000 (UTC) X-FDA: 81751249272.15.C5DFCDA Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf26.hostedemail.com (Postfix) with ESMTP id 321CA140009 for ; Sat, 3 Feb 2024 17:57:14 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b="KCVs/tCY"; spf=pass (imf26.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706983035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l4Qu1q6RKuEeOxA7OnxAR5gXRKkLwV3d96mBPvSYLxs=; b=l9bqvANaNGKhPSgf+xPL4pBBRGOn7XWISvfY1XDOqcVNhm1qEtnuTUDbYEi1xsRmiuNFw8 OmvReQ+qOSkay8reVSbfcjxdEFwJ/IGoKr2PNjo0xtcb7xyoagJzHO/GG5oxaIM6kvOWd+ 3gv5Z9Lfd51Phw/pubrMDZ6WYxrZ0d4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706983035; a=rsa-sha256; cv=none; b=mNfkefVUdP3sVOMja4kvYHviY8ALKrba5x3cjxjCKQ93+/OW/bahLFX5cRZ6jmeecUs+ph gXeme5viGj3wR0zz1obQqaUBk3l/4qc+BSorcV9QFjQi5G31wf5i49MB3Ejk2BEH29+aZ+ HJgM6XUnWtrM1jRENpdcpdVNKrUeoaw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b="KCVs/tCY"; spf=pass (imf26.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu Received: from cwcc.thunk.org (pool-173-48-82-236.bstnma.fios.verizon.net [173.48.82.236]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 413HueK6016816 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 3 Feb 2024 12:56:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1706983003; bh=l4Qu1q6RKuEeOxA7OnxAR5gXRKkLwV3d96mBPvSYLxs=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=KCVs/tCYcG6FASwSKeCTJN/GaIweqiatqM26tedyHRNWr5Nm9ZsMPGptGJVxCHr6y 7nDV5tQBtR44r1e3VUwyHuQB6DYTXp5Qn49NpINbg2AJLeNdzz6G7+woFfRsZs+Gjq GDWmNAko6C4hatS0ECCdVPOXhrl8ajdZ+RChykF3ccqMZiO2/wCkYGwM5Mu39KkSaT CIuZmq2cWaoZ+wBMBv/xW3dOMH5YppG14JbOeOqJLRAFVYPmvCLLxBm9z3y4eWn7Rm DBepFE7ZnAUR6Vn4c3mIOYTlsudCwhT5Bz/EaF0WRUUT5gPjzbiKoHi4GqPRlCUleO XBiUTtmml9rvw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 0349C15C02FC; Sat, 3 Feb 2024 12:56:40 -0500 (EST) Date: Sat, 3 Feb 2024 12:56:39 -0500 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v3 03/26] ext4: correct the hole length returned by ext4_map_blocks() Message-ID: <20240203175639.GF36616@mit.edu> References: <20240127015825.1608160-1-yi.zhang@huaweicloud.com> <20240127015825.1608160-4-yi.zhang@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240127015825.1608160-4-yi.zhang@huaweicloud.com> X-Rspamd-Queue-Id: 321CA140009 X-Rspam-User: X-Stat-Signature: bm5rfzrbfoow31k1c7yo569r8az6869u X-Rspamd-Server: rspam03 X-HE-Tag: 1706983034-769259 X-HE-Meta: U2FsdGVkX1+Jgg6xG0/ztJgzF0DP+hBfByRyjo16LC7enz5nO+Ha5CLyJBMVoHGrDnMF9j3l4qfaASXFG9lJrgqnmsyJdEhB3jKEnU9jE2Iy+FVGu5OkqgkX1GkV6sAxFawZtdsAL5zOTYSMNOzQEoOVhvgMtvwOLRvFWsYnBgHWTN40PXKvqw+AL8eWftlz2pez9mtNFRPo4+FrtGZtQcPZ3vUyj8eEVAbNTMI4k6M4wBMAe+9k29eGtPkm6ijVOAXLyjTw5XW0ITxFAIaO9t1BAoxWwZEu1wmq2SU2GAgw2jngMG7FdtYCkaPU6S4xBXYNnqdvQwLTy+N7/BivUl3vCA93ki4jwUcet21AQq0lXJGXpFoltTVz+2Gj4/3KiEGCVUtfBZc7OzL1bLtOOGXwPd0EAJCRODpKtvzOVyb0osetB7ge5ENh+nK9ltKOmqck3GyHYu2tVixnBstpOcMFC5jCmcs1k0uF1WrM2z2taSgN1YXlvXmPQyxzYnvEya9+R6qhKkJPzTc8UNn2LReTZ7JwZSLL9Nb2WpiYSt+Jy/cuZFeNvo1kwWQPaI79kY0qzF6xQTqP29qRW+uqlYGfwHOIFb71fypuTW1MPR2CzHkezCcjqq8azbmwRBxDivPL9j4Wd0se854b3BoGIbE2HZ+T9Gs2Q2ISk1BQ65k9yg1cDZ0TayNhYo+drNEIqdJGrqEFvBwtp6NdE7SengnjTg1pCItBBseGYfD1NhzPhFWUeRvySF6WzZM2klq5+r1J9NLa5Mdb/o8icRdnaVFvBP4xe6ak/LGqahoc8SGFeV9e1hcNbOPbzQuvCupVvIpu2LaW4WnWlBV27mcSww2kloqWL00BXcMGVHDWdZAAMcLnktMbhFzL2okROkXimPDCNYOS2PDelQD3aGPBOiEzPX/2RHaxAR7JwSe0gBorgBeNhPT+wtJFvoxHYqWASHjqcChbnM0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jan 27, 2024 at 09:58:02AM +0800, Zhang Yi wrote: > From: Zhang Yi > > In ext4_map_blocks(), if we can't find a range of mapping in the > extents cache, we are calling ext4_ext_map_blocks() to search the real > path and ext4_ext_determine_hole() to determine the hole range. But if > the querying range was partially or completely overlaped by a delalloc > extent, we can't find it in the real extent path, so the returned hole > length could be incorrect. > > Fortunately, ext4_ext_put_gap_in_cache() have already handle delalloc > extent, but it searches start from the expanded hole_start, doesn't > start from the querying range, so the delalloc extent found could not be > the one that overlaped the querying range, plus, it also didn't adjust > the hole length. Let's just remove ext4_ext_put_gap_in_cache(), handle > delalloc and insert adjusted hole extent in ext4_ext_determine_hole(). > > Signed-off-by: Zhang Yi > Suggested-by: Jan Kara > Reviewed-by: Jan Kara Thanks, applied. - Ted