From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE321C48260 for ; Tue, 6 Feb 2024 02:57:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51C106B0072; Mon, 5 Feb 2024 21:57:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CC1F6B0074; Mon, 5 Feb 2024 21:57:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BA916B0075; Mon, 5 Feb 2024 21:57:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2B8C86B0072 for ; Mon, 5 Feb 2024 21:57:04 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DC9FA4022B for ; Tue, 6 Feb 2024 02:57:03 +0000 (UTC) X-FDA: 81759867126.24.EB175AC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 371571C000D for ; Tue, 6 Feb 2024 02:57:02 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ntZ8TfnI; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707188222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7QBo0swOcSJxdQpLdDbud/KPHSgsa8hass03pqwHsyA=; b=2mLJQk7I/H9wtbq3zJETpXW8VBotRQp0lu087PjbQPldBy0hRKyb3xHkzEjS7s4Mgmsv9k VsMoc5ok9zPGLZFCr2bmG3jDQcgpzRp4c1qXu1wFYlWwGc8WhLDmxvJ/mC6zPuMR6xOs+j VJzAHwuX6ADbUU/GPMwO1ZbNpnG9SJc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ntZ8TfnI; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707188222; a=rsa-sha256; cv=none; b=lsgmsteNnosi4v5qp1La6v3+dXsm3SzHUtNn3exsI4zrwPb/6YDKjEC9W/s+ewJz4QvQXp ShMBh5l91Nykv6KUPpIjwhrkly52Mhzqe+Bxk3Zv5Hu2HlMiAjUp7gzZtSRCJmbuzEmI8v IW2L72MNYoCUjvqpWXG1EgguvpHeF+k= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6987D61302; Tue, 6 Feb 2024 02:57:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 871AEC433C7; Tue, 6 Feb 2024 02:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707188221; bh=HmtNX7BbgjVirQJOWQ5+9UqPhN2PgLjMAc9W23kPAGg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ntZ8TfnIyqeLdw9lHRGoflP8j9Cmq15Ar3I9cWYWl5PHrhn8ZjhVmB2bTIdwIlby/ vdF3xBbqUIy59dcd21K8BrhHr+69chx1qc3W/b2/js/LAIgeshG88kHFmkKzkkz2MW Ce3gg5Whv3WEkI1H6SgxNwsx5Z0MI3JPdt94c5wBTuE0ALuwE4LO5iQUdmnIQ3TET1 Czz2m7bwwGu3clopjmL+JtMZq97yGWJpEy49DzlfJc9sz6srK1XJ23UI6PJQKEda+4 62hRdjER15h+TII6l1orz6Lxq+nGxo2z4uKD7/MGS2zu6r6rKRHsVx1wReCgHQIXIC ko6fADKzdamGQ== From: SeongJae Park To: cuiyangpei Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xiongping1@xiaomi.com Subject: Re: [PATCH 1/2] mm/damon/sysfs: Implement recording feature Date: Mon, 5 Feb 2024 18:56:59 -0800 Message-Id: <20240206025659.203155-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240129121316.GA9706@cuiyangpei> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 371571C000D X-Stat-Signature: 3zemoqh1stguatg8snoopwy95zpcc3qq X-HE-Tag: 1707188222-337778 X-HE-Meta: U2FsdGVkX19lvGQdUTcKhn0RdZU/SHJAA5rIk1Rr1wXJHxXftjYHDJLLANvhzPB1FbsIsh/frk7P0P8274yBI6i02HgEG0dNDWxETKJL3z+SqmDSr3/pS65Of4gnvMSsA5FqmJukGRNF3vRCPDi0fNEJ6mxEDhkxbCN2MQVQujCe/1JwlOaU1riDZoC8DVvud1iElHXR/D1ANAXHppz+txl+ERDmyzEmbrfZXzIkH9T9UkBeMF1H/mi0J2SoEa8T2TTBRmHzkLazUANSMjGhgIdbpbANalUBjwyPlel7gPkah+OloR5cAT7OmtGGkMDZI0N6+QtEjZBeNcEaErI+htOXRM9TlIlQC6SJTDpJXo5YXF6qedo+5gsejIM51f4RUgJnWibfbfUg0GPsa7EBO/DWbZraHjQmakgH5ilIhKjY/2D2oaEdX2X4HtHeXlrFjhm2EffixIkfafiEFdD4dxjJ7jOYa6DPdUpOtabzcs2ihg9Is9Fu3h0cwRu9vZAKMxx5jmxAlVvB2QAUpCnPP1ZOT3j1LdQpPkMVp57CI74NVWY1U3nNi6PxBZdFT3Mr+8qp4KmiOT/sRFvG5zq4vGwN/ddEvRlR5WL2C50SKttyWQkN8HOsV28zgviq+8fjEPIdKmBmomUeYarrfluaCwsS+EctBY5peD6eyyFtS6e4IgrKGaajo3L9bF+xj0etX5dZlfOpFbbhHU3WvLuprUhnHdfQO8RsqMwTUaQU1dHfP1o2NVgBAL0sOGofWzs+8t82X/7WPU+HolQCbHpvxAr4Um7PI73e1JsP7Gxsc8URsvQgEVTJ+BZtF8vgStkxQaFugNR32taGaghbzGdPDz4vAT3giqTZQrjsKIr6109OMKDgcju+IP5x0XDQRQ9JCx7hpZheJSk4xE4YGritg+8+R5oNvsmaNfbq9J9Lxk7TnBlNGD6lq7xBHi5RFGFgeyIIqCyUvecs3uni6mB vpsdmu25 5zbkSRbWw210gFfGqSvFl+4lKYhWf4ZPNrWnTtF2mF8ckCIZNHH2rf0nRFTl/74XiKyMOP0Kfm5posTxosrQ7vUVHM/nAsKoAb/6PDaelFFVPv1nlThkeBOjAnBps2JPxrtPHQ7R+eykJFl4JPcLNviMAV33RBzLZ9sVdp5m4w0bLfKmzU4YI4Ri1jPqUBYPwiq0GTQi/oS6ZtrofISPhDp3fP6qPctSo0ewysAd4fvS/wfpg59Z5OL8zcRcDiPQj9dUtv+anhxwNAMWpXpFADDbLTaYlV5vqmX6fIDT+hQCMdTy26pZ4MNTCZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Cuiyangpei, On Mon, 29 Jan 2024 20:13:16 +0800 cuiyangpei wrote: > On Sun, Jan 28, 2024 at 08:28:04AM -0800, SeongJae Park wrote: > > On Sun, 28 Jan 2024 17:13:00 +0800 cuiyangpei wrote: > > > > > On Fri, Jan 26, 2024 at 12:04:54AM -0800, SeongJae Park wrote: > > [...] > > > > So, 'update_schemes_tried_regions' command is firstly handled by > > > > 'damon_sysfs_cmd_request_callback()', which is registered as > > > > after_wmarks_check() and after_aggregation() callback. Hence > > > > 'update_schemes_tried_regions' command is still effectively working in > > > > aggregation interval granularity. I think this is what you found, right? > > > > > > > Yes. > > > > If I'm not wrongly understanding your point, I think the concern is valid. I > > > > think we should make it works in sampling interval granularity. I will try to > > > > make so. Would that work for your use case? > > > > > > > It's much better than working in aggregation interval. > > > > Thank you for confirming. I will start working on this. > > > > Great, looking forward to seeing the progress. Just sent a patch[1] for this. I also updated DAMON user-space tool, damo, to use this improvement[2]. I hope that to help others who using DAMON with their own tool to easily understand how they can get the improvement from this patch. Also, please feel free to ask any questions and/or help. [1] https://lore.kernel.org/r/20240206025158.203097-1-sj@kernel.org [2] https://github.com/awslabs/damo/commit/75af3a1c0b3e79cd3207f0f8df5b5ac39f887450 Thanks, SJ [...]