From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4940CC48297 for ; Mon, 12 Feb 2024 10:24:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0D6F6B0071; Mon, 12 Feb 2024 05:23:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 992B26B0072; Mon, 12 Feb 2024 05:23:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80C136B0074; Mon, 12 Feb 2024 05:23:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6AE3F6B0071 for ; Mon, 12 Feb 2024 05:23:59 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D7B73A1F09 for ; Mon, 12 Feb 2024 10:23:58 +0000 (UTC) X-FDA: 81782766156.14.D1A4BCB Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf08.hostedemail.com (Postfix) with ESMTP id E27AC160004 for ; Mon, 12 Feb 2024 10:23:55 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=e9v9cHM5; spf=pass (imf08.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707733436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=er7uqV/3pxqI9E15uDGZ9iWhLJcFGSi+T2B/hFaMbBg=; b=sFI71TLNJyPyHxyJVsKfqhsq3xdAd2DRgRA9lx0/5C3mtSMpYCcuKMKVljdi+3TNxTWhCf rVujSvGHy4PF8EgH5pBr/Pzpw3sRuj+8gjpjI0u1/ZITTv4M1xZUKHWPO6pBLT5K8xGEDe wRz0yEoLfNhiyR2G+3c9SpCmcY0hkNI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707733436; a=rsa-sha256; cv=none; b=t71JEZNPrp1o4sqCaJEjQNB+2QNuTl0nlO/7qI+s4J/hZ2m1i3S5S1yDeUafe98YG3rSuW S1JOsgRXVvthJSoYJyjK6NgvOQeCon6pH3OVmL1awXMSG19avyRv0UpKAoiw4w1o1er8PX HrN7ufrClHGp5vYCf3Uk/fJikPHgVR8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=e9v9cHM5; spf=pass (imf08.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com; dmarc=none Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-55fe4534e9bso3839255a12.0 for ; Mon, 12 Feb 2024 02:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1707733434; x=1708338234; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=er7uqV/3pxqI9E15uDGZ9iWhLJcFGSi+T2B/hFaMbBg=; b=e9v9cHM5L1aiTDxDLOVN8AjaXKj54sTBboKDRslqLYPxB3YQQ2F/t6+wjZ9qGR9d4s igXngOpwv+cDaxQ8ltTOlow6xL5bieitklGdaqC42TNs6obycjs8SYyIs8qfz55KnZ8M LED0X0mP1b6P+lrN4Kan3qhHFXwMbAQMDPJ0X7Y+CSJ9C2g2PNg9vFejpVF2ZZ5Ic8wt Yuy66THpZboVtOGAKJKvXO4wzMcuSNtT6EeRiNrNJbSI03oHg7i859MPRcXfoTuXP8vI LeQvTvCu7wULPN/K/wmXqdeccZ+YqdcTb5RKZQFY6c1las69bE0l3TYKQiW7i8dBdWR+ oBBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707733434; x=1708338234; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=er7uqV/3pxqI9E15uDGZ9iWhLJcFGSi+T2B/hFaMbBg=; b=MVlzhM7hzPfjTga8vV9b1Bzy8BLuWZy2JuqYtcZs4W9Kul0+3Kmu4PSgj5QhcCclXG BnUHSL4R29p1peg0I77nF3tQ272u0jjOm6eXLvwYiAMsfS7COUZBkhZGgqBJDBYiX1g0 CMTgevOlqUVKCXbsN/utU55HCyOUWY86hQ15R8mpvPO4MqKYfsSphyYbV6sVT1WvVvGH gzlSRuYgXijnfJ3OD2bdp/kwZKExeNYaTv2cyXB4vG/j/HDXm9TW7MY6Y6WcMt+XiMIZ a4vJbph5MmNNgy8il4fXZRcC1xkj+VMrzyBNnm+LoK1MWBt7aJ7PuawkrnOouSISLECm Z24w== X-Gm-Message-State: AOJu0YzRe2Twiezsrr26XRRA7OdUzx9gKwe5dU67/WQg71n0grIzY1X/ 8kzHOrDsg5l1ERxesynzyRVjX1jJnH7L670uLf0NVBa5rtvnQxULXRomg2jdmok= X-Google-Smtp-Source: AGHT+IEIVVAUpTpqdBT16MY7gnKOm8Wgm8lU/UhtOte8u9qNN7LVPAHblq+h85cUkD6/Ed6GGvCddQ== X-Received: by 2002:a17:906:a88b:b0:a3c:cebc:9e0e with SMTP id ha11-20020a170906a88b00b00a3ccebc9e0emr567479ejb.66.1707733433939; Mon, 12 Feb 2024 02:23:53 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUPAzE+xdeF9TrZSKLD2pHEr88oRydbkgxmrvinHSvSQxUcUIyGSd4eufO2JDcBJ7dp7k0omkE0TZm5KqaV2RSmopwEH9KJUBeAuNEnCQZp/Na3kZyhqGhtsPoWUFMQWLjH8g1/XK5jmvnK3onAoGGYAjWJYmG20MsKxc8Yn9hXfF2DIBZZzGU6LHBehpCvPsVjofyX2DVddSWuIv/g8ypG3DrQoeVz4cIaOtpF0w2aQFPxniQSHtJKifQoI36QcqUz+GTeRa25cUcHcaFSIQmeIhQc0JSMEzlS4c0IEEQuh4BCexsaE+Q2RkgtWWZhpOa/zFS9tiBq7NOlJoD7GObmq5y2nTJbzou3e8N/JqJSg+NdzdwTTJUpVKPs29VIz44lxoHm6/kZeP4Smk1W08JaOjCzXRt8PuEeZ/ZindEfAW3sw5G8/+7SeMUmw0s+pjY5aq6PL8Es9QTI+gFjyh5aBJdPU11Mw/b8r+ggEfN9EqNFco+lICueODov2KMWeF9NjaBVj7iuEimn1MzGt8h09gt++g3M+hv8cjkxyNnKs568+BR8yc2MOxQQfPS10utFK8+zFVEhGgYzQdUVImLwxe37lmPhh60wZlbX9IzH8qQrJ6pXMKqI7ua/HuD+egoIQG7OQAblqLWyAAYzgzeBywNTlp4Txdjmklview3xwwTap1D5fOGoJcX3j6hu48qZsuyeGsyC9nsBmohNR1DagrdFR+BQPMd8gUJY++R62GwIzRAH4E9fbyPamjyvb3f65wE2mOTSc9FZUoRQcF639WAouaosGVNVx1Lb+cyBEU6FitjgZXDhOSgLIEDineFX73GZcKSrIBtz4oK2eq7mAoQvQNaGVZKmYrzVDunSfj481sy1kH7T62OUcjxcEqkvFA6AoU8syAnrTA/2MrCiJ2cTSBnstrRgHXEzdtHuRyNWjIHVyXNF4EoXfI jpHWpKwC eFJ5J+101mb/s4Q/1cmQ4Wz11QZhp5DbbKlvzcjLsFg2m3gpryp3twJqX5TrxCAcFt/wAV3BkzPRN88+roOQEXkWbekKlM46Y71IoxRtiUkdHJN5WqFsqlTyD5KyCw2GGJTw3SH6T/MmHAr+oOwvKSIc3aC0hV24YWulCM2OsuRuhclbmlzyt6Y2JJxxnVKaEqRxDeMNsLrGMeiDbuUhtua8pSpKm3dNm1G1WDslPC35cV5XDKSWmKAb1/M2wkuq5SETC7B1gv6XnzZnlR1wQSLix+8+kin8J6JO3gm3X+McNhBRLrxx2loxFJMo2c/xjh7wF3wDssyxKjHX5A+5fcuPqv50ODa5GDub27T0Uc32g162GnVdCC+VeowGyq11KgvugkpIVtk10/sJDfMFGpZuviKTl3msRZRr3qrlPR4dQveuCxGTOo6Oyav0FytnJtGp3LnLOhGFP3ew0jwPCoPc6cw6K+VeKW8qiwGLv/Zb8bgVl3bujL9JS6Qo/52tJiC0ZuLRKF0FHpPoBy/q+YQhTYHMl18uxLehORfxoVvopoQWyWBYfdFhJ6Zw4rz8Q3MZWMxMDQ3CncpPaKx2ctow9uTjN8qQgbOhE/nRr55TRTZYeL2J9umD0EbRUOAPfKrtRYeRcln+faWGY1RFXS0SkOu8ul3zt4sehJkmrrwdGMZP7KTM7JcjoVtmgaa5ny3FdpkRXFN6TbIN0bGzTgwdO8Q47IPyS1xFnDgY3d3inqjDrNKZ+ApxxPH0VXmkBGBMUz3yomR0ChsvRgC5CMHBStwF4uSxPqonHfDFzPjINLbSkuK5J1iq1mGTAGg/z4AFlUd/6W2ARQswjf42gEBah0qBZ/jxD0NzH+A1BvfORnnJDXSaxlJzogY3Yqw7ulEjTbff7wBfEAQd1+H23TSbMHcfcEg8bJq1L8w8lzRqmE3x5zY1gHR9uI3y8tKtTr166Quq7EosM5SUUfT9LoO3vcs6b eCXmhNk7 vesJ1Ft9sE1alaQEh Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id cd6-20020a170906b34600b00a34c07816e3sm61419ejb.73.2024.02.12.02.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 02:23:53 -0800 (PST) Date: Mon, 12 Feb 2024 11:23:52 +0100 From: Andrew Jones To: debug@rivosinc.com Cc: rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, paul.walmsley@sifive.com, palmer@dabbelt.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, corbet@lwn.net, aou@eecs.berkeley.edu, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, shuah@kernel.org, brauner@kernel.org, guoren@kernel.org, samitolvanen@google.com, evan@rivosinc.com, xiao.w.wang@intel.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, waylingii@gmail.com, greentime.hu@sifive.com, heiko@sntech.de, jszhang@kernel.org, shikemeng@huaweicloud.com, david@redhat.com, charlie@rivosinc.com, panqinglin2020@iscas.ac.cn, willy@infradead.org, vincent.chen@sifive.com, andy.chiu@sifive.com, gerg@kernel.org, jeeheng.sia@starfivetech.com, mason.huo@starfivetech.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bhe@redhat.com, chenjiahao16@huawei.com, ruscur@russell.cc, bgray@linux.ibm.com, alx@kernel.org, baruch@tkos.co.il, zhangqing@loongson.cn, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, joey.gouly@arm.com, shr@devkernel.io, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC PATCH v1 01/28] riscv: abstract envcfg CSR Message-ID: <20240212-cf2c44241bfd5e942a4e3752@orel> References: <20240125062739.1339782-1-debug@rivosinc.com> <20240125062739.1339782-2-debug@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240125062739.1339782-2-debug@rivosinc.com> X-Rspamd-Queue-Id: E27AC160004 X-Rspam-User: X-Stat-Signature: o97h7is7dtxazht736ezrxaceinncr5i X-Rspamd-Server: rspam03 X-HE-Tag: 1707733435-496241 X-HE-Meta: U2FsdGVkX18xoKbc8nCX62kwiA2+M8hgdrus/pypiq1TkyOETYVuWgDVg47+ennH6YMLb0GJ/7sNM1QraC8imHyt4GGWCSFXAjBWn7gurffJ0RFwU7dnVgg0toMB7KsBIpoYUiJq+6J3yt/WUarwPijfkyigFDDe4LDVcFW3qq5wQWJrNbhabRYhtyPd80Ubt38l1Rx78Hf99VkjSS5Kjk50B/uKTVE0/1OxQi+H4OU4kAK5KshgrCa1BTVeP6WQRv1ilg3UcyaAaUacwOdcHJVOBEua3CqwlDpD1C1AohXmEV7yKjod28Qlp0EXOOL+LZxX8/CD/S2xQEN3jMP1EskkSysf+z3fFBnB8qTvUaMeI2MFUim2+4mTYHsaOr1tMIimt0jXPz/GofkBvoao21K65OcKNKBzwqh9uvS8seMIWtHYvBL+o1zK9EoSrYUwf3YEE5tYSG3IAcWIEBFrcRT6/4fRrnG1tPzMmbVl9Na2kKjyXIgknVEze5QVl19JzIDEz/i+pI3QqqnpVQ5GYr9LYgnpqelbwEP2z2tg9oSeIS2G8zlvwEHQozX1bljkZYpDWKI7DoPppttWLj/XbWArrqIe+zwDVgZtYN7wB9xYp+qiG+gvMVpi8XeKOTRNF14UN1LPAJYJpZhdKBKMdry1CIjceBfV/Nn1VpmsfOHRpRR6KDrqFRZIP26875J+W1W/zb77Xq6VeS3QH8K4S4KxSR1Pw3DRknmjQzTksoMFTeYY+rW3PPtStO3jVCHghta7LGZlOoWq5ziQ6qUtWo9at/FEnhOdQ0P5kEUlUZ+vLWXtbkdVwDacH/sMCzApUFXVp+u6ek+rSGmOJXgcgdk4batWT8RzLvUVJQ/ZOVLYZSo5XqVdBKTXIfSLhEnLErrnKhw27BFD8CU7wjnIKEr5/7HHbZvepObc7dQbbKu2oVUFDwva5XMjAOVpyUoQMp+QGCiWkCYmoMGRhXs QNe+p3V5 Fu6IrpAAO9TZd/2yfQNN55bXbqx39MCbGci0gvGPvvp+slEBshyU2t73RLii1ULQYIcChImDXq7VbkhuscN/BzUI1dgf/zUYA1uNLq7OrTW+op1xGdplySPOUoD68SoH3kNdFtPLpCKHcDDTxJYxZjNe98eUVy/MFZCERAFYneTFWUW3D2oN/vIeWw82QoYaSLuq/kIzu45OEXjKZE0E+LsFwqngnUioHi9DLk7zhyy0o7jGTAUPPN9p3URqppGN4q7QnbhjcbFfZKzxqMi5c3o9So125zQ3sW8XS/as80kbPDQM9tLsdkE9JUYotsiqUKuCDV1HTNdubMjM10e1jZfPEbxcHa6drgqcVckVlJJI74W+z8C+KggFN91D4cIRmwL0onYeOcam9OJWf3OpY62I2pe0icFEDsScuh+TvSV3uKdGO4yibczEizitMFEnbPxYkY9lOp2XqgZE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 24, 2024 at 10:21:26PM -0800, debug@rivosinc.com wrote: > From: Deepak Gupta > > This patch abstracts envcfg CSR in kernel (as is done for other homonyn > CSRs). CSR_ENVCFG is used as alias for CSR_SENVCFG or CSR_MENVCFG depending > on how kernel is compiled. > > Additionally it changes CBZE enabling to start using CSR_ENVCFG instead of > CSR_SENVCFG. > > Signed-off-by: Deepak Gupta > --- > arch/riscv/include/asm/csr.h | 2 ++ > arch/riscv/kernel/cpufeature.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/include/asm/csr.h b/arch/riscv/include/asm/csr.h > index 306a19a5509c..b3400517b0a9 100644 > --- a/arch/riscv/include/asm/csr.h > +++ b/arch/riscv/include/asm/csr.h > @@ -415,6 +415,7 @@ > # define CSR_STATUS CSR_MSTATUS > # define CSR_IE CSR_MIE > # define CSR_TVEC CSR_MTVEC > +# define CSR_ENVCFG CSR_MENVCFG > # define CSR_SCRATCH CSR_MSCRATCH > # define CSR_EPC CSR_MEPC > # define CSR_CAUSE CSR_MCAUSE > @@ -439,6 +440,7 @@ > # define CSR_STATUS CSR_SSTATUS > # define CSR_IE CSR_SIE > # define CSR_TVEC CSR_STVEC > +# define CSR_ENVCFG CSR_SENVCFG > # define CSR_SCRATCH CSR_SSCRATCH > # define CSR_EPC CSR_SEPC > # define CSR_CAUSE CSR_SCAUSE > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > index b3785ffc1570..98623393fd1f 100644 > --- a/arch/riscv/kernel/cpufeature.c > +++ b/arch/riscv/kernel/cpufeature.c > @@ -725,7 +725,7 @@ arch_initcall(check_unaligned_access_all_cpus); > void riscv_user_isa_enable(void) > { > if (riscv_cpu_has_extension_unlikely(smp_processor_id(), RISCV_ISA_EXT_ZICBOZ)) > - csr_set(CSR_SENVCFG, ENVCFG_CBZE); > + csr_set(CSR_ENVCFG, ENVCFG_CBZE); > } > > #ifdef CONFIG_RISCV_ALTERNATIVE > -- > 2.43.0 > Reviewed-by: Andrew Jones