From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E337BC4829E for ; Tue, 13 Feb 2024 01:18:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46EB76B006E; Mon, 12 Feb 2024 20:18:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F7DD6B0074; Mon, 12 Feb 2024 20:18:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 298126B007D; Mon, 12 Feb 2024 20:18:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 179C66B006E for ; Mon, 12 Feb 2024 20:18:20 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D3E6C120ABB for ; Tue, 13 Feb 2024 01:18:19 +0000 (UTC) X-FDA: 81785019918.22.3687ED2 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf02.hostedemail.com (Postfix) with ESMTP id 307348001A for ; Tue, 13 Feb 2024 01:18:13 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707787098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g457RA5t2a9GtMRr1hDsyhRy2a2skpSIkLGjTXk9rws=; b=PDAjBkjPRvbMQsmmABg0HtINDIopaDOseKmyYd8LmkdiAuaq5d+DDwMNsDo4cUdSPfXO+8 m97cOsQW3f61Iy6t65pDBE+Eiyz2/zDbNBOa/H5+d/6zCvpi8YGz9XTAlz08xjFHivXV3y C9U9OSoyxxetH9H02LAyDBRaRw3DAAs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707787098; a=rsa-sha256; cv=none; b=SkGRQzcwDgKy/CrHIYsOPIcrxJde4hwnFgUQJwNXFEPgcCnnwU2dSf5YSnkGnWPYi40u+r 2+Sfcji+R2bjTG3QmuSvFU8rQp1lIl1xRAIrmzlqrkQw/l81B/Pc9ZbIm1mwSd7LH86pdZ GFwowo5fIOLixaZlwK3ltuu4rwA3+Ag= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none X-AuditID: a67dfc5b-d85ff70000001748-64-65cac3510c41 Date: Tue, 13 Feb 2024 10:18:04 +0900 From: Byungchul Park To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, kernel_team@skhynix.com, torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, 42.hyeyoo@gmail.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, longman@redhat.com, hdanton@sina.com, her0gyugyu@gmail.com Subject: Re: [PATCH v11 14/26] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread Message-ID: <20240213011804.GA4147@system.software.com> References: <20240124115938.80132-1-byungchul@sk.com> <20240124115938.80132-15-byungchul@sk.com> <87il3ggfz9.ffs@tglx> <20240130025836.GA49173@system.software.com> <871q9hlnl2.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871q9hlnl2.ffs@tglx> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUxTVxjHc86999zbxi53FfUMkm2WyQyLiobNZ4vZzJZlN3vLlhk/6KI0 cCONQEmrKHsLykuYIBMMLy3ElGpqAwhSDMGXshZioTSDCkyQQTcYBJm8RLbiGAxWSsz8cvLL ef7PL/8Pj8CoV7lIQZd2QjakaVM0RMkqZzZU7/i8vUuO65wEKC6Mg+Bf+SxUNdQR8NfXIqi7 cQbD1N0PYGBhGsHSTz0MlJf6EVSPjjBwwxNA4LSfJdA3/hz0B+cIeEsLCGRfbiBw79EyhuGy Egy1jk/Ad8GKwbU4yUL5FIHK8mwceh5iWLTV8GDL2gZjdjMPy6O7wRu4z4Fz6DUwXRomcMfp ZcHTMoah71YVgUDdKgc+TycL/uLzHFybtRJ4tGBjwBac46HXZcFwPSckyvtzhYOO8y4MeVca MfQ/uI2gNf83DI66+wTag9MYmhylDPxz9S6CsaIZHnILF3moPFOEoCC3jIWefzs4yBl+HZb+ riL735Lap+cYKafplORcsLBSl5VKN80jvJTTOsRLFsdJqckeK12+M4Wl6vkgJzlqvieSY76E l87N9GNptrublzorllhpvL8cfxZ1SLkvSU7RZciGXW8nKJOv9w2Q9NvK0/UWmoWqhXNIIVAx nlqfdOOn3Jb9mKwxK26jtcU/MGtMxFfp4OBimCPE7bSxdyjMjOhVUr/13TXeKCbSB7+7uTVW iXupO/Aw7FSLbkR9jfvX/5+nXtM4u74bSwdXpkIZIcRR9OpKuI5C1FB7d204skmMpq7mjlBE GarWpKAXXSZmvecL1G0fZC8g0fyM1vyM1vy/1oKYGqTWpWWkanUp8TuTM9N0p3cm6lMdKHSW tm+XD7egef8XbUgUkGaDKuGVLlnNaTOMmaltiAqMJkLVW9Epq1VJ2syvZIP+qOFkimxsQ1EC q9mi2rNwKkktHtOekI/LcrpseDrFgiIyCyW9/M7E8QMNv0bb4wYujahLN25qTkj+Q2y5V08i 8wZ6X6x4z1PwS/6Ooq09+kn2YC532POkpHB1gn9/tMzdU2l682jMxwc/TPxGv+xrXYn+8tND lS1fR03o52K+27U3XrH11ktXsszG9o/2benb/kaEyvej6WKzc/bx2c17AjFHfnam+8c0rDFZ uzuWMRi1/wG/hCFpkgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02SW0yTWRDHPee70ljzbcV4AvpgFXYDETVZ4kSNtwc9MdHogxr1QRr4Io3c bAVFswZtUbygYgS0oBbQgtBFKYZ4q3IJl9IVkBLAikRYohARUCkRQbTFGH2Z/DLz/03mYURG 1cMFiNq4g7IuThOj5hWsYstKw+JtNY3yUpthAWScWwqe0TQWcu9YeWgpLUFgvXccw0DtRugY G0Qw8ayZgezMFgR5Pa8YuFfXjcBedIIHV98saPMM8+DIPMuDoeAOD8/fTWLoyrqEocS2GZwX 8zFUjr9lIXuAh5xsA/aWfgzjlmIBLClB0FtkEmCyZxk4uts5qLnm4MDuDoWr17t4eGx3sFB3 vxeD62EuD93Wbxw46xpYaMlI5+DfoXwe3o1ZGLB4hgVorTRjuGv0bjv5aYqD+vRKDCdvlmFo e/EIwZO01xhs1nYeajyDGMptmQx8KaxF0Hv+vQCp58YFyDl+HsHZ1CwWmr/Wc2DsCoeJz7n8 2pW0ZnCYocbyQ9Q+ZmZpYz6hD0yvBGp84hao2ZZIy4tCaMHjAUzzPno4ais+zVPbx0sCPfO+ DdOhpiaBNlyZYGlfWzbeOm+3YlWUHKNNknVLVkcoou+6OviER4rDpWaSgvLEM8hPJNLfpNrw gfcxKwWRkowLjI956U/S2Tk+zf7SX6Ss1T3NjORQkJb89T6eLUWSF/9XcT5WSstJVXc/9rFK qkLEWbb2R/8P4rjax/5wQ0jn1IA3I3o5kBROTZ/gJ6lJUVPJdGSOtJBUVtTji0hp+s02/Wab ftlmxBQjf21cUqxGGxMept8fnRynPRwWGR9rQ97Hs/wzmXEfjbo2ViNJROqZyohFjbKK0yTp k2OrEREZtb+y9UqDrFJGaZKPyLr4vbrEGFlfjQJFVj1XuWmnHKGS9mkOyvtlOUHW/Zxi0S8g BR0NfenelLrtWemt9Kr5K54Wbnid67i8ne6JdBlHhwpHnBXXpIIbUrQ5eKr9zdEsu9YY7FwT rwxOSEs3tY59211vmvyUrGXCT1wP+8/oloJw6ayOdZp5UbcrckaSQp2LrV/6L+wgWosnIHEL 0P5Tgce6RmrX7DpQNto3o/N588ztalYfrVkWwuj0mu/gxPrBdAMAAA== X-CFilter-Loop: Reflected X-Stat-Signature: eocaz3hejrjwk64jwge3qg93n8k5xbcy X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 307348001A X-Rspam-User: X-HE-Tag: 1707787093-41441 X-HE-Meta: U2FsdGVkX18kgBoicnfkjtJVgJPJUQIYf2BX3rYQ4Bhh6PMfFtOLSP1fDxEUTSnhd3nH1SWoBKiTH7zwrcsCMGlshj1UAHY/3ze2YWNz1tnvJrcYnwSvCHu2TGd9wwA1g3OV/12ry+1aAD1cvVQvNTfXmg/iGmSXkb02mLlvUuE1cLHzwKHDOiNeSXuWqGV/IXmXZvxgvVXwkR3ERgzwNlJZ+3/YlzmR7G3aMgJiNE0OZJkd9ROQG32DtaaagnwrmeHi31lViO4RjKeD8TophvswUqryuur8i/46aA4ytFEBcYIeUra5QXyHtfeZ4IVLIfcfvCiVQF5npBAOiG1K9jq32aUgGU7xLcfFVuDgIM6p5Kw98hnKfQpqACLclZJSnDZR8qjO3bz1Ich/iruJ0PImwihTog0idtXKLtAsarT6iiLS7WH1wEZXEK+PYBm/1o4BUuRlkic9lLY8zg9bBhIs8wqNOT11o9bDhy+5RjlH7c77xH3qQdqH80u7i3LmlYAtDwJoY3zOilg7Q0rHT5d3/oHE0xOgE4nrbMB0SpVzmwg/78ckdhuSsEEmkVHIXWYlkp8LsEuVa9eaMj/fOmOwFvfNpSR8xk8JtkQK/MhjQ8vw+rA0Fwsne4cXdh/oR2sXxLBwOQVFwvZkTJbFJ6PJCWWCnkRnaJ8NwyZqQeNRi1n7nJHHOtPNSa0XTHjGL7FYVo26pQBCf553jjNYh3LrZ9bPKWIjkbsdPEMBmJ2FcGWnzjAuNhK2W3RX8KUVgS5vTMxPijgeRvQeXorVkF5n8N92JOBPANjrFv1kJ5+mHX5Q8NFd/fzWqEaKSDspXZmtkpnpbtGUjGcuDLHpdgtyjJcB8tJjweN3je0EDzpEYb9PWNkYqg7uoSqKLlX0HJEx8F31S8W6sQ3C/QAlaNey27EQFzUIT4O2TGXAgoousjEO8n6BbZf2ViXB0G5nn6nmcRcL2EFKtavXl+e qO7AT5gV ky0ZlM4DBKMZtHhuyiCaK1OQ9BH9PGyVT4z/2IO7sQMoDZwcfMSgMaAA0qC3s6jyBqS3T0z/9aJMQQjY1vsCjmgdlVSVkMAmSjgj4VC5TQtn2JGoVfQAzI8+9RqKGlHHD2Vol X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 04:16:41PM +0100, Thomas Gleixner wrote: > On Tue, Jan 30 2024 at 11:58, Byungchul Park wrote: > > On Fri, Jan 26, 2024 at 06:30:02PM +0100, Thomas Gleixner wrote: > >> On Wed, Jan 24 2024 at 20:59, Byungchul Park wrote: > >> > >> Why is lockdep in the subsystem prefix here? You are changing the CPU > >> hotplug (not hotplus) code, right? > >> > >> > cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was > >> > introduced to make lockdep_assert_cpus_held() work in AP thread. > >> > > >> > However, the annotation is too strong for that purpose. We don't have to > >> > use more than try lock annotation for that. > >> > >> This lacks a proper explanation why this is too strong. > >> > >> > Furthermore, now that Dept was introduced, false positive alarms was > >> > reported by that. Replaced it with try lock annotation. > >> > >> I still have zero idea what this is about. > > > > 1. can track PG_locked that is a potential deadlock trigger. > > > > https://lore.kernel.org/lkml/1674268856-31807-1-git-send-email-byungchul.park@lge.com/ > > Sure, but that wants to be explicitely explained in the changelog and > not with a link. 'Now that Dept was introduced ...' is not an > explanation. Admit. I will fix it from the next spin. Thanks. Byungchul