From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F7CFC48BC3 for ; Mon, 19 Feb 2024 06:25:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC0578D0003; Mon, 19 Feb 2024 01:25:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4BB58D0001; Mon, 19 Feb 2024 01:25:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99BD18D0003; Mon, 19 Feb 2024 01:25:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 82E9A8D0001 for ; Mon, 19 Feb 2024 01:25:52 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3BA181A0206 for ; Mon, 19 Feb 2024 06:25:52 +0000 (UTC) X-FDA: 81807567744.16.692E7F5 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf06.hostedemail.com (Postfix) with ESMTP id 589E9180009 for ; Mon, 19 Feb 2024 06:25:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708323950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HOE9eCmBTCHtsxrI5zWxaaohl9tDawOWnciphwBYESY=; b=L5ucdXKc/iRQvfQcM29JVPiX8uFgE1LHvQAei7AN/OJsJ8iSEWJJFwPgMO8xc34qPPkJRT xuLWVKxPWRpIZKvZU59Ve8ENPT7H1XsRC/vHSz+uWXuUsNNUJFjlXzYG3lPEbB8B3EAwSj KY+TO3BQQAfkhzFOj+TqZ3AUATcbpII= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708323950; a=rsa-sha256; cv=none; b=u37VQVzfHzUWqWwwSOHvdOT2y18vTDYKMygFdAqVX7lKMoz2qRS6/thgcg+8txZXm92d+n 1DDnLNWDLU96eZCC7G2j5s2OJ78RR6RpiE8NRnL/DhkHwJmAt9YfjcG34C7ETib1gfWGcw VqK2ZBioB9MKLfeu9cQ3XopO6DNqPww= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id 0034668AFE; Mon, 19 Feb 2024 07:25:44 +0100 (CET) Date: Mon, 19 Feb 2024 07:25:44 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 05/20] shmem: export shmem_get_folio Message-ID: <20240219062544.GA4346@lst.de> References: <20240129143502.189370-1-hch@lst.de> <20240129143502.189370-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 589E9180009 X-Rspam-User: X-Stat-Signature: a6asogrumbc77uhkfapsga95yp8n3sdf X-Rspamd-Server: rspam03 X-HE-Tag: 1708323950-13822 X-HE-Meta: U2FsdGVkX1/WdLwf2uY9cHY9gGkSDTpjSEEeZT2edme+QvKCAJOORKg9EoKvOiCWK5NEua3e1DxUyE7L5jo6u/SRZH3Fl+j18m/jpg2ItP2Y6gUUotRwTEhfWOG88j6K8E90IS2LDNA3vbDQREmMRjrCcZKFnTRcU5hdFlSuzXKp+6MkhlUpbvZ0IIyan0brpIoeBfiJp+Zd0xLbro2/4zKP+6DYWFvx5Gn5yjotc9iWa30tb94qgldbX91o6EbkQvo8NOowD1oa3EJPgD4ky74PzgObonlQfoS6TjQPtZGMdj8PCrWQ6NbVqPivBiJnhwaA5HlRzfhNjU3nel61cdLiPEfY5Bd9R5Tn3uza1Do1f1nxWHZuEl2j1D809i6vPQIIQ5wVlY3pSRBzhg4SfdBeg+Yw3dZ5m2GSk6UdRX7l7/RbHPT0jT8jeibAT4JPdwou8+xT+vpTu3qkVo0NaMXPafrEctbru8u9rdI9mLE65QPIEqGf0sL+v9iaWWVE5lgnJMVjbcJEy8S21Vbx27z9kS8/x2QTOA0jTCmDqAui2ndShBvhqedIV18DTolEqGizddtbjX86m+8nlVM0g02+YfQZwbjHDB/i/eFBKbULskdJcsRKPABv0K31uhT0uP7XGvJdunt50PCvrt7ZKr+6eDXkVLiermHUF6OXEo/1OrURjBW59SK5yF0+IXtAEFGfMT0QxLnCFSpciPOPXBT8pY8BNm27vBTlfPw/Mrn/a6wnBuPG/ZphmOfhLbIbHxN/C0/CFvWXsyH1QcUcTG3UZ7YKrfdJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 01:53:09PM +0000, Matthew Wilcox wrote: > I know I gave an R-b on this earlier, but Hugh made me look again, and > this comment clearly does not reflect what the function does. > Presumably it returns an errno and sets foliop if it returns 0? Almost. With SGP_READ it can set *foliop to NULL and still return 0. > Also, should this function be called shmem_lock_folio() to mirror > filemap_lock_folio()? shmem_get_folio can also allocate (and sometimes zero) a new folio. Except for the different calling conventions that closest filemap equivalent is __filemap_get_folio. For now I'd like to avoid the bikeshedding on the name and just get the work done.