linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Lance Yang <ioworker0@gmail.com>
To: akpm@linux-foundation.org, shy828301@gmail.com
Cc: ioworker0@gmail.com, david@redhat.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	mhocko@suse.com, minchan@kernel.org, peterx@redhat.com,
	songmuchun@bytedance.com, zokeefe@google.com
Subject: Re: [PATCH 1/1] mm/khugepaged: bypassing unnecessary scans with MMF_DISABLE_THP check
Date: Sun, 25 Feb 2024 12:56:01 +0800	[thread overview]
Message-ID: <20240225045601.79244-1-ioworker0@gmail.com> (raw)
In-Reply-To: <CAK1f24=2z9tk4cCCSobVpExZ+uV6N8gbGx+xiJ7p_UjrZvSv3g@mail.gmail.com>

As a diff against mm-stable.

diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index 2771fc043b3b..1c0073daad82 100644
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -920,7 +920,7 @@ static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address,
 {
 	struct vm_area_struct *vma;
 
-	if (unlikely(hpage_collapse_test_exit(mm)))
+	if (unlikely(hpage_collapse_test_exit_or_disable(mm)))
 		return SCAN_ANY_PROCESS;
 
 	*vmap = vma = find_vma(mm, address);
@@ -1428,7 +1428,7 @@ static void collect_mm_slot(struct khugepaged_mm_slot *mm_slot)
 
 	lockdep_assert_held(&khugepaged_mm_lock);
 
-	if (hpage_collapse_test_exit_or_disable(mm)) {
+	if (hpage_collapse_test_exit(mm)) {
 		/* free mm_slot */
 		hash_del(&slot->hash);
 		list_del(&slot->mm_node);
@@ -2456,7 +2456,7 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result,
 	 * Release the current mm_slot if this mm is about to die, or
 	 * if we scanned all vmas of this mm.
 	 */
-	if (hpage_collapse_test_exit_or_disable(mm) || !vma) {
+	if (hpage_collapse_test_exit(mm) || !vma) {
 		/*
 		 * Make sure that if mm_users is reaching zero while
 		 * khugepaged runs here, khugepaged_exit will find


      reply	other threads:[~2024-02-25  4:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29  5:45 [PATCH 1/1] mm/khugepaged: bypassing unnecessary scans with MMF_DISABLE_THP check Lance Yang
2024-01-29 16:28 ` Michal Hocko
2024-01-30  2:12   ` Lance Yang
2024-01-30  3:08     ` Lance Yang
2024-01-30  9:35       ` Michal Hocko
2024-01-30  9:46         ` Lance Yang
2024-01-31  0:37           ` Lance Yang
2024-01-29 18:53 ` Yang Shi
2024-01-29 19:03   ` Zach O'Keefe
2024-01-30  2:37     ` Lance Yang
2024-01-30  2:21   ` Lance Yang
2024-01-31  9:30 ` Lance Yang
2024-01-31 20:06   ` Yang Shi
2024-02-01  1:13     ` Lance Yang
2024-02-01 18:56       ` Yang Shi
2024-02-03  3:20         ` Lance Yang
2024-02-21 22:11   ` Andrew Morton
2024-02-22  7:43     ` Lance Yang
2024-02-22  7:51   ` Lance Yang
2024-02-22  8:51     ` David Hildenbrand
2024-02-22  9:12       ` Lance Yang
2024-02-22 20:23     ` Yang Shi
2024-02-22 21:11       ` Andrew Morton
2024-02-23  7:59         ` Lance Yang
2024-02-24  1:47         ` Yang Shi
2024-02-24  1:46 ` Yang Shi
2024-02-24  3:54   ` Lance Yang
2024-02-25  4:56     ` Lance Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240225045601.79244-1-ioworker0@gmail.com \
    --to=ioworker0@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=peterx@redhat.com \
    --cc=shy828301@gmail.com \
    --cc=songmuchun@bytedance.com \
    --cc=zokeefe@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).