From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D89C47DD9 for ; Sun, 25 Feb 2024 04:57:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E22526B00EC; Sat, 24 Feb 2024 23:57:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD2AF6B00ED; Sat, 24 Feb 2024 23:57:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9A206B00EE; Sat, 24 Feb 2024 23:57:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BA07E6B00EC for ; Sat, 24 Feb 2024 23:57:23 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2971980314 for ; Sun, 25 Feb 2024 04:57:23 +0000 (UTC) X-FDA: 81829117566.18.80AF2B5 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf03.hostedemail.com (Postfix) with ESMTP id 79EF620014 for ; Sun, 25 Feb 2024 04:57:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VbXtjG+X; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708837041; a=rsa-sha256; cv=none; b=RaIcmEqCaRLBDIzFksaa8ZLzXXvM2hbeUXki30O8RNM54SIbd7seLTtU3x1vXswxzB/ZLg B125c1mon5Co08Xzd4XKDyG63Mlt1ev/mAErCuO8ehSSjvTH9yrVJlOjdVFH5mliE1qNe7 wafQ4wkT1W0JqcPxjUSIeMfemRu9EDA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VbXtjG+X; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708837041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QBAbEO8N8UoJFU0GI3O78KlTzRGmo0GxF/Kd2SEwLGE=; b=rsIjEU9iQvliw+yK+zGkYQSjzxeJR96lBh+H1krQwRmTBzXKG6ebdUKPZQLUy0sLzZCoSG KebdfPIopG7nF14pthtT1g5NR1OP639k8GY6DhWrGHnIKo286jPBJXkmF4675IvK5LcRDo Mt/AoFXzAs8pVFxwwdy9eliONbznV6M= Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2995fa850ddso1095515a91.0 for ; Sat, 24 Feb 2024 20:57:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708837040; x=1709441840; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QBAbEO8N8UoJFU0GI3O78KlTzRGmo0GxF/Kd2SEwLGE=; b=VbXtjG+XpY9oL5so438J88FJS0Fpz4QUDpEeaje5NAyz9UUpMI/S8WtrR3INMQl3oG g5sfRuvrjgUMz7PSSmAK4ktDGHXBC5kWQhwcXtKVPQOtUFdSbl4BTC0SSLjvuMFNgAIa QqVTQ0+uaruhAtnvHcLmW3dWQSj4bUAqsvequ4QIku/ep8vgw8P1dgVV7FNPMrXB26v/ sl9YOAcP/IbgFWBcRUN4CCyw3gU7g8gAY9D6XA0CmNTUoL1rgUPHJbcj7G1KNQ0yc8x1 8VQpFQMZuKb2KUYqTOvwCpUsiiyv+tmI6HJe9iRxXB3rFpphndBpOYleLgV5XJ1/a7dV 6Uvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708837040; x=1709441840; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QBAbEO8N8UoJFU0GI3O78KlTzRGmo0GxF/Kd2SEwLGE=; b=b21rSzAnnpgdUAhELYl5M9QoEdRscLa8C2fhwduvb5OViiluSwYVN3BbVnxIZCXNgR GkgqZtuh8E5beeQT5W849KSs84i1C9+b8yzf8zSjdlmowFF02cWfa6+ky0WdQi17bbiR 8SjwKb4fyhQEEx8Ps+7POyO8dpgdI5sb4/y6G7uzANv74bODMADrn1X5cc1N3CRajQsw VVBtzRm3n4k0hFrhTtvaU1IpVNonq7/2Vn+9Bfa/zz3QWUode+YE0WAutQDaIPqMvh8T 9KQd22y8gSpayf8K9SkNTcM/PELkBHcpsQ/bz+TthIeVqtfcvZOPb8ti4bTKS7vrzoeu 8gjQ== X-Forwarded-Encrypted: i=1; AJvYcCVkhnLuCm+XpTiKBRbjyd6uf/ujFh0FBPhCMLezdKUp+6iQz5/8/TDpmZF/JYSh8nKF5zKPh0c1WnN3DCMTjmj+g+Q= X-Gm-Message-State: AOJu0YwHnNfSOXUaWpCX6QYB+uj/SVV8G4afssglVXDrci4bHnYMj3aj TcsQ+n+k7dpYKa4h021NAcDxAGNfCpHiKl4bTqLhf8ShmVQyh404 X-Google-Smtp-Source: AGHT+IFgN4daKjGulDEbP34bF8Wqdjxb7tb2e2NhZ8VHoy6T4niJZv2NOzn72x6PMJwrD4FG6pZnbQ== X-Received: by 2002:a17:90a:cb16:b0:299:cafa:5e8b with SMTP id z22-20020a17090acb1600b00299cafa5e8bmr4986126pjt.6.1708837040211; Sat, 24 Feb 2024 20:57:20 -0800 (PST) Received: from LancedeMBP.lan ([112.10.225.117]) by smtp.gmail.com with ESMTPSA id q6-20020a17090a2e0600b0029681231ae1sm1978635pjd.28.2024.02.24.20.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 20:57:19 -0800 (PST) From: Lance Yang To: akpm@linux-foundation.org, shy828301@gmail.com Cc: ioworker0@gmail.com, david@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, songmuchun@bytedance.com, zokeefe@google.com Subject: Re: [PATCH 1/1] mm/khugepaged: bypassing unnecessary scans with MMF_DISABLE_THP check Date: Sun, 25 Feb 2024 12:56:01 +0800 Message-Id: <20240225045601.79244-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 79EF620014 X-Stat-Signature: ju5yoww7j5qubsy9448ssnwz37f5txd8 X-HE-Tag: 1708837041-999103 X-HE-Meta: U2FsdGVkX1/BjeGHji2DtQF5B10jr/qJ6qsShjpBMvYzsBZd3U9gmAbC5o2ZTx3hpFdjlPgb4AmhncyX9WLm059K0B0Pvz8wckF0OxbO7DWE6v9hQLyTE5aYx1mCfbyWiVmedxusyGQ2XowbonGFN6NBdZzS1GWlb2/ipffmyuZ2zjI8giSMz/n7C1d4ALecFsc9C0SjbVtarsinlarJwhkvPMP/dRGlD96hC5863x5+zBvl0P/iT3uWQrSOUA5QBpF64Ha3QwBCqZMmrOdOabVdCuQfMHS0JL8nwXNse0833EcNEROZSh4ShiypNJxIApANxriJANERH2/w2rvX5SDgzmzGCW9TOaILCnLqWUo6C/PzO/cy+jzlMRImKRTpcpNK/SwisGp3755i1PqIx1IyqoLmrSiWNYl+kdjlbGBTdJQGiUwKZ5EbT6zb2a9RWgAzDa/tv37LTG34n3O76Bsz9zYfMRQ3arK43MlmSfDQxggFNUdVF1S0l1sHjakim1X9omzAMU/P4OYy146s6CMGc/FFnb2p4UP90UIZdt7R/cOwiWaFOJNqYfl1xY5oT4zOR0rjjA9mCX3M5/Vrm2KIXiWNAuGZVXyJ03y45hvD62712FosTXb5i0zJdZsRsMni9AEIBBlLR8ZRKBwjcw9RON2OrBgILkKcxUJFHT6VyeoD5BLa0OwqaWQCSZVzQhbWOzwM+8Y0OqOS5MYsGUvsi5cLo0iqUof7e64ibH3Msu5N0eBfzwVMGT2rzOViP5WHk/mCYBbzMnDCRAqtb1LqPOOWewKC0hylkukjHaTOfaetlB6tGPFhqj4ytaZOPcLmC2g5btKb3paMV1XtHQrFMND7eb6pOU49ANi2ehHLM+Bs3sWC2ZjDkfHdyYHQ267LXlDsxk+S2jy9G7B8j6qPRstXCf5ibuF3hEC0J4zXolo79NEUMhu7F+VHyLiyvo5EgM6oDssbjexoVd4 mG9Tunk2 iUgtUEy6/Gyv14KhqoJLurgB/rI3wSBl7oIrVXRWXd4i6kGidyb4ZOs8tHEN48nZTYve0+16wJiK7VqURDM2S6UX9OK6T8F9QeTdk3xO1bN/3SXCCyEz6tgjcyki9WZO5AnmH7pieTbLSDeXIFOQV1dN+c0w9c6rJsVHR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000181, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: As a diff against mm-stable. diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 2771fc043b3b..1c0073daad82 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -920,7 +920,7 @@ static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, { struct vm_area_struct *vma; - if (unlikely(hpage_collapse_test_exit(mm))) + if (unlikely(hpage_collapse_test_exit_or_disable(mm))) return SCAN_ANY_PROCESS; *vmap = vma = find_vma(mm, address); @@ -1428,7 +1428,7 @@ static void collect_mm_slot(struct khugepaged_mm_slot *mm_slot) lockdep_assert_held(&khugepaged_mm_lock); - if (hpage_collapse_test_exit_or_disable(mm)) { + if (hpage_collapse_test_exit(mm)) { /* free mm_slot */ hash_del(&slot->hash); list_del(&slot->mm_node); @@ -2456,7 +2456,7 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result, * Release the current mm_slot if this mm is about to die, or * if we scanned all vmas of this mm. */ - if (hpage_collapse_test_exit_or_disable(mm) || !vma) { + if (hpage_collapse_test_exit(mm) || !vma) { /* * Make sure that if mm_users is reaching zero while * khugepaged runs here, khugepaged_exit will find