From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37CB1C5478C for ; Mon, 26 Feb 2024 16:01:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E9E26B0185; Mon, 26 Feb 2024 11:01:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 673986B0186; Mon, 26 Feb 2024 11:01:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5134C6B0188; Mon, 26 Feb 2024 11:01:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3B0BE6B0185 for ; Mon, 26 Feb 2024 11:01:53 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3D29F1C0B1D for ; Mon, 26 Feb 2024 16:01:48 +0000 (UTC) X-FDA: 81834420696.13.8BE9C3E Received: from out30-98.freemail.mail.aliyun.com (out30-98.freemail.mail.aliyun.com [115.124.30.98]) by imf13.hostedemail.com (Postfix) with ESMTP id E456A2003C for ; Mon, 26 Feb 2024 16:01:22 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=sRL56zIl; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf13.hostedemail.com: domain of ethan.xys@linux.alibaba.com designates 115.124.30.98 as permitted sender) smtp.mailfrom=ethan.xys@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708963284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=uO744AgFJT3omawn12Dq7uRsOiSEoPU3Y3gdcHNc6O4=; b=FzyCLP79peTDOdPZx4Jyz8VvVLTCQVZn+xETqP3oSwx8lRGdtoJb0mZnncA3B9NPzGu/vh QzF7nGJezw3Xer3BfFCntGS1KU5tFYaZuePuPrsJNbW/om+IvFKQ3VQGeRzsvbWI4KcYal xi+r8B42KWSQPN53xbLZuhOf0pOCBJ4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=sRL56zIl; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf13.hostedemail.com: domain of ethan.xys@linux.alibaba.com designates 115.124.30.98 as permitted sender) smtp.mailfrom=ethan.xys@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708963284; a=rsa-sha256; cv=none; b=1qz5wYOBHMrW1/e37sRN6v4c+r1xC2OPtAFlbQgoq+IngrtHL0dqfgPt1dapWlgGH0u4+3 DROCSwxX459bLpYbGKL2gLLmE+GKHD0AWfxjq7Cv6a/0mma0SQILosDE9UPcrjJ5WSPmXJ 3JlqKp6wCCjqpPnJy69kfqhwRByI7oA= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708963279; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=uO744AgFJT3omawn12Dq7uRsOiSEoPU3Y3gdcHNc6O4=; b=sRL56zIlhsAsRuaHh9TwXY89LKYACp+JppreFo2l4ZFOXIHQ/0lQf0tRPKvytxUt7CKK6wPVb6BJCTQCUox4hTh67NwEMQfCQlMM7jhJakVSPBMGtWB3sP05htRzXt0zEq4Uk47OL6NhaROecO/aoZrxIRQ8sxLzbFhZDeDxjCo= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=ethan.xys@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0W1K5SSG_1708963266; Received: from localhost(mailfrom:ethan.xys@linux.alibaba.com fp:SMTPD_---0W1K5SSG_1708963266) by smtp.aliyun-inc.com; Tue, 27 Feb 2024 00:01:17 +0800 From: Yisheng Xie To: alex.williamson@redhat.com Cc: akpm@linux-foundation.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ethan.xys@linux.alibaba.com Subject: [PATCH] vfio/type1: unpin PageReserved page Date: Tue, 27 Feb 2024 00:01:06 +0800 Message-Id: <20240226160106.24222-1-ethan.xys@linux.alibaba.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: naiojrxsiu7qrqrxrpntfgxhp8ojkkm4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E456A2003C X-HE-Tag: 1708963282-957398 X-HE-Meta: U2FsdGVkX19TOb+2lulXQU9Ob6re8iwBEeMsMDY61vSPhdr235B0zqTidygsruZCfi6/tJ3dZakkZ+X6GM5lb2CUmQ5+HTFXqqABXH9FGl7PII+aJK52HzUf14mvtJLSRrDbueWJHcmEr+Srgt7QkG5WteReMmG73kQsdMgrZMC3d8DtPXWTXpWvxfKs2PIHcvWi8Tph2B7GNUQTvZ0coim8x7nQ4S9C0fWQjgqhL67DJHTUQKeodzNZq/PH1S6TgmgzA6Iio+AJdknt9kiyoL/fPOPLMaiUtVwijkq8GH2stIS4JmINpSEu6xPhpN8zCMfJirwSvW+d8hnYJdd1Oja6IN4EJGUjcc9qDPYygxX20d527pgFH5Qcb23v3mxRuEE5eS8wl4pkeZPSnjvVTPNAo/NCbBwSKE/0PgXg8Gj2nVYlr3b3Ecw35jR662yfS+ivz9Xtcx9UG8CMBWC6loDZh0X1DK2DLVpWF0jHj7VhK8LuSJUDG0IoJD75GFjV9c7aKBpu3B+c5L5yg0ZSz4dMezx0JQ7U3FetpYT3fjZ+odY6YskmE72v0GSB+XJr0MjdZnyvjZp+ghJ9P6qomRSARC4YIaOQrj/fIuvIetceeVHEo8aM9KQ258JXApkWaUJxoyYr5b2gZhucc5zMmkuc9+EPxkEvC7/cc5PWsLWX7XIv4guXePMVIntq7XbE6doFyndhTzkXwizX0s9NtJECQ9+njgt9pT1nwPmDVf7qF5sC1xqIj0dTaCb+CvcR7w7V4fP320VEa15Vs1uOLnR0AOGFz7WzM2DGQnKlYdXXrsJh+GGwPUp/fYLTVa24uuWYCMtqOEFQn8F3SXkbIvc5jPJvxYJ+F7q1Yf5wdnxP1cCmIBCPIZJjfK0gFAzWURkxkZ053e5azbHYopFjoDhJi9hxg12UDU2jg3ox73C4kUeHekMVO3159YbxKF7XR5wmlCm5jO6NLb/F3V6 lhB/UWGG 92p9n5kkPTlYcNOauQn7auC+qy6B7KxZN7ruzYtFJAxFd+X7kxYoXbfIsKc+4e2s+D2/2lUtc/ir0nn9LY32e43wjwTt7xs0PF/sacvaJ4wrcAaFVn65vRdryC9n0CUsf6ZwgZtOZXjeh8nklFX+63Qzt9YiN4Lb219GO7aFLS2avrFQCVW1SLGHckM4T+YTBOQRGok2WP1UGfQXqxPHyfHKwmsdZzBmproJ9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We meet a warning as following: WARNING: CPU: 99 PID: 1766859 at mm/gup.c:209 try_grab_page.part.0+0xe8/0x1b0 CPU: 99 PID: 1766859 Comm: qemu-kvm Kdump: loaded Tainted: GOE 5.10.134-008.2.x86_64 #1 Hardware name: Foxconn AliServer-Thor-04-12U-v2/Thunder2, BIOS 1.0.PL.FC.P.031.00 05/18/2022 RIP: 0010:try_grab_page.part.0+0xe8/0x1b0 Code: b9 00 04 00 00 83 e6 01 74 ca 48 8b 32 b9 00 04 00 00 f7 c6 00 00 01 00 74 ba eb 91 8b 57 34 48 89 f8 85 d2 0f 8f 48 ff ff ff <0f> 0b 31 c0 c3 48 89 fa 48 8b 0a f7 c1 00 00 01 00 0f 85 5c ff ff RSP: 0018:ffffc900b1a63b98 EFLAGS: 00010282 RAX: ffffea00000e4580 RBX: 0000000000052202 RCX: ffffea00000e4580 RDX: 0000000080000001 RSI: 0000000000052202 RDI: ffffea00000e4580 RBP: ffff88efa5d3d860 R08: 0000000000000000 R09: 0000000000000002 R10: 0000000000000008 R11: ffff89403fff7000 R12: ffff88f589165818 R13: 00007f1320600000 R14: ffffea0181296ca8 R15: ffffea00000e4580 FS: 00007f1324f93e00(0000) GS:ffff893ebfb80000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f1321694070 CR3: 0000006046014004 CR4: 00000000007726e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 PKRU: 55555554 Call Trace: follow_page_pte+0x64b/0x800 __get_user_pages+0x228/0x560 __gup_longterm_locked+0xa0/0x2f0 vaddr_get_pfns+0x67/0x100 [vfio_iommu_type1] vfio_pin_pages_remote+0x30b/0x460 [vfio_iommu_type1] vfio_pin_map_dma+0xd4/0x2e0 [vfio_iommu_type1] vfio_dma_do_map+0x21e/0x340 [vfio_iommu_type1] vfio_iommu_type1_ioctl+0xdd/0x170 [vfio_iommu_type1] ? __fget_files+0x79/0xb0 ksys_ioctl+0x7b/0xb0 ? ksys_write+0xc4/0xe0 __x64_sys_ioctl+0x16/0x20 do_syscall_64+0x2d/0x40 entry_SYSCALL_64_after_hwframe+0x44/0xa9 After add dumppage, it shows that it is a PageReserved page(e.g. zero page), whoes refcount is just overflow: page:00000000b0504535 refcount:-2147483647 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x3916 flags: 0xffffc000001002(referenced|reserved) raw: 00ffffc000001002 ffffea00000e4588 ffffea00000e4588 0000000000000000 raw: 0000000000000000 0000000000000000 80000001ffffffff 0000000000000000 gup will _pin_ a page which is PageReserved, however, put_pfn in vfio will skip unpin page which is PageReserved. So use pfn_valid in put_pfn instead of !is_invalid_reserved_pfn to unpin PageReserved page. Signed-off-by: Yisheng Xie --- drivers/vfio/vfio_iommu_type1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c index b2854d7939ce..12775bab27ee 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c @@ -461,7 +461,7 @@ static bool is_invalid_reserved_pfn(unsigned long pfn) static int put_pfn(unsigned long pfn, int prot) { - if (!is_invalid_reserved_pfn(pfn)) { + if (pfn_valid(pfn)) { struct page *page = pfn_to_page(pfn); unpin_user_pages_dirty_lock(&page, 1, prot & IOMMU_WRITE); -- 2.39.1