From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3328EC54E4A for ; Mon, 26 Feb 2024 09:43:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86FAB6B0190; Mon, 26 Feb 2024 04:43:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F8716B0191; Mon, 26 Feb 2024 04:43:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67208940014; Mon, 26 Feb 2024 04:43:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 509466B0190 for ; Mon, 26 Feb 2024 04:43:14 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 29EE2140714 for ; Mon, 26 Feb 2024 09:43:14 +0000 (UTC) X-FDA: 81833466708.14.72B0117 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by imf27.hostedemail.com (Postfix) with ESMTP id CED8140008 for ; Mon, 26 Feb 2024 09:43:10 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DrxOwcnD; spf=pass (imf27.hostedemail.com: domain of lkp@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708940592; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q2UQh1WYj0+ECTnn1oMt8+y1Ms84JHklrPj0XTTExb0=; b=Y1digLh32xs4tuKc817ou08g/gM19PoWpKNWzoPXM8YNS7PqRxqTifLf+DPmRdu1hlZEpU GigqXwXMMjLiRKrjD0LH2lhz7iCfG7h/flJjBsYCCpdkjn3Nh5YoR0s+kbYqf+WrmthFxs 1Itvh49Y7ci+/2nbyM0pfP1brlQ5qFA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708940592; a=rsa-sha256; cv=none; b=4cjwiLXQSq7lwgNNqB1VahdjvusKtkzsT8qN9PlypLZBhMe9kPXvIGgNItxRg2UfVD/YE5 n6rhq7+9CZoOKiWwrJkhJZs1KVyo3htKVJOyu1duymybOc8eo5o/SFLnSueGg08M8LJtD0 aHNnm+sZCGBjAKNrDR1T0rR1reksiIA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DrxOwcnD; spf=pass (imf27.hostedemail.com: domain of lkp@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708940591; x=1740476591; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=peeh3uBT6rkaZj0IWaTOnmOqCf87o+9OlPo0K0aPohw=; b=DrxOwcnDGo9yA5WaXRiMJKQOeXdbgtXLqcxBQQD4P1PN7yfFud8XGsAD OLacpwquQmapFGF7J80p2eRx5ZvFy4gQMEbwl+yo7AUaD+1mnGeYg+CTf DXTl/DZwNuXV6MBtWpUdqGlwfxPgA+oVaCjNaNgWnGy+6B8Q7eGPLF/Z8 z9mGLvlWGAQxxa7DXG94F2uk/JJz5sH9huTIpc5D5e8gyV19lH1sx/lna XbLH6x+SC9nxQ4p+4UavKMyVZLETOlJv7uNo9RujBBqc+7lDUnwPXjqNt EuA0c1ekz0dizaxsgHiebrCiz5/2F6j70xlKDpHMTNkimM83YAAzJqp3F g==; X-IronPort-AV: E=McAfee;i="6600,9927,10995"; a="14346766" X-IronPort-AV: E=Sophos;i="6.06,185,1705392000"; d="scan'208";a="14346766" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2024 01:43:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,185,1705392000"; d="scan'208";a="11201013" Received: from lkp-server02.sh.intel.com (HELO 3c78fa4d504c) ([10.239.97.151]) by fmviesa003.fm.intel.com with ESMTP; 26 Feb 2024 01:43:05 -0800 Received: from kbuild by 3c78fa4d504c with local (Exim 4.96) (envelope-from ) id 1reXVn-000AE7-0w; Mon, 26 Feb 2024 09:43:03 +0000 Date: Mon, 26 Feb 2024 17:42:13 +0800 From: kernel test robot To: David Laight , "'linux-kernel@vger.kernel.org'" , 'Linus Torvalds' , 'Netdev' , "'dri-devel@lists.freedesktop.org'" Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, 'Jens Axboe' , "'Matthew Wilcox (Oracle)'" , 'Christoph Hellwig' , "'linux-btrfs@vger.kernel.org'" , 'Andrew Morton' , Linux Memory Management List , 'Andy Shevchenko' , "'David S . Miller'" , 'Dan Carpenter' , 'Jani Nikula' Subject: Re: [PATCH next v2 11/11] minmax: min() and max() don't need to return constant expressions Message-ID: <202402261720.EAMC0eHM-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: CED8140008 X-Rspam-User: X-Stat-Signature: h8d3i53qn6uc7e1im973aqar49ua97qs X-Rspamd-Server: rspam03 X-HE-Tag: 1708940590-857428 X-HE-Meta: U2FsdGVkX1+Ja4V0IQs4Lz2FUbYWCI+ZgAzTQK2/I2yssd+ZJEeUD6YjU30Hw8tDehD+5oaeWC8rbuwvt96np23Gf6q9iXp9xgEbEdeFW1lPRKNp+9PoW1pKtZ3EUgmab/Crbn/XokbQL5EpoZtuqluBp8NUH5j3U/J+oY4YPfFxf0RhcMf9ljMXg2ikJVpfNfzpOeUGQYJk3MwtKC+ao24Z5AN1tBPv9Uxs7mKT06a09lgA+H5kCzxmkaE/UWaApp/J0zZVbSjY4bXwiexwQ0uo1mAI3mVj4tw7R0PyARkEhViwXvjKcKXIIusmmlzJP7pkswE5d4he1MQn4dNbSf/f22Hnnc8eT6CCLp0QGovkpGCtWITomP3nPZHA/piWI/Iq9fqu9reU2LnAYqWaSnjxPD1g9MEC+Lm8m12lakQURve6no64mkC8ucdb6EgjW0mX8uJFFiaJ2OId3TDrFCkelNUQHj4gPKU1YZVCvyJECY1UrS9hnrnfCpuK0HQkKB9kotRDR3z+yo1xMJVSRcWyeeWYg7WzVFsSr7PzmfRjvwi2wF6JV8HHPUP78Gzebm6S78yeU/JOmRqxMAqplRwd7hUVAakXAuyMrnJOMvFsgxlKwory7MN8BuGIrEG3aFDiy/8jnlIkNDInZuYc2w7U9cwgRdpruSrAGt1F6QZ9dkIu6Kr44GMPg/Knpg/kZj+2vvNt9YkkLjjbcUSDg4YdxmJkTwBzOdawvzuzxJNO7lq6Dj0GtQGVDansAK+CcXAuLb9nJUKlRIbWeyCqVNCloATkzX9BvS8MncBR33EfPNpFHNdSXAzD4YdiR0NlctUIKIOg4WLTIY+cHLEtzYzi9NTViE2Fg8pHzkGROfzWWvFEbQYzdB3E7NOsR10o/KJ9FrPgaZS1UAg+yFr+vvCdAPJD4pgee5865R6uz/mER5JvllBThl+22A1A7q6+80Ha1Buhl1FMYcJrT3C sEMA3WYs kvbvN6W8vSS0nJofc1qMdfgJHA31cmugI7JsZsfCnb4Os69PSh9oDjcxMwO0ar57EkdKhl141XyZzBw9UMfIZRcAa6bh8e269jniAzQoShl0KgDp3hkbej1grdyRg0ULBQfcdmwV7YIk9KE60Crtgbl4eFd7mMkgtyeJ5RhhiGZSygVvfgAdI02+a3ofMIYdHfnZSnDeL+QX7BnyvVjd+c1LDojjQxtWy9J6J5FIGbjZChofZlAp+tSYn6/nXZM3APkoO4J0u2nNJHB1YAdR5YTN3O3zi9g5Uo4zmvp3Sud4OK3GZrIrFWKQQ7/I6I8fR1EqiVyijn86whF5znEg+7PgbLefL5fao8TQ+K3TgrMSXrXJ7YTzUroBXNBuYexNxYX5XbE00AV/1cb6NVL0BJeSLmfq6BqGj0S1ZblpQt89uo56UkpOzmfMXlaMPZgDHXTAn0n/WtEXksl3yaXdAhjAIwjqBHxNNm9ZOrK6wngPp2Fs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linux/master mkl-can-next/testing kdave/for-next akpm-mm/mm-nonmm-unstable linus/master v6.8-rc6] [cannot apply to next-20240223 dtor-input/next dtor-input/for-linus axboe-block/for-next horms-ipvs/master next-20240223] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/David-Laight/minmax-Put-all-the-clamp-definitions-together/20240226-005902 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/a18dcae310f74dcb9c6fc01d5bdc0568%40AcuMS.aculab.com patch subject: [PATCH next v2 11/11] minmax: min() and max() don't need to return constant expressions config: i386-buildonly-randconfig-001-20240226 (https://download.01.org/0day-ci/archive/20240226/202402261720.EAMC0eHM-lkp@intel.com/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240226/202402261720.EAMC0eHM-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202402261720.EAMC0eHM-lkp@intel.com/ All warnings (new ones prefixed by >>): >> arch/x86/mm/pgtable.c:437:14: warning: variable length array used [-Wvla] 437 | pmd_t *pmds[MAX_PREALLOCATED_PMDS]; | ^~~~~~~~~~~~~~~~~~~~~ arch/x86/mm/pgtable.c:180:31: note: expanded from macro 'MAX_PREALLOCATED_PMDS' 180 | #define MAX_PREALLOCATED_PMDS MAX_UNSHARED_PTRS_PER_PGD | ^~~~~~~~~~~~~~~~~~~~~~~~~ arch/x86/mm/pgtable.c:113:2: note: expanded from macro 'MAX_UNSHARED_PTRS_PER_PGD' 113 | max_t(size_t, KERNEL_PGD_BOUNDARY, PTRS_PER_PGD) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:152:27: note: expanded from macro 'max_t' 152 | #define max_t(type, x, y) __careful_cmp(max, (type)(x), (type)(y), __COUNTER__) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:62:2: note: expanded from macro '__careful_cmp' 59 | #define __careful_cmp(op, x, y, uniq) ({ \ | ~~~~~~~~~~~ 60 | _Static_assert(__types_ok(x, y), \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 61 | #op "(" #x ", " #y ") signedness error, fix types or consider u" #op "() before " #op "_t()"); \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 62 | __cmp_once(op, x, y, uniq); }) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:57:2: note: expanded from macro '__cmp_once' 57 | __cmp(op, __x_##uniq, __y_##uniq); }) | ^ include/linux/minmax.h:52:26: note: expanded from macro '__cmp' 52 | #define __cmp(op, x, y) ((x) __cmp_op_##op (y) ? (x) : (y)) | ^ 1 warning generated. vim +437 arch/x86/mm/pgtable.c 1db491f77b6ed0 Fenghua Yu 2015-01-15 432 d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 433 pgd_t *pgd_alloc(struct mm_struct *mm) 1ec1fe73dfb711 Ingo Molnar 2008-03-19 434 { d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 435 pgd_t *pgd; 184d47f0fd3651 Kees Cook 2018-10-08 436 pmd_t *u_pmds[MAX_PREALLOCATED_USER_PMDS]; 184d47f0fd3651 Kees Cook 2018-10-08 @437 pmd_t *pmds[MAX_PREALLOCATED_PMDS]; 1ec1fe73dfb711 Ingo Molnar 2008-03-19 438 1db491f77b6ed0 Fenghua Yu 2015-01-15 439 pgd = _pgd_alloc(); 1ec1fe73dfb711 Ingo Molnar 2008-03-19 440 d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 441 if (pgd == NULL) d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 442 goto out; 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 443 d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 444 mm->pgd = pgd; 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 445 25226df4b9be7f Gustavo A. R. Silva 2022-09-21 446 if (sizeof(pmds) != 0 && 25226df4b9be7f Gustavo A. R. Silva 2022-09-21 447 preallocate_pmds(mm, pmds, PREALLOCATED_PMDS) != 0) d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 448 goto out_free_pgd; d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 449 25226df4b9be7f Gustavo A. R. Silva 2022-09-21 450 if (sizeof(u_pmds) != 0 && 25226df4b9be7f Gustavo A. R. Silva 2022-09-21 451 preallocate_pmds(mm, u_pmds, PREALLOCATED_USER_PMDS) != 0) d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 452 goto out_free_pmds; d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 453 f59dbe9ca6707e Joerg Roedel 2018-07-18 454 if (paravirt_pgd_alloc(mm) != 0) f59dbe9ca6707e Joerg Roedel 2018-07-18 455 goto out_free_user_pmds; f59dbe9ca6707e Joerg Roedel 2018-07-18 456 d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 457 /* d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 458 * Make sure that pre-populating the pmds is atomic with d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 459 * respect to anything walking the pgd_list, so that they d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 460 * never see a partially populated pgd. d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 461 */ a79e53d85683c6 Andrea Arcangeli 2011-02-16 462 spin_lock(&pgd_lock); 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 463 617d34d9e5d832 Jeremy Fitzhardinge 2010-09-21 464 pgd_ctor(mm, pgd); 25226df4b9be7f Gustavo A. R. Silva 2022-09-21 465 if (sizeof(pmds) != 0) d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 466 pgd_prepopulate_pmd(mm, pgd, pmds); 25226df4b9be7f Gustavo A. R. Silva 2022-09-21 467 25226df4b9be7f Gustavo A. R. Silva 2022-09-21 468 if (sizeof(u_pmds) != 0) f59dbe9ca6707e Joerg Roedel 2018-07-18 469 pgd_prepopulate_user_pmd(mm, pgd, u_pmds); 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 470 a79e53d85683c6 Andrea Arcangeli 2011-02-16 471 spin_unlock(&pgd_lock); 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 472 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 473 return pgd; d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 474 f59dbe9ca6707e Joerg Roedel 2018-07-18 475 out_free_user_pmds: 25226df4b9be7f Gustavo A. R. Silva 2022-09-21 476 if (sizeof(u_pmds) != 0) f59dbe9ca6707e Joerg Roedel 2018-07-18 477 free_pmds(mm, u_pmds, PREALLOCATED_USER_PMDS); d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 478 out_free_pmds: 25226df4b9be7f Gustavo A. R. Silva 2022-09-21 479 if (sizeof(pmds) != 0) f59dbe9ca6707e Joerg Roedel 2018-07-18 480 free_pmds(mm, pmds, PREALLOCATED_PMDS); d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 481 out_free_pgd: 1db491f77b6ed0 Fenghua Yu 2015-01-15 482 _pgd_free(pgd); d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 483 out: d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 484 return NULL; 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 485 } 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 486 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki