From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61936C54798 for ; Tue, 27 Feb 2024 22:11:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2CA66B013D; Tue, 27 Feb 2024 17:11:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CDB586B0140; Tue, 27 Feb 2024 17:11:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7CB46B013F; Tue, 27 Feb 2024 17:11:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A6A546B013C for ; Tue, 27 Feb 2024 17:11:34 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ED4D4120DE7 for ; Tue, 27 Feb 2024 21:54:32 +0000 (UTC) X-FDA: 81838938384.16.11724D7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 59D51A001B for ; Tue, 27 Feb 2024 21:54:30 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Po1UXSwa; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709070870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bCaArSQeZQ2S1msldJzoNjO1ckex6xMqhYNRgE2KTxo=; b=cs1xrgNQpkaYBnl4RkWKrJ/H67qL92uya6JXnZ91ec95lD+vt3owJ2dJiq1ccwkEzRgsTU IKQzEdLOR6a/6cVjV8ZumwsIwk4TJ2/AUxnr1synvHK1EJ01dSWg6dFx/WoV5nf97aaXCz fhcB3QmgxWp3G2Wos4k3Geo9RznZsoc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Po1UXSwa; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709070870; a=rsa-sha256; cv=none; b=mj5K3CwWC1lPTi7u/cMdNw94mzj9m+O6h7NPk3cKAYbxJhm5Y5ZaW8WNGa1L0eh3h8sSsT qyf3DE3QYnlSa9N1Wg1yBjuHqA1rBAY9cFY1Ls/aWQlfy3NLM4RlNOzi0ki/5kGvc43Ag/ 7o1NlGrphqiSsHPTkAH342QapPqPO6Q= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 529A86117D; Tue, 27 Feb 2024 21:54:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35BBAC433F1; Tue, 27 Feb 2024 21:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709070868; bh=vA8eme6msk4MoPwwuGHqiteV9cKh5xS6+FjpLNNJ9Tw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Po1UXSwa1+aemKO3GLrb5EI4op47v0Tv5rtx3kig3l4+PoomK+cnfLcEyGpwsnpBA DZGCD2zYaM1Ns9U4FB0/h2E465vBIro05+e1DPCcbUUeTIdNAgRaNQ6gJvMnD6JPeY c3vuR58qW7OBwd++c0a4PGX9APqQ4DOO/6WqzII7gb+ir2/rH5Febkp44tLpLQeqoI NTIZ6Lr2jTcwqeQgdJ4xgnGSG8ClamnaWAZ9etrwlXlmybowZRvAMvTyMMoJobAWok kuBlNAC3tRg//8zE98Cj7XI+jX+5Oz8Y3Hs0IBiKkLpI1y2zlMohdrqz5PQrhNIRhS UXcJH2e1zB6ZA== From: SeongJae Park To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , David Hildenbrand , Lance Yang , Ryan Roberts , Yin Fengwei Subject: Re: [PATCH v2] mm: make folio_pte_batch available outside of mm/memory.c Date: Tue, 27 Feb 2024 13:54:26 -0800 Message-Id: <20240227215426.153162-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240227104201.337988-1-21cnbao@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 59D51A001B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6xkyqni1u1iyeud6rrjoqhdpd95i14ya X-HE-Tag: 1709070870-983725 X-HE-Meta: U2FsdGVkX18+OQe7qhGZFMg6zldcmM8S/rIqtLZT6xJykqXip223/mRCWP5LnzB0toY643H+n9h5nVMUzVnZ60KbFbcGlK8trCiZ1iDP3TdvBmwZC+rK7jV9+ZlyoLacEMt6ipwbtXhP1k+l9AftqqDYV5Z9KlNPkAUkGy/B6ikC/CcX0lH6xQ29eXVy44lK3GjfwSA2AL9pTicdg+QlxDhl03m17nAmdEwc+ZrgY4dNzBBIOi4/iDfOH7baWXho9afzv1fhFR0/l3UzQXCb4EyUB+y3PxnqGFwHxrqup14vFmwnDxabFtkX101V8OsnYx/iw9Xemx62FY84I8wvRbu6eRPVezTiMIFAWu2MMpJhvSWMyMkosfiFWdox6eGPydOtGc+6hh9Ga/HjgEcqeD6krVWhXyVB+qVuFNQV+49r3DedqXxXLL7hbktRDPC7StiMQu9NTwbF6ZzuIQAEsXj1Sstl+FYeNNnjHjXJKCN+01gjqjGNbpgokIp8U18RN0eaeOphBlbhoGTP6dOzQU7WqCxJnqsGKp/Wr48oggoaxUymluk7iMlHegWC4pyfH5BPIa9hDST4ALwJuzFveX0OPYDCmRtr4jnSW7+/KHJzR70wnz0mjemUXuGN8iefduw33c/hXKrDtaJML1Ko98XhDFIZ+EVDHvlh7ELQetw6wUZJo47ljxHXBlaPTePYso3WPa0lYWLqxM5KtLOFNJ6cft6BN6EWD2yIhsTICh8mvflGI9UQ5UXZqoGl9YxIFdVwXvZYIb1WVyUwcw9wPMnDJChyzEBNjQHuDpd1XAbivbMkKFJ8oW54RQmGmddstRBWrHEo7y6m+dlfYMY7Nse/dWdsCJvIpfIMScnSrWjO8waxSCr7FwfoJtOZ8BLguJ/AhSTH9386CMvPs/iod1RCa6vrQUneWqcLXdNZ19L2gQj75BR//M4wkI2b3hKEc3gzDnCqhptDEUOxwuy PfoUJeMZ TYYEQAT2aiWPNE9XNoX3bDPaIZqLVmoJYWsLeZrcXV3gus8SuaA+3svVETlqcDi27iMVZxd9fTR8zvORu1KDXC1mv/BCKyno4bqfpNso/fZYEJqRciSjBDXRNuPCh730sO17MbkHeoRR4ijEXe2m4wI0EFh/M6FtEuYFCartDI98+nkwpPOpop5K+oEJzNQCis39htCDa8CbtpZqJHtZ1O5EDlne+mkr36s9c/o/LgBC5VQgtw9DmMeR1nYCXaM2Oxht4gZaurJW+UfUDZ+21aw29XxGIMJo3QBog3LdHlBkerPOsKKS/HE0AGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 27 Feb 2024 23:42:01 +1300 Barry Song <21cnbao@gmail.com> wrote: > From: Barry Song > > madvise, mprotect and some others might need folio_pte_batch to check if > a range of PTEs are completely mapped to a large folio with contiguous > physical addresses. Let's make it available in mm/internal.h. Hi Barry, I found this patch makes some of my build test that not setting CONFIG_MMU fails with multiple errors including below: In file included from .../mm/nommu.c:43: .../mm/internal.h: In function '__pte_batch_clear_ignored': .../mm/internal.h:98:23: error: implicit declaration of function 'pte_mkclean'; did you mean 'page_mkclean'? [-Werror=implicit-function-declaration] 98 | pte = pte_mkclean(pte); | ^~~~~~~~~~~ | page_mkclean Enabling CONFIG_MMU made the build success. I haven't had a time to look into the code yet. May I ask your opinion? Thanks, SJ [...]