From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D720C54798 for ; Wed, 28 Feb 2024 00:15:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D86096B0261; Tue, 27 Feb 2024 19:15:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D358C6B0266; Tue, 27 Feb 2024 19:15:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFD776B0269; Tue, 27 Feb 2024 19:15:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AD6FD6B0261 for ; Tue, 27 Feb 2024 19:15:12 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 494C7140D50 for ; Wed, 28 Feb 2024 00:15:12 +0000 (UTC) X-FDA: 81839292864.14.065A84E Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id E8A5D180007 for ; Wed, 28 Feb 2024 00:15:09 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NuEpe6D9; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709079310; a=rsa-sha256; cv=none; b=WFHPd1V4fNEtxL8TQxSukK6+m05nsEIXMfLIaUaZ3QhWrFsFJ478qW5Y5/LVs45GbMR/D5 tQs6J8EwSsyPgbmy/5uRZWLsUuBX/eq+DUGCLUwxwYBzuZ2OJhgf9VUgJm4eldGwdH2ssk jwGoBfJwlkc3gzTDL8L8B3v02e5kmlc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NuEpe6D9; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709079310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XpKu5xNPqsnNWvTrFIU9il7S4RM7zjHulsB8it+XFF8=; b=eLt5FK99OLcuxfVAOLoyS+uKOqimIl3vNo1pEeN8K5R0wqNdI3gAnE08fsebR32VL8mxKx xaHjsCDoKr8Fu/yseU2y2AXkruKqPOKcXMJG7YL9uiH9Z2oNTdftJQwVZ10RrzgWa0tdYt 2XktTspCIp6sCP4SaoKIceL8t0Pj2yE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 72197CE1C72; Wed, 28 Feb 2024 00:15:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9120C433F1; Wed, 28 Feb 2024 00:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709079305; bh=OdKHnKl7doxKIzicvERJ1M7c5v4jJA6BjcEqfg89J+w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NuEpe6D9vtju2zi5caO/QSjUV4lsptwksUFatD2c5sJ57T9lNhA0SeCRsTtqWHDfM AB6VwCOVTc/2+6HPHyvsivHV2PTBBwoHjfbOJ+d+IutkU6fKgp3l6fTIphkXOYz1BZ AeoiUxxcYoHOaGfkCj7+eBY55mqE4azb7mbHHHbVOUkF0YutvmNs/nw49UIwVs4U0n Y6us+NUjbtoeAPRVWNg5FVvlhNIAn+WWfVfj5DEVfkdp7m0/KKki95jVMnKkIVP75e Rjvv1Zo7REHfHSIWyDjpgUdLhzAiwohwxRFCUIejuwFh6U4uNOAeQFicCtisoruu29 yYCEhJRraee0w== From: SeongJae Park To: Barry Song <21cnbao@gmail.com> Cc: SeongJae Park , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , David Hildenbrand , Lance Yang , Ryan Roberts , Yin Fengwei Subject: Re: [PATCH v2] mm: make folio_pte_batch available outside of mm/memory.c Date: Tue, 27 Feb 2024 16:15:01 -0800 Message-Id: <20240228001501.160138-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E8A5D180007 X-Stat-Signature: pbtpe4rq88xar7xuyzq5mw884ruj4t9k X-Rspam-User: X-HE-Tag: 1709079309-910362 X-HE-Meta: U2FsdGVkX1/SlFymszZd5pGMc7mr8F/zp3dow/MGYL6uunjvnYOB7JfCnSB10bCroaJx9cdqIXZhFof23EVPLSncbfz8YWWqfLbi8bbpfdOy3U72VmtCngHtl4VeRhAUVHziDBaSAtQz+45PnWVRK0rCTvcvF312XjXwz0POQYgcQ4SIjSJm4cRbPGvPDoYLzYOQ5atG6PgtAoEFh5jLf1lBea4oRzdzSasZTZiOeZCDbv5kBYoqxKWOTFcuPYuBPIW2QoFARpfZ/vjuKV+RcwLxeOQEGbi7906763fi0FG3oeTXz+qN7GoeqiThU8YOjzR68w6wwM8wyaBa9kl2vNqiNMQdEEjhTDK8Gh6+L3H+Q5oLUeZ9qJzLHPQbvkUAlWJ0jwHnSVHs7Hj4YCjNIvu6MQ/KeqZYoryfbmKvI+hQG/BjU79eRPlfUK/8dk4V9yhtPqwB4LsPbymoXrSukW6UKrFbGrwgLO/nl8luvVt6Z8637ZGaNhAr2zWvAXbWj+9BwR71RiG5f54y3yoWQ9hALAaa4zOjinoLWr4vAM+vYZ0vrRc114i6dMQ3B38Ab9KZoM7pcQfcQiFoewFsYnxaI62ev9NVd1zdM3phyrD+evh4BXXF0VQcJL3dKAqymi0zhFxJIoZJ8GT851x67Rkigd1KF7PrdIrGMmCmZ0GxSJ8nbjwcz/uXsDNc4KXJH3i03sAItZYYg2oyN97pusb3h27sc7ABxhjYtQpyiADC/wAllQXuuoHLu9zAzzfBZSWpWur8Dl40asTciF5rnVU3GCW5rWAr/4CRKtAVfRMZ8ot0yeetKnell3DIrIjQoOZuRLpYs5f0TwH+2XgGgUyg1HHCyvrvYCbuUNdIWDmnfAShyqAY+FxGsNbYFdyMFt1ONPEf2suuQxBUBSzV8PgrML/jONAyJcNl+DzRZLazJQ25XqITQuTbfgDS30tXtbHhsoTTyGOR4uwN9iS Q2BWyCOQ vqLeG30+H7a2zTuvwSXVxQr7fa5HY7TMnhY+zuJQAVv85pmikt14K16hEBD4NHuHVxdlArYzi9/3BMv0sQJVrkiShi6TLBzRMCykBnMhFwMX4gvHXUZ243qx2EX5Ajo2uc6FeErirOn5UmQ8kPwm4A9KThNfht+tg7xNNEAZr4/8ad8OjpFwp+fTHWFh00b2eLs1g8sKXlg6SUQIfGxPYWblVwnrHjU2scszIez8QN4fqhjOzoq8jTRsNIsmCVXahf1w157tN2F28UKcmBQ1t621/yrEPCAYVh/UTcjaKFFzSrzGo5ndwTYmfGJPj5wu/MX5xThxnqGF3+QQW1SsoXpGOB/6tVAdK1bSVabBnSdhVpHy95sOE7WU76Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 28 Feb 2024 13:10:06 +1300 Barry Song <21cnbao@gmail.com> wrote: > On Wed, Feb 28, 2024 at 10:54 AM SeongJae Park wrote: > > > > On Tue, 27 Feb 2024 23:42:01 +1300 Barry Song <21cnbao@gmail.com> wrote: > > > > > From: Barry Song > > > > > > madvise, mprotect and some others might need folio_pte_batch to check if > > > a range of PTEs are completely mapped to a large folio with contiguous > > > physical addresses. Let's make it available in mm/internal.h. > > > > Hi Barry, > > > > > > I found this patch makes some of my build test that not setting CONFIG_MMU > > fails with multiple errors including below: > > > > In file included from .../mm/nommu.c:43: > > .../mm/internal.h: In function '__pte_batch_clear_ignored': > > .../mm/internal.h:98:23: error: implicit declaration of function 'pte_mkclean'; did you mean 'page_mkclean'? [-Werror=implicit-function-declaration] > > 98 | pte = pte_mkclean(pte); > > | ^~~~~~~~~~~ > > | page_mkclean > > > > Enabling CONFIG_MMU made the build success. I haven't had a time to look into > > the code yet. May I ask your opinion? > > i guess it is because we have moved some func from memory.c to > headfile. and this headfile is included by lots of > files in mm. memory.c, for itself, will only be compiled with enabled > CONFIG_MMU: > mmu-$(CONFIG_MMU) := highmem.o memory.o mincore.o \ > mlock.o mmap.o mmu_gather.o mprotect.o mremap.o \ > msync.o page_vma_mapped.o pagewalk.o \ > pgtable-generic.o rmap.o vmalloc.o > > Does the below fix your build? > > diff --git a/mm/internal.h b/mm/internal.h > index fa9e2f7db506..4e57680b74e1 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -83,6 +83,8 @@ static inline void *folio_raw_mapping(struct folio *folio) > return (void *)(mapping & ~PAGE_MAPPING_FLAGS); > } > > +#ifdef CONFIG_MMU > + > /* Flags for folio_pte_batch(). */ > typedef int __bitwise fpb_t; > > @@ -172,6 +174,7 @@ static inline int folio_pte_batch(struct folio > *folio, unsigned long addr, > > return min(ptep - start_ptep, max_nr); > } > +#endif /* CONFIG_MMU */ > > void __acct_reclaim_writeback(pg_data_t *pgdat, struct folio *folio, > int nr_throttled); Yes, applying the above diff fixed mine :) Thanks, SJ [...]