From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2731C48BF6 for ; Mon, 4 Mar 2024 08:14:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41B676B009F; Mon, 4 Mar 2024 03:14:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CBDC6B00A0; Mon, 4 Mar 2024 03:14:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 245676B00A1; Mon, 4 Mar 2024 03:14:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 111FD6B009F for ; Mon, 4 Mar 2024 03:14:31 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D76FE14096E for ; Mon, 4 Mar 2024 08:14:30 +0000 (UTC) X-FDA: 81858644700.25.08B661F Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf06.hostedemail.com (Postfix) with ESMTP id 1A4EA18001D for ; Mon, 4 Mar 2024 08:14:28 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YSySCNeL; spf=pass (imf06.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709540069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y59EUmsn936TktKB/aH9UYKKlrxQ0A+jm6Fw0p9O+fA=; b=79FN3tfWQkcV1sKP1QhittlqUPCvDEF4MtgvWAmXitiuzRLjpINctZDmH/IJQ1U+vuAZEr u0pJyhcuhDcQxndNUDOBvEdLLHr8QOj1zfe3F0WnVAIsZmag+xKB631E0Gz7SmjTqU4Jcs Ab91vCpTL3AmUm1jq6UATpUx/fVoJKo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709540069; a=rsa-sha256; cv=none; b=i3hAJrBNM3Od4NCcgdxNOqN85XODDPwTXBizeXL/lCCciKQkKBBpltndW5o+Smq4jDkfu5 Wg4NUShwDnyTgmNJRZMJqyZ3UnulqHZ4bnwqT6Q+hSDc1hXt5kmU6wXklO9iJ9BOow7qBY ip8f+wCF9G2v+5CTnaJuUysHiJfDNtA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YSySCNeL; spf=pass (imf06.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6e558a67f70so3659648b3a.0 for ; Mon, 04 Mar 2024 00:14:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709540068; x=1710144868; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y59EUmsn936TktKB/aH9UYKKlrxQ0A+jm6Fw0p9O+fA=; b=YSySCNeLH/nJFk0fkB9ZalGNyNKvgRYSOSNhLJB+oBtzeSKre+4NnSGDsA1l1Ea7n4 tEnsyYQeaHQdz3bhhBvJAMW0fzv1gfYEhLQWO7Xl04UB8QWexw6TLZoqpjYjAy7+SNiX +90I8T8g2DhtdKux9+0/+Qwnp+4ecq/Mhad9zBDEu7gD5cEjqPac2EBIhZ/WZvVtEkoi ZPzShLSHXfJYeFv9+hebVegX2iG2rTYzSulVDMqGB9NsYI36Jp29vCH3YeiNaTwx4p/S fha85MswaYFAJcBN7GsVPL2kq+dRgzuFJ0I9R3HuIwRG/0ohCs+kbSeTw3m4Ql4fG502 85dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709540068; x=1710144868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y59EUmsn936TktKB/aH9UYKKlrxQ0A+jm6Fw0p9O+fA=; b=kwBQMD6oGg/v9zqdS8PWy9zn4jlsjRhPima5uHLuqJzshdJ8p6hilbhdDLHnf2OZCz a3EVngDVHQc4UX4Su/kzvMF7egvXmzBteEG7ohl+Jx44T7pk/hmSQRgwoOMihOUk16n4 rEVUTG9bU5m02VBxKEcak1B2J1ckFkcrlmrDCARvm6gwz+2m97iVnzaXXg7jPWclgpMx yog61AUBnxKQkzgBxWR6tahZNfj3B0eWz/0HBTwo4Fhd/IUexsQKCr103u6Q+aqN4QbZ uuJcX6ZvtDcNvdTfLxfDBejDGC3VE90owhVvCqxmSk3pHgUkcsrZmtf+w9KgGuYhNx/j +E9A== X-Forwarded-Encrypted: i=1; AJvYcCXF6nDWFZf6y6CcLysJSOPx0qk4DvyPOGjql27QxyddFgFn5TwAD6TwizpJsbRLpgCPqPwefmHhZ3oofEQ2AisHVRI= X-Gm-Message-State: AOJu0YwZlgV25H7J0p0hIZ0n+heLn5UvLrcUThZ2W5187qn8yO5xZ7kC s0O7D44EQtaxKUmeKVk8OEKOGC1ehTeGgrnP4GFrDCMM1gyDdkov X-Google-Smtp-Source: AGHT+IGA7fWsmwmgOxEFHP05B2QC6S7nXvlivm8Kflb15xIyMMY/ZdBjS77UiDjrNdXg/50SGdBWOA== X-Received: by 2002:a05:6a00:b8f:b0:6e6:13ec:7178 with SMTP id g15-20020a056a000b8f00b006e613ec7178mr2688020pfj.32.1709540067899; Mon, 04 Mar 2024 00:14:27 -0800 (PST) Received: from localhost.localdomain ([2407:7000:8942:5500:aaa1:59ff:fe57:eb97]) by smtp.gmail.com with ESMTPSA id ka42-20020a056a0093aa00b006e558a67374sm6686387pfb.0.2024.03.04.00.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 00:14:27 -0800 (PST) From: Barry Song <21cnbao@gmail.com> To: akpm@linux-foundation.org, linux-mm@kvack.org, ryan.roberts@arm.com Cc: chengming.zhou@linux.dev, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mhocko@suse.com, nphamcs@gmail.com, shy828301@gmail.com, steven.price@arm.com, surenb@google.com, wangkefeng.wang@huawei.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, Barry Song , Catalin Marinas , Will Deacon , Mark Rutland , Kemeng Shi , Anshuman Khandual , Peter Collingbourne , Peter Xu , Lorenzo Stoakes , "Mike Rapoport (IBM)" , Hugh Dickins , "Aneesh Kumar K.V" , Rick Edgecombe Subject: [RFC PATCH v3 1/5] arm64: mm: swap: support THP_SWAP on hardware with MTE Date: Mon, 4 Mar 2024 21:13:44 +1300 Message-Id: <20240304081348.197341-2-21cnbao@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240304081348.197341-1-21cnbao@gmail.com> References: <20240304081348.197341-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1A4EA18001D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: kthsnq5xje7ouhqnsuexqnfn9b7jyid6 X-HE-Tag: 1709540068-638588 X-HE-Meta: U2FsdGVkX1/fG0KBPLZVDpLuFBDpV4yzAwEo/SH0E1kbHj7uNKP64ka7Z6y7+nJtN7hbp8/DNCICov3/4JFxDL62tonh+Uwsh6a8iTAmdKswwDTkNsw627IkqIhWwKbnF9CdDI5B9dn//MpZ1fpu+tvRDrQh5rnfxVRlZN2Dtgu7hC0H0qdqsfjQUejfVhFiUXJd9zd/cJkgh44NfRro6lx7fPOojniKTRzOnGGvANGlwQ0lIWDC0OtDkG4XHQgdNczRV+SNXhxJrk8dTQ8e3+cl4YFE0J/E2f4g43+3BJYodfDjH5oXdFvNbfr+7Ma9Hhq6dJtwFTn1gy2gV1KqEUm3g3PvCXavd3FQKyUz1I1N8FSvt/DioY6jwF3tiIw0UnDYbzZMfJ/HrSyVnBD1wCk2IKgAHbsCrL1wxUyqXgrrzVs8d3fjjyIkplMirgJ5mUT2wp2RrXLksubOYWHsCPhIecCQwbiI08mC+bcaie1lolq615G5IJgGpbDNyxZBw3pAcsHGlIHpF47+CCabWMSqi9QTfM+ewY6Y4MKrAIyl+qqTHlpfTU0JPGNeFP2/+vnudSz68g+98KUPJjbCACOQyM7Y7a9xe0avVbHNE0ZDfNYnFoEIZtGpmWZLRwlaYUOThW5PqrMqch7gmyX3FAzcyUgix95J8XtMZnfSI78rF0Zx69bZMyINaMVJLoi8vUcc29rOiRBevRd8hbA77pL9FwLc73ECIyU0FO/Atyj6MKbVUQa6naZpLJ7YF4RQrY/tyj+R4OZtFNWp9Zf+tdZ7navPT6kkCyjtbPl/dANysUWa81k3/9HXEBUF01nQC271ElJ4QjtO1Z/3FCH9LGZCm5hKh0158xr9/xoU1+glBYH9HgssNQSdxCYEDQx4nO+Ip9pz6LKxiFJ+d+TdvCakQF0RNISj0+I2H9HRietc6rjRVwc2IC/aJkh/aCxnX95g1Rx7+3ODqF2dxTF MPkRCEQI LuZrIbgFH2WxaeZpNX9jmQmIaocN1BJanSmEXI0kcgvkIQWHkj5gdqaylCojm/GNEQLNizqPQpaKGqfKp0SXI8TkoGJHcSZ6BUKXQkAm5LpoOcgGovSZgziiyOvT+gHF2a8QtkMqVErEg7pJgIQ5np6bFtxpkuwU8VMRQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Barry Song Commit d0637c505f8a1 ("arm64: enable THP_SWAP for arm64") brings up THP_SWAP on ARM64, but it doesn't enable THP_SWP on hardware with MTE as the MTE code works with the assumption tags save/restore is always handling a folio with only one page. The limitation should be removed as more and more ARM64 SoCs have this feature. Co-existence of MTE and THP_SWAP becomes more and more important. This patch makes MTE tags saving support large folios, then we don't need to split large folios into base pages for swapping out on ARM64 SoCs with MTE any more. arch_prepare_to_swap() should take folio rather than page as parameter because we support THP swap-out as a whole. It saves tags for all pages in a large folio. As now we are restoring tags based-on folio, in arch_swap_restore(), we may increase some extra loops and early-exitings while refaulting a large folio which is still in swapcache in do_swap_page(). In case a large folio has nr pages, do_swap_page() will only set the PTE of the particular page which is causing the page fault. Thus do_swap_page() runs nr times, and each time, arch_swap_restore() will loop nr times for those subpages in the folio. So right now the algorithmic complexity becomes O(nr^2). Once we support mapping large folios in do_swap_page(), extra loops and early-exitings will decrease while not being completely removed as a large folio might get partially tagged in corner cases such as, 1. a large folio in swapcache can be partially unmapped, thus, MTE tags for the unmapped pages will be invalidated; 2. users might use mprotect() to set MTEs on a part of a large folio. arch_thp_swp_supported() is dropped since ARM64 MTE was the only one who needed it. Cc: Catalin Marinas Cc: Will Deacon Cc: Ryan Roberts Cc: Mark Rutland Cc: David Hildenbrand Cc: Kemeng Shi Cc: "Matthew Wilcox (Oracle)" Cc: Anshuman Khandual Cc: Peter Collingbourne Cc: Steven Price Cc: Yosry Ahmed Cc: Peter Xu Cc: Lorenzo Stoakes Cc: "Mike Rapoport (IBM)" Cc: Hugh Dickins CC: "Aneesh Kumar K.V" Cc: Rick Edgecombe Signed-off-by: Barry Song Reviewed-by: Steven Price Acked-by: Chris Li --- arch/arm64/include/asm/pgtable.h | 19 ++------------ arch/arm64/mm/mteswap.c | 43 ++++++++++++++++++++++++++++++++ include/linux/huge_mm.h | 12 --------- include/linux/pgtable.h | 2 +- mm/page_io.c | 2 +- mm/swap_slots.c | 2 +- 6 files changed, 48 insertions(+), 32 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index 401087e8a43d..7a54750770b8 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -45,12 +45,6 @@ __flush_tlb_range(vma, addr, end, PUD_SIZE, false, 1) #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ -static inline bool arch_thp_swp_supported(void) -{ - return !system_supports_mte(); -} -#define arch_thp_swp_supported arch_thp_swp_supported - /* * Outside of a few very special situations (e.g. hibernation), we always * use broadcast TLB invalidation instructions, therefore a spurious page @@ -1095,12 +1089,7 @@ static inline pmd_t pmdp_establish(struct vm_area_struct *vma, #ifdef CONFIG_ARM64_MTE #define __HAVE_ARCH_PREPARE_TO_SWAP -static inline int arch_prepare_to_swap(struct page *page) -{ - if (system_supports_mte()) - return mte_save_tags(page); - return 0; -} +extern int arch_prepare_to_swap(struct folio *folio); #define __HAVE_ARCH_SWAP_INVALIDATE static inline void arch_swap_invalidate_page(int type, pgoff_t offset) @@ -1116,11 +1105,7 @@ static inline void arch_swap_invalidate_area(int type) } #define __HAVE_ARCH_SWAP_RESTORE -static inline void arch_swap_restore(swp_entry_t entry, struct folio *folio) -{ - if (system_supports_mte()) - mte_restore_tags(entry, &folio->page); -} +extern void arch_swap_restore(swp_entry_t entry, struct folio *folio); #endif /* CONFIG_ARM64_MTE */ diff --git a/arch/arm64/mm/mteswap.c b/arch/arm64/mm/mteswap.c index a31833e3ddc5..295836fef620 100644 --- a/arch/arm64/mm/mteswap.c +++ b/arch/arm64/mm/mteswap.c @@ -68,6 +68,13 @@ void mte_invalidate_tags(int type, pgoff_t offset) mte_free_tag_storage(tags); } +static inline void __mte_invalidate_tags(struct page *page) +{ + swp_entry_t entry = page_swap_entry(page); + + mte_invalidate_tags(swp_type(entry), swp_offset(entry)); +} + void mte_invalidate_tags_area(int type) { swp_entry_t entry = swp_entry(type, 0); @@ -83,3 +90,39 @@ void mte_invalidate_tags_area(int type) } xa_unlock(&mte_pages); } + +int arch_prepare_to_swap(struct folio *folio) +{ + long i, nr; + int err; + + if (!system_supports_mte()) + return 0; + + nr = folio_nr_pages(folio); + + for (i = 0; i < nr; i++) { + err = mte_save_tags(folio_page(folio, i)); + if (err) + goto out; + } + return 0; + +out: + while (i--) + __mte_invalidate_tags(folio_page(folio, i)); + return err; +} + +void arch_swap_restore(swp_entry_t entry, struct folio *folio) +{ + if (system_supports_mte()) { + long i, nr = folio_nr_pages(folio); + + entry.val -= swp_offset(entry) & (nr - 1); + for (i = 0; i < nr; i++) { + mte_restore_tags(entry, folio_page(folio, i)); + entry.val++; + } + } +} diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index de0c89105076..e04b93c43965 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -535,16 +535,4 @@ static inline int split_folio_to_order(struct folio *folio, int new_order) #define split_folio_to_list(f, l) split_folio_to_list_to_order(f, l, 0) #define split_folio(f) split_folio_to_order(f, 0) -/* - * archs that select ARCH_WANTS_THP_SWAP but don't support THP_SWP due to - * limitations in the implementation like arm64 MTE can override this to - * false - */ -#ifndef arch_thp_swp_supported -static inline bool arch_thp_swp_supported(void) -{ - return true; -} -#endif - #endif /* _LINUX_HUGE_MM_H */ diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index e1b22903f709..bfcfe3386934 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -1106,7 +1106,7 @@ static inline int arch_unmap_one(struct mm_struct *mm, * prototypes must be defined in the arch-specific asm/pgtable.h file. */ #ifndef __HAVE_ARCH_PREPARE_TO_SWAP -static inline int arch_prepare_to_swap(struct page *page) +static inline int arch_prepare_to_swap(struct folio *folio) { return 0; } diff --git a/mm/page_io.c b/mm/page_io.c index ae2b49055e43..a9a7c236aecc 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -189,7 +189,7 @@ int swap_writepage(struct page *page, struct writeback_control *wbc) * Arch code may have to preserve more data than just the page * contents, e.g. memory tags. */ - ret = arch_prepare_to_swap(&folio->page); + ret = arch_prepare_to_swap(folio); if (ret) { folio_mark_dirty(folio); folio_unlock(folio); diff --git a/mm/swap_slots.c b/mm/swap_slots.c index 90973ce7881d..53abeaf1371d 100644 --- a/mm/swap_slots.c +++ b/mm/swap_slots.c @@ -310,7 +310,7 @@ swp_entry_t folio_alloc_swap(struct folio *folio) entry.val = 0; if (folio_test_large(folio)) { - if (IS_ENABLED(CONFIG_THP_SWAP) && arch_thp_swp_supported()) + if (IS_ENABLED(CONFIG_THP_SWAP)) get_swap_pages(1, &entry, folio_nr_pages(folio)); goto out; } -- 2.34.1