From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59743C54798 for ; Tue, 5 Mar 2024 15:09:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA3546B007B; Tue, 5 Mar 2024 10:09:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A538B6B007D; Tue, 5 Mar 2024 10:09:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91ACA6B007E; Tue, 5 Mar 2024 10:09:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 81DA26B007B for ; Tue, 5 Mar 2024 10:09:30 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AF8E51C0288 for ; Tue, 5 Mar 2024 15:09:29 +0000 (UTC) X-FDA: 81863319258.15.574DDEC Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf12.hostedemail.com (Postfix) with ESMTP id 3601A40005 for ; Tue, 5 Mar 2024 15:09:25 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=A7Epnr91; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf12.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.51 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709651366; a=rsa-sha256; cv=none; b=SLnkSnC66KHx8WRighkrxnXrEXoioXMFxfddPBj7y3+ZsYnGh9iIDS4rg83+hAY77P6IRm jDPF7CZUV6XzishV+5X3kFpuBBUtM0I6SZS7pMUmR9Ejj7x5fpfwLeb4WCuDPwTq3osNxa BBHGy+200USsxh5N1UL1dvyOlHn0Pq8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=A7Epnr91; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf12.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.51 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709651366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sMJUcs7j0iO8KThfdIZ+8SZ0/aXDPhgmGxD0Vm/szV8=; b=cN+682aaOV9CneqbWAurAvOy39Mkar3DCcH3F7RJP/qHc0ipHROYcezHh+92PZlN6ZQPK5 rSzYwBDp0Tt6VlN4zkVOLhGKmQqmk4PSpWrWDu993sQFgIQj2QFpurJDCYnQJpeFcvtZkD SXO2IBskaxpij8Xw7/2umqWPC8dFRuY= Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6907ab22f47so7799786d6.3 for ; Tue, 05 Mar 2024 07:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1709651365; x=1710256165; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sMJUcs7j0iO8KThfdIZ+8SZ0/aXDPhgmGxD0Vm/szV8=; b=A7Epnr91wd84hhfRynLuBX/Jtah70HQqv+dAORaul6XidkAYxFxEGhNgLrYAZiqZds eAo2hU9RnjFfZnINHHl8YwxnkKzDkZSu0//E4lNE9CvwEZSFZ46SssnM0ekHhN04ZgW4 AdPWbsQxAcXSQ4G3ei+ACA80Q1rQqpT50dlKsyINb0xUPX5vTh8+OG9Nd/KpiF9IG2LV ZtMH+SPmE7hhAXdXKSVlK4hma8NW6voogK22oXApnAm39sPZFxz1H0dBFviY9Odhce4J DDE/AjCvOn1Y7giThgr4of6nA9iQrd9dVRs9nEEJyXVMInTn/NGetnMvhYe1n0pLrjxv Y7Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709651365; x=1710256165; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sMJUcs7j0iO8KThfdIZ+8SZ0/aXDPhgmGxD0Vm/szV8=; b=GN7ATZsR6ZH31rsx3/KpcWAugNDzid1hx8d7C0Hyik+cJj5xHJQTWHGnPydEXlcNvB ktTox7KJaLMgHFN0KpPTBZsrboxPK1BiL5unUJHXLodQ8owi1DlgTsQRzHK3/FnO020C CJKciCXKchq4X0r5tW3xnTL6qO+FOG9P/Fa2pJqM8hv16sK3FZBzfPYx9pO1Qi/1tT2U PA1jq5hrVEFaiEAITUnLnHCf0sThnI0r+hD4rXzN0arXUIQeYBL4KgjvihP3HQdDMuaS nkENBzZRiKEkjorWlzMielyOJ5lTZ/dNWbzUfry9voBp8ckM0/KiOIv61lg1IhfB4R1r 7nEA== X-Forwarded-Encrypted: i=1; AJvYcCXt+sNFWz7nw5nflY5a5LZ7tsHZIqQDIOoP8JQj5/MWYVXGJZgk2SDvWzo7GAYl+OJbQpn63Pyti1nOoP3s+wyOm3E= X-Gm-Message-State: AOJu0YynWu4VHvA8pM4nyu6O86Yh203YpPxSXUYusVv7p5WR/VYlzEVr fvxYqt9qZiGT4HDAozmvDy53GpUSKFqHZUFox1p8M5AA15xWFTmBoNrjQzrEmbs= X-Google-Smtp-Source: AGHT+IE2IpfsU80i1T3mMZ3R93xTJ1vHYotlevR91JRgi3ykt8c2lEcD3RWlivEX3IlhMEUM9eO+5A== X-Received: by 2002:a05:6214:70b:b0:690:6e84:3e11 with SMTP id c11-20020a056214070b00b006906e843e11mr2241127qvz.63.1709651365113; Tue, 05 Mar 2024 07:09:25 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id qq3-20020a0562142c0300b0068f11430971sm6328206qvb.35.2024.03.05.07.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 07:09:24 -0800 (PST) Date: Tue, 5 Mar 2024 10:09:23 -0500 From: Johannes Weiner To: Chengming Zhou Cc: akpm@linux-foundation.org, yosryahmed@google.com, nphamcs@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH mm-unstable] mm/zswap: global lru and shrinker shared by all zswap_pools fix Message-ID: <20240305150923.GB1491027@cmpxchg.org> References: <20240210-zswap-global-lru-v3-1-200495333595@bytedance.com> <20240305075345.1493214-1-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305075345.1493214-1-chengming.zhou@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3601A40005 X-Stat-Signature: gesgr474whagxeut8pdwnrdwgrjf6y5o X-HE-Tag: 1709651365-956259 X-HE-Meta: U2FsdGVkX199wt+uIbh6CnhhQZzGPyRtPYUZ97FYG1lxRGhRmN/Pr0CmouCfIMsYq4V1a9ZLLoVLTdXpbzIi/NeYJOPTL1ABqUUeXG2CgogpFHN3RZwAmp6i2iwmYIBWoeVOvovY+craAR5UHrgiLJLHPKSkWtgvzsUHie6NcV4m58+S6g++WX1mirhKe3tL6WheLF+rxDa+OZARWMKhF9Tc6UIpeI8pSb2hfQ+JX+JQqs7xAjKOLfY8WIg+drMuO9ypdXXxq2r+lsy6w9L9Srr6MUccWXDYnqiX/QLuHks4vHkREzGxqQXz5MuyxIFSzkzpD1u0hOQfmSUsArarPqgWyp16uS5+0PeVrxQG8bqXMIMlixkyduZ6DWUXkIeuEJXcUh+p5cnZGXHKXKxgoEjKvhlTAN0pg4mS0crIajWv3O66cFC4YohosoiqcevUKbOT3yO0nr+iQIowUQfN52jIJ/6FPrn5uRQRT/BlD8yCJheiDWKhPpEjwg9llPrsLZXrysdAGh/4cIT+r57OLVhY1FTWz1pN40WDM9h41ZhjL4tzoLaVbcl8EcXcpCz+2BWzehFYX2xgJJ3tgZAjxUh1KPz/xgzYd2/VZf+mFi39tVD1am6gdZlECI7MKm7C00P5C+s+VS+3QkW4YuBptdCPnO/jfgCnUi6rJYpEdCHzjQGWqactVqEOVfFjn36kTclImqaSu2TdWkULUEI/Fy/VjkutcCDZFiKu20UCenuaCFiDBtRiMl10QFk3qbU7L/V8K4W06ZnpN+4g2kXcyHzUQ3tWade5ZXdAt0+XER+SeZfpGFTxu7BDfsNxdQ8XHHfMiZ32OwZ6N2V8ziwNBEEdtLKOMp6QCygQ/SqobonwYS89heqkskhI8tttVTwnnIrvROiihYXfdgMRMgdz0X5K5qPxHujtijynH+AZbJKFm19KZGm98OMq6ORoC483Ry5bL0FGVl8lPy9pY4L d5F9BRBW oYsrLRmPC1guI1VUmj9TkbQwpqVTRjjKneyIV0FLLcubtbmt84Ne7YBewbKGMOKDTaBdCQpkM8nN+e3mYsCc7GxyeQsi/OzclND/p8qE2ZtruCJkbPbB+QwavcTrpVTKTPqU3BXTP5o3PKAfYJY0PItW2S3uoxEiDXqkxLtnJQbHmXJ7oV3mC8EcPjR+slTxVIGBpgN+AYXEt4Ut53zd1y7OliEaeCAM6Shr9hdotpoEjocHHbvVjTMt4LHMkEEbTB1QI4YUuvfZXD6MdIJyenhVNEjN/iqEAvstj/BNG9Wj7ST62MWk9XVJoX9oL5F4W1+JLlywx5tUtGY3AK/foOyHmJJj7odzMniEIiF8oQ34cRos/ObZ/IjltOTP5Sm1NhyBM5FQS9NeWZe0oAHcSuiXbvG3YqIK6GHoCw9anCyRNnMVoWoa6+xoEGmRQqcYrO9lU4EjdBS/wouNagBi0bnHuVk1t5twg+NJoLJidwx27LT1WvHSXZCn4Z+ut5EdGywjuIofaDYMSOfdywufv0UXC57VUkLu2EBXgFhB6XBM0dl7Wk49Vx3nHMYeAM2DZkGzajI9WRVTjq6I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 05, 2024 at 07:53:45AM +0000, Chengming Zhou wrote: > The commit bf9b7df23cb3 ("mm/zswap: global lru and shrinker shared by > all zswap_pools") introduced a new lock to protect zswap_next_shrink, > instead of reusing zswap_pools_lock. > > But the problem is that it's initialized only when zswap enabled, > which causes bug if zswap_memcg_offline_cleanup() called without > zswap enabled. > > Fix it by using DEFINE_SPINLOCK() to statically initialize them > and define them as multiple static variables to keep in consistent > with the existing global variables in zswap. > > Fixes: bf9b7df23cb3 ("mm/zswap: global lru and shrinker shared by all zswap_pools") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202403051008.a8cf8a94-lkp@intel.com > Signed-off-by: Chengming Zhou Acked-by: Johannes Weiner