linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: peterx@redhat.com
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Muchun Song <muchun.song@linux.dev>,
	Jason Gunthorpe <jgg@nvidia.com>,
	peterx@redhat.com, Matthew Wilcox <willy@infradead.org>,
	Mike Rapoport <rppt@kernel.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	x86@kernel.org, sparclinux@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
	"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Subject: [PATCH RFC 09/13] mm/powerpc: Redefine pXd_huge() with pXd_leaf()
Date: Wed,  6 Mar 2024 18:41:43 +0800	[thread overview]
Message-ID: <20240306104147.193052-10-peterx@redhat.com> (raw)
In-Reply-To: <20240306104147.193052-1-peterx@redhat.com>

From: Peter Xu <peterx@redhat.com>

PowerPC book3s 4K mostly has the same definition on both, except pXd_huge()
constantly returns 0 for hash MMUs.  AFAICT that is fine to be removed,
because pXd_huge() reflects a hugetlb entry, while it's own hugetlb pgtable
lookup function (__find_linux_pte() shared by all powerpc code) already use
pXd_leaf() irrelevant of the MMU type.  It means pXd_leaf() should work all
fine with hash MMU pgtables or something could already went wrong.

The goal should be that we will have one API pXd_leaf() to detect all kinds
of huge mappings.  AFAICT we need to use the pXd_leaf() impl (rather than
pXd_huge() ones) to make sure ie. THPs on hash MMU will also return true.

This helps to simplify a follow up patch to drop pXd_huge() treewide.

Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>
Cc: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 arch/powerpc/include/asm/book3s/64/pgtable-4k.h | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/arch/powerpc/include/asm/book3s/64/pgtable-4k.h b/arch/powerpc/include/asm/book3s/64/pgtable-4k.h
index 48f21820afe2..92545981bb49 100644
--- a/arch/powerpc/include/asm/book3s/64/pgtable-4k.h
+++ b/arch/powerpc/include/asm/book3s/64/pgtable-4k.h
@@ -8,22 +8,12 @@
 #ifdef CONFIG_HUGETLB_PAGE
 static inline int pmd_huge(pmd_t pmd)
 {
-	/*
-	 * leaf pte for huge page
-	 */
-	if (radix_enabled())
-		return !!(pmd_raw(pmd) & cpu_to_be64(_PAGE_PTE));
-	return 0;
+	return pmd_leaf(pmd);
 }
 
 static inline int pud_huge(pud_t pud)
 {
-	/*
-	 * leaf pte for huge page
-	 */
-	if (radix_enabled())
-		return !!(pud_raw(pud) & cpu_to_be64(_PAGE_PTE));
-	return 0;
+	return pud_leaf(pud);
 }
 
 /*
-- 
2.44.0



  parent reply	other threads:[~2024-03-06 10:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 10:41 [PATCH RFC 00/13] mm/treewide: Remove pXd_huge() API peterx
2024-03-06 10:41 ` [PATCH RFC 01/13] mm/hmm: Process pud swap entry without pud_huge() peterx
2024-03-07 18:12   ` Jason Gunthorpe
2024-03-08  6:50     ` Peter Xu
2024-03-06 10:41 ` [PATCH RFC 02/13] mm/gup: Cache p4d in follow_p4d_mask() peterx
2024-03-06 10:41 ` [PATCH RFC 03/13] mm/gup: Check p4d presence before going on peterx
2024-03-07 20:08   ` Jason Gunthorpe
2024-03-06 10:41 ` [PATCH RFC 04/13] mm/x86: Change pXd_huge() behavior to exclude swap entries peterx
2024-03-07 20:16   ` Jason Gunthorpe
2024-03-06 10:41 ` [PATCH RFC 05/13] mm/sparc: " peterx
2024-03-06 10:41 ` [PATCH RFC 06/13] mm/arm: Use macros to define pmd/pud helpers peterx
2024-03-06 10:41 ` [PATCH RFC 07/13] mm/arm: Redefine pmd_huge() with pmd_leaf() peterx
2024-03-06 10:41 ` [PATCH RFC 08/13] mm/arm64: Merge pXd_huge() and pXd_leaf() definitions peterx
2024-03-06 10:41 ` peterx [this message]
2024-03-06 12:56   ` [PATCH RFC 09/13] mm/powerpc: Redefine pXd_huge() with pXd_leaf() Michael Ellerman
2024-03-07  3:05     ` Peter Xu
2024-03-06 10:41 ` [PATCH RFC 10/13] mm/gup: Merge pXd huge mapping checks peterx
2024-03-07 20:19   ` Jason Gunthorpe
2024-03-06 10:41 ` [PATCH RFC 11/13] mm/treewide: Replace pXd_huge() with pXd_leaf() peterx
2024-03-06 10:41 ` [PATCH RFC 12/13] mm/treewide: Remove pXd_huge() peterx
2024-03-06 10:41 ` [PATCH RFC 13/13] mm: Document pXd_leaf() API peterx
2024-03-08 15:20   ` Jason Gunthorpe
2024-03-11  9:58 ` [PATCH RFC 00/13] mm/treewide: Remove pXd_huge() API Christophe Leroy
2024-03-12 20:01   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240306104147.193052-10-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=jgg@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=muchun.song@linux.dev \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=rppt@kernel.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).