From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D50CC48BF6 for ; Thu, 7 Mar 2024 15:56:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 505376B01F7; Thu, 7 Mar 2024 10:56:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B5B16B01F8; Thu, 7 Mar 2024 10:56:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3567C6B01F9; Thu, 7 Mar 2024 10:56:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 25A066B01F7 for ; Thu, 7 Mar 2024 10:56:11 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C4AF1C07D8 for ; Thu, 7 Mar 2024 15:56:10 +0000 (UTC) X-FDA: 81870694500.28.6900C6D Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf20.hostedemail.com (Postfix) with ESMTP id BF9821C0003 for ; Thu, 7 Mar 2024 15:56:07 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YZVsf51x; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of lkp@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709826968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LUBKYvJ10xlh8k9vEM2vFpPiQmA6uIb1z9gEEzMbeQM=; b=RKgxOwUK0vgL1YZmgRX3ojFLJjjF0UotoYwGdV4BpPZ6uP2EdmalY3PhcgHWgiFkuGZRTD /s1M5C0mwnaiJNrTUe4sTNKVEmovJMQO4JYVhaq5uJ0SHZ0b2sZ2wFN9DY2ThM5SV7LaNr 7/yEspf5KIQbYmK6402kW6qAeEPb0E4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YZVsf51x; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of lkp@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709826968; a=rsa-sha256; cv=none; b=mbN5IMAgsksfWhwC1d2YFqFyc7u9TNqwLYj3wBw+zMzfzSLBIZoNcZjfqZU3+dIa3XGTVi k4b4jmhkdGAqpJC4/lQVzlCp5qsfDYzIx4Lc17dS6SGh/Oh/XFE6DBpcWbyFkEJIXGWZva 6FrmmzF7cz/S/nf1YBh8eew6rX64LwA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709826968; x=1741362968; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=C97P1YtElo3JLtKjB9OGWqTuuFxMbHJ54++v1vIY3Tg=; b=YZVsf51x2q2TvhQjXUZk89ICcgiJAntS10Obz2LRtgbtmwiJwc5omaCX T93Nofa1YBM9mfyQgo7k2Huvbexio0f7KLe7BguEAEcQDxAv+tcsd4OcP zpT1mz2CAEbvV7/gV0uPrqAbeiuqck7MA+cYjP26+RXi10kZteWb8KD59 O7zzXe0Slf454XxwuONF8EnHLIywnZJoXibYRWG6Ha/erztoYLBSXcZC8 qOJyIF1Lkw3PPiz6r7dcts8/1GrakUM8fouN8hKNxPRIe9U2i7Mhrwvlv XCp6pdzPX01ul9Z8VMg57+SktexhTrxInT43MEZjelxkYCbvRaPrC6bgz Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="15148089" X-IronPort-AV: E=Sophos;i="6.07,211,1708416000"; d="scan'208";a="15148089" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 07:56:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,211,1708416000"; d="scan'208";a="41049480" Received: from lkp-server01.sh.intel.com (HELO b21307750695) ([10.239.97.150]) by orviesa002.jf.intel.com with ESMTP; 07 Mar 2024 07:56:02 -0800 Received: from kbuild by b21307750695 with local (Exim 4.96) (envelope-from ) id 1riG6B-0005JO-38; Thu, 07 Mar 2024 15:55:59 +0000 Date: Thu, 7 Mar 2024 23:55:09 +0800 From: kernel test robot To: Max Kellermann , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, willy@infradead.org, sfr@canb.auug.org.au, Max Kellermann Subject: Re: [PATCH v3 06/14] linux/mm.h: move folio_size(), ... to mm/folio_size.h Message-ID: <202403072311.1a9jXzWI-lkp@intel.com> References: <20240305085919.1601395-7-max.kellermann@ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305085919.1601395-7-max.kellermann@ionos.com> X-Rspamd-Queue-Id: BF9821C0003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: b3snxjhxy68wmt6nuj81m5hykpukqc81 X-HE-Tag: 1709826967-897327 X-HE-Meta: U2FsdGVkX18GlPe8aS1Y/boqD4EFOXLYwPTGeoD4WivOCRhQU6V4vMeccTf+1k8e9SQFjHL3bZJP4jyDh7oAllQ/Kr7xoLT8PWgznZatiPWz9NySPU8TCfvIhUO0KG4OjgtiHwls07np1nHrmXTu5z7+eFa+AjxWceb4hVf/p3/H3IkyAoAsrmFxegcREil1aTwayaZYIAvSipgcCiVE68DAdO/SLf4wVYsrasis2vudTje8aG7QaoDkdlLzN84g54oLwh5kJpWyQfNdjMemRbAFzkdvchTZHWZNkmeKq2BStiQQfKtS7sEf6kTCHlhOkf99Q4UUsoPni29ENzsISW3A9PNPatMg1mb76yI3i9CA0cFZmBuTLN/gr/SrQzxpZRSSAIOp+sBggdEL7PS/UryTiBskM19riTDw2CBQIU035l5ickPtcqUyNZKNQEIyZm31ZQX19G08x1WObqvI0L9ntob/LjHWqkckmawBfP3INVDXjDCbVaqSHGogqE/dsyXxas+E2dfRuGxxIVfX6grdE9F3pMU7rBzOJORg0wJ99E+EdzoV0bI7MiMARhWYOyHHrhyXvVUspCIpZflQlPcXj2AAJTJQ9EBUpz3lfAnJaZRoIeG4M9uigX11S3LRyCw+oW9CVW++IqvJNXNqV/YVL7hwXREhL7Eo2EjwRdujJhkUKxigj0l2NM7EghBFUc40CBoniVoTuYg5uj/IOqfir0VSbssxRUfNPFS3sbr7d/9iUYY5WnFYl3B7hYZ9rytOcC4W9uDfN9XobsGPctA0VKSPVjp6hmI5lbraDCdj1q9PvP+UdPjQG4/E4PfxYMXlfr7hO/NLB2D7gKyPVWyE5I3sX9Pa+SgXV49ffSEPxUZjmBxZ6T732unRaQiwITCHujHI1hU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Max, kernel test robot noticed the following build errors: [auto build test ERROR on next-20240305] [cannot apply to akpm-mm/mm-everything char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus joro-iommu/next broonie-spi/for-next powerpc/next powerpc/fixes linus/master v6.8-rc7 v6.8-rc6 v6.8-rc5 v6.8-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Max-Kellermann/drivers-add-missing-includes-on-linux-mm-h-and-others/20240305-170312 base: next-20240305 patch link: https://lore.kernel.org/r/20240305085919.1601395-7-max.kellermann%40ionos.com patch subject: [PATCH v3 06/14] linux/mm.h: move folio_size(), ... to mm/folio_size.h config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20240307/202403072311.1a9jXzWI-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240307/202403072311.1a9jXzWI-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202403072311.1a9jXzWI-lkp@intel.com/ All error/warnings (new ones prefixed by >>): In file included from include/linux/mm/folio_size.h:8, from include/linux/mm.h:5, from arch/loongarch/include/asm/vdso.h:10, from arch/loongarch/vdso/vgetcpu.c:6: >> include/linux/page-flags.h:202:1: warning: data definition has no type or storage class 202 | DECLARE_STATIC_KEY_FALSE(hugetlb_optimize_vmemmap_key); | ^~~~~~~~~~~~~~~~~~~~~~~~ >> include/linux/page-flags.h:202:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_FALSE' [-Werror=implicit-int] >> include/linux/page-flags.h:202:1: warning: parameter names (without types) in function declaration In file included from include/linux/mm/folio_size.h:8, from include/linux/mm.h:5, from arch/loongarch/include/asm/vdso.h:10, from arch/loongarch/include/asm/vdso/vdso.h:11, from arch/loongarch/include/asm/vdso/gettimeofday.h:13, from include/vdso/datapage.h:151, from lib/vdso/gettimeofday.c:5, from : >> include/linux/page-flags.h:202:1: warning: data definition has no type or storage class 202 | DECLARE_STATIC_KEY_FALSE(hugetlb_optimize_vmemmap_key); | ^~~~~~~~~~~~~~~~~~~~~~~~ >> include/linux/page-flags.h:202:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_FALSE' [-Werror=implicit-int] >> include/linux/page-flags.h:202:1: warning: parameter names (without types) in function declaration include/linux/page-flags.h: In function 'page_fixed_fake_head': >> include/linux/page-flags.h:210:14: error: implicit declaration of function 'static_branch_unlikely' [-Werror=implicit-function-declaration] 210 | if (!static_branch_unlikely(&hugetlb_optimize_vmemmap_key)) | ^~~~~~~~~~~~~~~~~~~~~~ include/linux/page-flags.h: In function 'page_fixed_fake_head': >> include/linux/page-flags.h:210:14: error: implicit declaration of function 'static_branch_unlikely' [-Werror=implicit-function-declaration] 210 | if (!static_branch_unlikely(&hugetlb_optimize_vmemmap_key)) | ^~~~~~~~~~~~~~~~~~~~~~ >> include/linux/page-flags.h:210:38: error: 'hugetlb_optimize_vmemmap_key' undeclared (first use in this function) 210 | if (!static_branch_unlikely(&hugetlb_optimize_vmemmap_key)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/page-flags.h:210:38: note: each undeclared identifier is reported only once for each function it appears in >> include/linux/page-flags.h:210:38: error: 'hugetlb_optimize_vmemmap_key' undeclared (first use in this function) 210 | if (!static_branch_unlikely(&hugetlb_optimize_vmemmap_key)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/page-flags.h:210:38: note: each undeclared identifier is reported only once for each function it appears in cc1: some warnings being treated as errors cc1: some warnings being treated as errors make[3]: *** [scripts/Makefile.build:244: arch/loongarch/vdso/vgetcpu.o] Error 1 make[3]: *** [scripts/Makefile.build:244: arch/loongarch/vdso/vgettimeofday.o] Error 1 make[3]: Target 'include/generated/vdso-offsets.h' not remade because of errors. make[2]: *** [arch/loongarch/Makefile:163: vdso_prepare] Error 2 make[2]: Target 'prepare' not remade because of errors. make[1]: *** [Makefile:240: __sub-make] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:240: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +202 include/linux/page-flags.h 9223b4190fa129 Christoph Lameter 2008-04-28 200 47010c040dec8a Muchun Song 2022-04-28 201 #ifdef CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP cf5472e5611338 Muchun Song 2022-06-28 @202 DECLARE_STATIC_KEY_FALSE(hugetlb_optimize_vmemmap_key); a6b40850c442bf Muchun Song 2022-03-22 203 e7d324850bfcb3 Muchun Song 2022-03-22 204 /* 838691a1c0ec44 Muchun Song 2022-06-28 205 * Return the real head page struct iff the @page is a fake head page, otherwise 838691a1c0ec44 Muchun Song 2022-06-28 206 * return the @page itself. See Documentation/mm/vmemmap_dedup.rst. e7d324850bfcb3 Muchun Song 2022-03-22 207 */ e7d324850bfcb3 Muchun Song 2022-03-22 208 static __always_inline const struct page *page_fixed_fake_head(const struct page *page) e7d324850bfcb3 Muchun Song 2022-03-22 209 { cf5472e5611338 Muchun Song 2022-06-28 @210 if (!static_branch_unlikely(&hugetlb_optimize_vmemmap_key)) e7d324850bfcb3 Muchun Song 2022-03-22 211 return page; e7d324850bfcb3 Muchun Song 2022-03-22 212 e7d324850bfcb3 Muchun Song 2022-03-22 213 /* e7d324850bfcb3 Muchun Song 2022-03-22 214 * Only addresses aligned with PAGE_SIZE of struct page may be fake head e7d324850bfcb3 Muchun Song 2022-03-22 215 * struct page. The alignment check aims to avoid access the fields ( e7d324850bfcb3 Muchun Song 2022-03-22 216 * e.g. compound_head) of the @page[1]. It can avoid touch a (possibly) e7d324850bfcb3 Muchun Song 2022-03-22 217 * cold cacheline in some cases. e7d324850bfcb3 Muchun Song 2022-03-22 218 */ e7d324850bfcb3 Muchun Song 2022-03-22 219 if (IS_ALIGNED((unsigned long)page, PAGE_SIZE) && e7d324850bfcb3 Muchun Song 2022-03-22 220 test_bit(PG_head, &page->flags)) { e7d324850bfcb3 Muchun Song 2022-03-22 221 /* e7d324850bfcb3 Muchun Song 2022-03-22 222 * We can safely access the field of the @page[1] with PG_head e7d324850bfcb3 Muchun Song 2022-03-22 223 * because the @page is a compound page composed with at least e7d324850bfcb3 Muchun Song 2022-03-22 224 * two contiguous pages. e7d324850bfcb3 Muchun Song 2022-03-22 225 */ e7d324850bfcb3 Muchun Song 2022-03-22 226 unsigned long head = READ_ONCE(page[1].compound_head); e7d324850bfcb3 Muchun Song 2022-03-22 227 e7d324850bfcb3 Muchun Song 2022-03-22 228 if (likely(head & 1)) e7d324850bfcb3 Muchun Song 2022-03-22 229 return (const struct page *)(head - 1); e7d324850bfcb3 Muchun Song 2022-03-22 230 } e7d324850bfcb3 Muchun Song 2022-03-22 231 return page; e7d324850bfcb3 Muchun Song 2022-03-22 232 } e7d324850bfcb3 Muchun Song 2022-03-22 233 #else e7d324850bfcb3 Muchun Song 2022-03-22 234 static inline const struct page *page_fixed_fake_head(const struct page *page) e7d324850bfcb3 Muchun Song 2022-03-22 235 { e7d324850bfcb3 Muchun Song 2022-03-22 236 return page; e7d324850bfcb3 Muchun Song 2022-03-22 237 } e7d324850bfcb3 Muchun Song 2022-03-22 238 #endif e7d324850bfcb3 Muchun Song 2022-03-22 239 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki